From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Christoph Hellwig <hch@lst.de>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-ia64@vger.kernel.org,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Helge Deller <deller@gmx.de>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, Christian Borntraeger <borntraeger@de.ibm.com>,
Ingo Molnar <mingo@redhat.com>, Matt Turner <mattst88@gmail.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Vasily Gorbik <gor@linux.ibm.com>,
schnelle@linux.ibm.com, hca@linux.ibm.com,
Nicolin Chen <nicoleotsuka@gmail.com>,
ink@jurassic.park.msu.ru, Thomas Gleixner <tglx@linutronix.de>,
gerald.schaefer@linux.ibm.com, rth@twiddle.net,
Tony Luck <tony.luck@intel.com>,
linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-alpha@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
"open list:LINUX FOR POWERPC PA SEMI PWRFICIENT"
<linuxppc-dev@lists.ozlabs.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 1/2] dma-mapping: introduce dma_get_seg_boundary_nr_pages()
Date: Thu, 3 Sep 2020 19:53:07 +0200 [thread overview]
Message-ID: <7e1c3632-0917-0892-c1ca-8048674a3b05@csgroup.eu> (raw)
In-Reply-To: <20200903161252.GA24841@lst.de>
Le 03/09/2020 à 18:12, Christoph Hellwig a écrit :
> On Thu, Sep 03, 2020 at 01:57:39PM +0300, Andy Shevchenko wrote:
>>> +{
>>> + if (!dev)
>>> + return (U32_MAX >> page_shift) + 1;
>>> + return (dma_get_seg_boundary(dev) >> page_shift) + 1;
>>
>> Can it be better to do something like
>> unsigned long boundary = dev ? dma_get_seg_boundary(dev) : U32_MAX;
>>
>> return (boundary >> page_shift) + 1;
>>
>> ?
>
> I don't really see what that would buy us.
>
I guess it would avoid the duplication of >> page_shift) + 1
Christophe
next prev parent reply other threads:[~2020-09-03 17:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 22:16 [PATCH 0/2] dma-mapping: update default segment_boundary_mask Nicolin Chen
2020-09-01 22:16 ` [PATCH 1/2] dma-mapping: introduce dma_get_seg_boundary_nr_pages() Nicolin Chen
2020-09-03 3:47 ` Michael Ellerman
2020-09-03 10:57 ` Andy Shevchenko
2020-09-03 16:12 ` Christoph Hellwig
2020-09-03 17:53 ` Christophe Leroy [this message]
2020-09-01 22:16 ` [PATCH 2/2] dma-mapping: set default segment_boundary_mask to ULONG_MAX Nicolin Chen
2020-09-02 8:13 ` [PATCH 0/2] dma-mapping: update default segment_boundary_mask Niklas Schnelle
2020-09-03 3:26 ` Nicolin Chen
2020-09-03 16:13 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e1c3632-0917-0892-c1ca-8048674a3b05@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=James.Bottomley@hansenpartnership.com \
--cc=andy.shevchenko@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=fenghua.yu@intel.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=nicoleotsuka@gmail.com \
--cc=paulus@samba.org \
--cc=rth@twiddle.net \
--cc=schnelle@linux.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).