linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Chris Chiu <chiu@endlessos.org>,
	cascardo@holoscopio.com, don@syst.com.br, dvhart@infradead.org,
	andy@infradead.org
Cc: platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux@endlessos.org,
	Carlo Caione <carlo@endlessm.com>
Subject: Re: [PATCH] x86/platform: classmate-laptop: add WiFi media button
Date: Tue, 8 Dec 2020 11:18:48 +0100	[thread overview]
Message-ID: <7e225468-5af3-fcd1-8aee-bde2344a0ec0@redhat.com> (raw)
In-Reply-To: <20201208061111.29073-1-chiu@endlessos.org>

Hi,

On 12/8/20 7:11 AM, Chris Chiu wrote:
> From: Carlo Caione <carlo@endlessm.com>
> 
> The WiFi media button on the Quanta NL3 reports keycodes 0x8b and 0x9b
> to the platform driver. Add the mapping to support these codes.
> 
> Signed-off-by: Carlo Caione <carlo@endlessm.com>
> Reviewed-by: Chris Chiu <chiu@endlessos.org>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
>  drivers/platform/x86/classmate-laptop.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
> index af063f690846..3e03e8d3a07f 100644
> --- a/drivers/platform/x86/classmate-laptop.c
> +++ b/drivers/platform/x86/classmate-laptop.c
> @@ -1023,6 +1023,8 @@ static int cmpc_keys_codes[] = {
>  	KEY_CAMERA,
>  	KEY_BACK,
>  	KEY_FORWARD,
> +	KEY_UNKNOWN,
> +	KEY_WLAN, /* NL3: 0x8b (press), 0x9b (release) */
>  	KEY_MAX
>  };
>  
> 


      reply	other threads:[~2020-12-08 10:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08  6:11 [PATCH] x86/platform: classmate-laptop: add WiFi media button Chris Chiu
2020-12-08 10:18 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e225468-5af3-fcd1-8aee-bde2344a0ec0@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=andy@infradead.org \
    --cc=carlo@endlessm.com \
    --cc=cascardo@holoscopio.com \
    --cc=chiu@endlessos.org \
    --cc=don@syst.com.br \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@endlessos.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).