From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752504AbcL2Ho7 (ORCPT ); Thu, 29 Dec 2016 02:44:59 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:52191 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751686AbcL2Ho5 (ORCPT ); Thu, 29 Dec 2016 02:44:57 -0500 X-AuditID: b6c32a37-f79116d000000e56-e4-5864b7b16426 Subject: Re: [PATCH] Revert "mmc: dw_mmc-rockchip: add runtime PM support" To: Randy Li , linux-mmc@vger.kernel.org Cc: shawn.lin@rock-chips.com, randy.li@rock-chips.com, ulf.hansson@linaro.org, heiko@sntech.de, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Jaehoon Chung Message-id: <7e37b8ad-39d0-3a94-f75a-2166ae2caf10@samsung.com> Date: Thu, 29 Dec 2016 16:13:52 +0900 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0gUURTGuTu74xjtNo1lByuVCYskt51xzTHT3rGVf5hCSQ9scgeV3Ac7 u5URZS720Ohd1iYqKkVamdquJopmxpZhBdUSko8sjLIXvZXKdncK/O93z/3OOd93uQRGncFD iGyjVbAY+RwanyB33Z6riapr1Kdpzj+bwb3tHUXc2OCwgqt/6VFwj5tLcK5z7BjiPg+MYVyF yyXjnr+qVXDuqxuWBOqee1pwXUPVPt1vR5tc1+gpxXT23mKF7kt9aDK+UViUJfB6wRIuGDNM +mxjZgK9NjV9eXrMAg0TxcRxsXS4kTcICfSKpOSoVdk5Xk90+A4+x+YtJfOiSM9PXGQx2axC eJZJtCbQmxiGVTOaWDXLsmpt9JaFbIxXslXI6i+8i8wnp+9yFrmxPFQVXIgCCSC1MNx1EZc4 GB711Xp5AkGRTQgqe4Yx6XBQBkVlZQH/O546egOki0sIKqqfKHwXFNmHYOh1ko+DyDVQcX5I VogIYgoZD677tE+PkV0IOpu7MZ8GJ+dB43e3zMdKMhGcz17658jJCLhxpxz5eCq5Hhr63wRI msnw81Sf3MeB5GK4YB/x28ZIDZw7fVsmcRg0XHnvdw1kRwB8+TjqNwHkTKhvx6QAK+BycbtC 4iB4677xL9h0qP7TI5N6ixD8+VqHS4cjCHqcNTJJFQ39A32YtE0FH74dUUgLlHDoACWhDl64 /s1fCp96PiHpsbzhHb860XEU5hiXxzEug2NchnKEVaNgwSwaMgWRMUerRd4g2oyZ6gyToR75 v2RkbBO6/iCpA5EEoicqzaH6NErB7xBzDR0ICIyeorzu9JaUej53t2AxpVtsOYLYgWK8b3wC C5maYfJ+cKM1ndEuYLSslmFiWQ1LT1NW7o9Po8hM3ipsFwSzYPnfJyMCQ/JQ6q2R3MTN9oKB 7ksjs1atoaqPqo7HU8nyiBO2003bUhzLPLj7wI+wsftxxTfjzlyj2sLsrezCo26rQRVJtcSp CkpXjq4e/Fxz76xzXVP+yZTeWiJq0j1LvqrAvke7pC6l+93heHXotzlBs0tGzEzXzrt755Y+ 1Hpah/Iv9i89lEfQcjGLZyIxi8j/BXqQwxmoAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrAIsWRmVeSWpSXmKPExsVy+t9jAd2N21MiDNouc1i8uvuL0eL/o9es FpseX2O1uLxrDpvFkf/9jBafHvxntli0bRuTxZ0n61ktjq8Nd+D0uHNtD5vH5iX1Hn9n7Wfx 2H5tHrNH893prB6fN8kFsEW52WSkJqakFimk5iXnp2TmpdsqhYa46VooKeQl5qbaKkXo+oYE KSmUJeaUAnlGBmjAwTnAPVhJ3y7BLeN+1wnGgknSFVu7jzM3MC4R62Lk5JAQMJG4OusuO4Qt JnHh3nq2LkYuDiGBpYwS/fvOs0A4DxglLi2bB1YlLOAlsWjmM6YuRg4OEQFriW2nlSBqzjBK 3GlawwTiMAucYpS43b+RDaSBTUBHYvu340wgNq+AncTWG49ZQWwWAVWJLUcXMIIMEhUIk3je 6ARRIijxY/I9FhCbU8BeYnbzTzaQEmYBPYn7F7VAwswC8hKb17xlnsAoMAtJxyyEqllIqhYw Mq9ilEgtSC4oTkrPNcxLLdcrTswtLs1L10vOz93ECI69Z1I7GA/ucj/EKMDBqMTDKyGTEiHE mlhWXJl7iFGCg1lJhHfDVqAQb0piZVVqUX58UWlOavEhRlOgLyYyS4km5wPTQl5JvKGJuYm5 sYGFuaWliZGSOG/j7GfhQgLpiSWp2ampBalFMH1MHJxSwCgo26w/rf7yN+uD63NSXxa3tD+X 2N++z+BhlEyDs/LH1GbnP7/mqfa+ffXTxb1bN4vzwIsPrbniZ/n5Hh2dtDX2qfaqoKRFG75c 9n0/4YTaeU63GQx1i6Id1hjrR186n89hZc936/wM14CMzzNmblqkXnJju8kiPtW86nW6781r eSI0/pVN3arEUpyRaKjFXFScCACxhKvO0wIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161229071353epcas1p3d189daca51db9474c6f07232629858eb X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?7KCV7J6s7ZuIG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?SmFlaG9vbiBDaHVuZxtUaXplbiBQbGF0Zm9ybSBMYWIuG1Nh?= =?UTF-8?B?bXN1bmcgRWxlY3Ryb25pY3MbUzUvU2VuaW9yIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20161228153516epcas2p253c6bc0371ab0df464573b63218795ef X-RootMTR: 20161228153516epcas2p253c6bc0371ab0df464573b63218795ef References: <1482939288-14950-1-git-send-email-ayaka@soulik.info> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/29/2016 12:02 PM, Jaehoon Chung wrote: > Hi Randy, > > On 12/29/2016 12:34 AM, Randy Li wrote: >> This reverts commit f90142683f04bcb0729bf0df67a5e29562b725b9. >> It is reported that making RK3288 can't boot from eMMC/MMC. > > Could you explain in more detail? > As you mentioned, this patch is making that RK3288 can't boot..then why? > Good way should be that finds the main reason and fixes it. > Not just revert. To Shawn, Could you check this? If you have rk3288.. If it's not working fine, it needs to revert this patch until finding the problem. Best Regards, Jaehoon Chung > > Best Regards, > Jaehoon Chung > >> >> Signed-off-by: Randy Li >> --- >> drivers/mmc/host/dw_mmc-rockchip.c | 41 +++----------------------------------- >> 1 file changed, 3 insertions(+), 38 deletions(-) >> >> diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c >> index 9a46e46..3189234 100644 >> --- a/drivers/mmc/host/dw_mmc-rockchip.c >> +++ b/drivers/mmc/host/dw_mmc-rockchip.c >> @@ -14,7 +14,6 @@ >> #include >> #include >> #include >> -#include >> #include >> >> #include "dw_mmc.h" >> @@ -327,7 +326,6 @@ static int dw_mci_rockchip_probe(struct platform_device *pdev) >> { >> const struct dw_mci_drv_data *drv_data; >> const struct of_device_id *match; >> - int ret; >> >> if (!pdev->dev.of_node) >> return -ENODEV; >> @@ -335,49 +333,16 @@ static int dw_mci_rockchip_probe(struct platform_device *pdev) >> match = of_match_node(dw_mci_rockchip_match, pdev->dev.of_node); >> drv_data = match->data; >> >> - pm_runtime_get_noresume(&pdev->dev); >> - pm_runtime_set_active(&pdev->dev); >> - pm_runtime_enable(&pdev->dev); >> - pm_runtime_set_autosuspend_delay(&pdev->dev, 50); >> - pm_runtime_use_autosuspend(&pdev->dev); >> - >> - ret = dw_mci_pltfm_register(pdev, drv_data); >> - if (ret) { >> - pm_runtime_disable(&pdev->dev); >> - pm_runtime_set_suspended(&pdev->dev); >> - pm_runtime_put_noidle(&pdev->dev); >> - return ret; >> - } >> - >> - pm_runtime_put_autosuspend(&pdev->dev); >> - >> - return 0; >> + return dw_mci_pltfm_register(pdev, drv_data); >> } >> >> -static int dw_mci_rockchip_remove(struct platform_device *pdev) >> -{ >> - pm_runtime_get_sync(&pdev->dev); >> - pm_runtime_disable(&pdev->dev); >> - pm_runtime_put_noidle(&pdev->dev); >> - >> - return dw_mci_pltfm_remove(pdev); >> -} >> - >> -static const struct dev_pm_ops dw_mci_rockchip_dev_pm_ops = { >> - SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, >> - pm_runtime_force_resume) >> - SET_RUNTIME_PM_OPS(dw_mci_runtime_suspend, >> - dw_mci_runtime_resume, >> - NULL) >> -}; >> - >> static struct platform_driver dw_mci_rockchip_pltfm_driver = { >> .probe = dw_mci_rockchip_probe, >> - .remove = dw_mci_rockchip_remove, >> + .remove = dw_mci_pltfm_remove, >> .driver = { >> .name = "dwmmc_rockchip", >> .of_match_table = dw_mci_rockchip_match, >> - .pm = &dw_mci_rockchip_dev_pm_ops, >> + .pm = &dw_mci_pltfm_pmops, >> }, >> }; >> >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > . >