From: Reinette Chatre <reinette.chatre@intel.com>
To: Bhaskar Chowdhury <unixbhaskar@gmail.com>,
fenghua.yu@intel.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, hpa@zytor.com,
linux-kernel@vger.kernel.org, gustavo@embeddedor.com
Cc: rdunlap@infradead.org
Subject: Re: [PATCH V4] arch: kernel: cpu: x86/resctrl: Takes a letter away and append a colon to match below struct member
Date: Wed, 13 Jan 2021 09:11:17 -0800 [thread overview]
Message-ID: <7e3a5c13-db5c-7399-2b80-f1284786ea77@intel.com> (raw)
In-Reply-To: <20210113020333.29803-1-unixbhaskar@gmail.com>
Hi Bhaskar,
The prefix in the subject line should be "x86/resctrl:" only. The
subject line could be (also taking liberty to shorten it here):
x86/resctrl: Fix typo and append a colon to match struct member
I would like to repeat my suggestion made in response to your previous
version, especially if you are planning cleanup in many areas of the
kernel: Use "git log" to take a look at the custom of patches in the
area you are contributing to. While the kernel may appear to be a single
code base there can be different customs in the various subsystems.
On 1/12/2021 6:03 PM, Bhaskar Chowdhury wrote:
> s/kernlfs/kernfs/
> s/@mon_data_kn/@mon_data_kn:/
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> Changes from V3: Fix the subject line typo stuc to struct and mention cpu architecture
> arch/x86/kernel/cpu/resctrl/internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index ee71c47844cb..ef9e2c0809b8 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -142,7 +142,7 @@ enum rdtgrp_mode {
>
> /**
> * struct mongroup - store mon group's data in resctrl fs.
> - * @mon_data_kn kernlfs node for the mon_data directory
> + * @mon_data_kn: kernfs node for the mon_data directory
> * @parent: parent rdtgrp
> * @crdtgrp_list: child rdtgroup node list
> * @rmid: rmid for this rdtgroup
> --
> 2.20.1
>
Reinette
next prev parent reply other threads:[~2021-01-13 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 2:03 [PATCH V4] arch: kernel: cpu: x86/resctrl: Takes a letter away and append a colon to match below struct member Bhaskar Chowdhury
[not found] ` <f20be5e1-a2a6-14d4-5813-1fb716783bb2@embeddedor.com>
2021-01-13 2:48 ` Bhaskar Chowdhury
2021-01-13 2:51 ` Randy Dunlap
2021-01-13 3:02 ` Bhaskar Chowdhury
[not found] ` <8aafe837-f4e9-1440-890b-f07d83eed30c@embeddedor.com>
2021-01-13 10:41 ` Bhaskar Chowdhury
2021-01-13 17:11 ` Reinette Chatre [this message]
2021-01-13 17:42 ` Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e3a5c13-db5c-7399-2b80-f1284786ea77@intel.com \
--to=reinette.chatre@intel.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=gustavo@embeddedor.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=unixbhaskar@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).