From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
vkoul@kernel.org, broonie@kernel.org
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
bgoswami@codeaurora.org, linux-kernel@vger.kernel.org,
plai@codeaurora.org, lgirdwood@gmail.com, robh+dt@kernel.org,
spapothi@codeaurora.org
Subject: Re: [PATCH v2 1/5] soundwire: Add compute_params callback
Date: Tue, 13 Aug 2019 09:34:37 -0500 [thread overview]
Message-ID: <7e462330-a357-698a-b259-5ff136963a57@linux.intel.com> (raw)
In-Reply-To: <20190813083550.5877-2-srinivas.kandagatla@linaro.org>
On 8/13/19 3:35 AM, Srinivas Kandagatla wrote:
> From: Vinod Koul <vkoul@kernel.org>
>
> This callback allows masters to compute the bus parameters required.
This looks like a partial use of the patch ('soundwire: Add Intel
resource management algorithm')? see comments below
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> drivers/soundwire/stream.c | 10 ++++++++++
> include/linux/soundwire/sdw.h | 2 ++
> 2 files changed, 12 insertions(+)
>
> diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c
> index a0476755a459..60bc2fe42928 100644
> --- a/drivers/soundwire/stream.c
> +++ b/drivers/soundwire/stream.c
> @@ -1483,6 +1483,16 @@ static int _sdw_prepare_stream(struct sdw_stream_runtime *stream)
> bus->params.bandwidth += m_rt->stream->params.rate *
> m_rt->ch_count * m_rt->stream->params.bps;
>
> + /* Compute params */
> + if (bus->compute_params) {
> + ret = bus->compute_params(bus);
> + if (ret < 0) {
> + dev_err(bus->dev, "Compute params failed: %d",
> + ret);
> + return ret;
> + }
> + }
> +
This would need to be duplicated for deprepare (as was done in the Intel
patch).
> /* Program params */
> ret = sdw_program_params(bus);
> if (ret < 0) {
> diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
> index bea46bd8b6ce..aac68e879fae 100644
> --- a/include/linux/soundwire/sdw.h
> +++ b/include/linux/soundwire/sdw.h
> @@ -718,6 +718,7 @@ struct sdw_master_ops {
> * Bit set implies used number, bit clear implies unused number.
> * @bus_lock: bus lock
> * @msg_lock: message lock
> + * @compute_params: points to Bus resource management implementation
> * @ops: Master callback ops
> * @port_ops: Master port callback ops
> * @params: Current bus parameters
> @@ -739,6 +740,7 @@ struct sdw_bus {
> DECLARE_BITMAP(assigned, SDW_MAX_DEVICES);
> struct mutex bus_lock;
> struct mutex msg_lock;
> + int (*compute_params)(struct sdw_bus *bus);
not sure I understand how it's set? We have a default in the Intel patch.
> const struct sdw_master_ops *ops;
> const struct sdw_master_port_ops *port_ops;
> struct sdw_bus_params params;
>
next prev parent reply other threads:[~2019-08-13 14:53 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 8:35 [PATCH v2 0/5] soundwire: Add support to Qualcomm SoundWire master Srinivas Kandagatla
2019-08-13 8:35 ` [PATCH v2 1/5] soundwire: Add compute_params callback Srinivas Kandagatla
2019-08-13 14:34 ` Pierre-Louis Bossart [this message]
2019-08-13 18:17 ` Srinivas Kandagatla
2019-08-13 19:08 ` Pierre-Louis Bossart
2019-08-14 4:05 ` Vinod Koul
2019-09-04 9:28 ` Vinod Koul
2019-09-04 13:36 ` [alsa-devel] " Pierre-Louis Bossart
2019-08-13 8:35 ` [PATCH v2 2/5] soundwire: stream: make stream name a const pointer Srinivas Kandagatla
2019-09-04 9:29 ` Vinod Koul
2019-08-13 8:35 ` [PATCH v2 3/5] ASoC: core: add support to snd_soc_dai_get_sdw_stream() Srinivas Kandagatla
2019-08-13 14:44 ` [alsa-devel] " Pierre-Louis Bossart
2019-08-13 16:50 ` Srinivas Kandagatla
2019-08-13 17:51 ` Pierre-Louis Bossart
2019-08-13 18:06 ` Srinivas Kandagatla
2019-08-13 19:15 ` Pierre-Louis Bossart
2019-08-13 19:18 ` Mark Brown
2019-08-13 19:38 ` Pierre-Louis Bossart
2019-08-13 19:58 ` Mark Brown
2019-08-14 4:11 ` Vinod Koul
2019-08-14 9:08 ` Mark Brown
2019-08-14 14:09 ` Pierre-Louis Bossart
2019-10-09 8:32 ` Srinivas Kandagatla
2019-10-09 14:29 ` Pierre-Louis Bossart
2019-10-09 16:01 ` Srinivas Kandagatla
2019-10-09 18:53 ` Pierre-Louis Bossart
2019-10-10 8:50 ` Srinivas Kandagatla
2019-10-10 12:03 ` Charles Keepax
2019-10-10 13:51 ` Mark Brown
2019-10-10 14:01 ` Pierre-Louis Bossart
2019-10-10 14:52 ` Srinivas Kandagatla
2019-10-10 15:49 ` Pierre-Louis Bossart
2019-10-11 12:30 ` Srinivas Kandagatla
2019-08-13 16:03 ` Cezary Rojewski
2019-08-13 16:52 ` Srinivas Kandagatla
2019-08-13 17:29 ` Cezary Rojewski
2019-08-13 19:19 ` Mark Brown
2019-08-13 8:35 ` [PATCH v2 4/5] dt-bindings: soundwire: add bindings for Qcom controller Srinivas Kandagatla
2019-08-23 7:28 ` Vinod Koul
2019-08-30 8:05 ` Srinivas Kandagatla
2019-08-13 8:35 ` [PATCH v2 5/5] soundwire: qcom: add support for SoundWire controller Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e462330-a357-698a-b259-5ff136963a57@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=spapothi@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).