From: Alexander Lobakin <alobakin@dlink.ru>
To: David Miller <davem@davemloft.net>
Cc: ecree@solarflare.com, jiri@mellanox.com, edumazet@google.com,
idosch@mellanox.com, pabeni@redhat.com, petrm@mellanox.com,
sd@queasysnail.net, f.fainelli@gmail.com,
jaswinder.singh@linaro.org, ilias.apalodimas@linaro.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive()
Date: Wed, 16 Oct 2019 10:31:31 +0300 [thread overview]
Message-ID: <7e68da00d7c129a8ce290229743beb3d@dlink.ru> (raw)
In-Reply-To: <20191015.181649.949805234862708186.davem@davemloft.net>
David Miller wrote 16.10.2019 04:16:
> From: Alexander Lobakin <alobakin@dlink.ru>
> Date: Mon, 14 Oct 2019 11:00:33 +0300
>
>> Commit 323ebb61e32b4 ("net: use listified RX for handling GRO_NORMAL
>> skbs") made use of listified skb processing for the users of
>> napi_gro_frags().
>> The same technique can be used in a way more common napi_gro_receive()
>> to speed up non-merged (GRO_NORMAL) skbs for a wide range of drivers
>> including gro_cells and mac80211 users.
>> This slightly changes the return value in cases where skb is being
>> dropped by the core stack, but it seems to have no impact on related
>> drivers' functionality.
>> gro_normal_batch is left untouched as it's very individual for every
>> single system configuration and might be tuned in manual order to
>> achieve an optimal performance.
>>
>> Signed-off-by: Alexander Lobakin <alobakin@dlink.ru>
>> Acked-by: Edward Cree <ecree@solarflare.com>
>
> Applied, thank you.
David, Edward, Eric, Ilias,
thank you for your time.
Regards,
ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ
next prev parent reply other threads:[~2019-10-16 7:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 8:00 [PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive() Alexander Lobakin
2019-10-16 1:16 ` David Miller
2019-10-16 7:31 ` Alexander Lobakin [this message]
2019-11-25 7:29 ` Nicholas Johnson
2019-11-25 7:54 ` Alexander Lobakin
2019-11-25 8:25 ` Alexander Lobakin
2019-11-25 9:09 ` Nicholas Johnson
2019-11-25 10:31 ` Edward Cree
2019-11-25 10:58 ` Alexander Lobakin
2019-11-25 11:05 ` Johannes Berg
2019-11-25 11:42 ` Paolo Abeni
2019-11-25 12:02 ` Alexander Lobakin
2019-11-25 13:21 ` Edward Cree
2019-11-25 13:39 ` Alexander Lobakin
2019-11-26 23:57 ` David Miller
2019-11-27 7:47 ` Alexander Lobakin
2019-11-27 8:30 ` Johannes Berg
2019-11-27 9:47 ` Alexander Lobakin
2019-11-25 12:11 ` Kalle Valo
2019-11-25 13:07 ` Nicholas Johnson
2019-11-25 13:11 ` Nicholas Johnson
2020-06-24 21:06 ` Jason A. Donenfeld
2020-06-24 21:28 ` Jason A. Donenfeld
2020-06-25 14:25 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e68da00d7c129a8ce290229743beb3d@dlink.ru \
--to=alobakin@dlink.ru \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jaswinder.singh@linaro.org \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@mellanox.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).