From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030220AbcIVRnX (ORCPT ); Thu, 22 Sep 2016 13:43:23 -0400 Received: from mout.web.de ([212.227.15.4]:61248 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S940135AbcIVRnM (ORCPT ); Thu, 22 Sep 2016 13:43:12 -0400 Subject: [PATCH 11/14] GPU-DRM-TTM: Return an error code only as a constant in ttm_dma_pool_init() To: dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Emil Velikov References: <566ABCD9.1060404@users.sourceforge.net> <4d34446f-05ad-c3ce-5d33-8fb4f25af25c@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <7e8a9893-8f1f-189a-4f19-d105c9502747@users.sourceforge.net> Date: Thu, 22 Sep 2016 19:43:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <4d34446f-05ad-c3ce-5d33-8fb4f25af25c@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:cDYx0c7wgBjl8q0yZPbsoYPetfGKR+zKnClTHuEC+AULJ0mZdY0 Z66dfvS8UuGieiDc5o8Aa0/g0IZjkmf3bsL+PcBlMZwOfD+Xxp1lXtQs2ji3CZRM1idVe6e qy8QEF3jasCmHOXrfVTcOLU/N30gURG5JzDKwbaK0CSol4Sy1lJdd7oySMliz3VaFXB1nkT qQBm4I2o/oncvoM1XZDKg== X-UI-Out-Filterresults: notjunk:1;V01:K0:x9r/1fGVuF8=:yO4Kdm52D/Y4QWC2BVX3kD /3I43bZXdGPmXRUNRRvfrM1Jc++GOReQNzvfmwfQMRgh69JmmHZ/Pluq63J0BvDQ6LrT3ZAJE vQrX30aHr32desug6coK1B9J86hkC/COjPT2J7X2PPInymyZLe1c+T5QMEt8crfYLVZnEFzD5 +lXqkWhwG2YyGfqIsDUuA6l2uQuh6w0iym5lzQhWdP2UmHx9rmtRgJc2BTIkLAey50QikBXzO BEfzT/Jbg1lzYpCwrhq1SjgC8Ue8dHuMV7IFpqKZXgWXWLOFxsWkoW7QI+qxRgnXijUWqZuOu ZNFZGn/THTGkB2SX9L4/qJE+WsvMV2iEvZkyaxrRYkpC5ENl93hOl8Gi+JL/IM3L/X3ofLp1Y BxvnRzBQyUqwWASZvMNTbNBnHbM+TeEYFK1OKS3pKo8FZCRfC/XITckV2fJlPIUOYLGaZvV6A XeRsSEdmcUk7X+lhFRExyHGi78+A+TpkatUUyhhIIP1uDFHvB5TlPPjU9tKb7ujjLR3sNbjjQ BUcbx6byRHZ2OTz9nUMBVq27/MBO1AkUBxC3LMSL3v/RQyyNTqnqOl1muaIjIsagvoGkOIX7f +IODNmTRW2bjtKqIE9i49LmYzsYSJJOytLvZG4VS+UWUM9PKmxWM3xLmT4B6bKOffZKRn03ya b79QjMDRv+oWv8DVPRCRiqNwZ5SgNYmDQVJBh+QVvSbU8jd31YCx10pdfHytRZKkipHX+AgNh TI301/h06mY2ij2ByyBxjQeenMSQwQCILurkaat4x++SQvvyMkMQZYe41Ydwo4ZI18eqRAli2 RhuITRq Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 22 Sep 2016 17:17:19 +0200 * Return an error code without storing it in a local variable. * Delete the local variable "ret" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c index c21f45f..d5f41ed 100644 --- a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c +++ b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c @@ -579,7 +579,6 @@ static struct dma_pool *ttm_dma_pool_init(struct device *dev, gfp_t flags, struct device_pools *sec_pool = NULL; struct dma_pool *pool = NULL, **ptr; unsigned i; - int ret = -ENODEV; char *p; if (!dev) @@ -589,8 +588,6 @@ static struct dma_pool *ttm_dma_pool_init(struct device *dev, gfp_t flags, if (!ptr) return NULL; - ret = -ENOMEM; - pool = kmalloc_node(sizeof(struct dma_pool), GFP_KERNEL, dev_to_node(dev)); if (!pool) @@ -644,7 +641,7 @@ err_mem: devres_free(ptr); kfree(sec_pool); kfree(pool); - return ERR_PTR(ret); + return ERR_PTR(-ENOMEM); } static struct dma_pool *ttm_dma_find_pool(struct device *dev, -- 2.10.0