From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEAD9C2D0E4 for ; Fri, 27 Nov 2020 07:31:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A5EC22201 for ; Fri, 27 Nov 2020 07:31:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405337AbgK0HbQ (ORCPT ); Fri, 27 Nov 2020 02:31:16 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:8417 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726408AbgK0HbQ (ORCPT ); Fri, 27 Nov 2020 02:31:16 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Cj5rq6ZfCz6wBk; Fri, 27 Nov 2020 15:30:51 +0800 (CST) Received: from [10.174.178.154] (10.174.178.154) by smtp.huawei.com (10.3.19.212) with Microsoft SMTP Server (TLS) id 14.3.487.0; Fri, 27 Nov 2020 15:31:11 +0800 Subject: Re: [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe To: Martin Blumenstingl CC: , , , Neil Armstrong , , , , References: <20201111095256.10477-1-zhengzengkai@huawei.com> From: Zheng Zengkai Message-ID: <7ea6de9c-f482-2f8e-1d54-b8c127d10f22@huawei.com> Date: Fri, 27 Nov 2020 15:31:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.154] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping... > On Wed, Nov 11, 2020 at 10:48 AM Zheng Zengkai wrote: >> dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare() >> on one error handling path. This patch fixes that. >> >> Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs") >> Reported-by: Hulk Robot >> Signed-off-by: Zheng Zengkai > Reviewed-by: Martin Blumenstingl > > many thanks for this fix! > > > Best regards > Martin > . >