From: Paolo Bonzini <pbonzini@redhat.com>
To: Wei Huang <whuang2@amd.com>, Wei Huang <wei.huang2@amd.com>,
kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, vkuznets@redhat.com,
seanjc@google.com, joro@8bytes.org, bp@alien8.de,
tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
jmattson@google.com, wanpengli@tencent.com, bsd@redhat.com,
dgilbert@redhat.com, mlevitsk@redhat.com
Subject: Re: [PATCH 1/2] KVM: x86: Add emulation support for #GP triggered by VM instructions
Date: Sun, 17 Jan 2021 19:20:29 +0100 [thread overview]
Message-ID: <7ea9f2d8-6688-612c-21a8-f3f3517da122@redhat.com> (raw)
In-Reply-To: <ed93c796-1750-7cb8-ed4d-dc9c4b68b5a3@amd.com>
On 15/01/21 08:00, Wei Huang wrote:
> If the whole body inside if-statement is moved out, do you expect the
> interface of x86_emulate_decoded_instruction to be something like:
>
> int x86_emulate_decoded_instruction(struct kvm_vcpu *vcpu,
> gpa_t cr2_or_gpa,
> int emulation_type, void *insn,
> int insn_len,
> bool write_fault_to_spt)
An idea is to making the body of the new function just
init_emulate_ctxt(vcpu);
/*
* We will reenter on the same instruction since
* we do not set complete_userspace_io. This does not
* handle watchpoints yet, those would be handled in
* the emulate_ops.
*/
if (!(emulation_type & EMULTYPE_SKIP) &&
kvm_vcpu_check_breakpoint(vcpu, &r))
return r;
ctxt->interruptibility = 0;
ctxt->have_exception = false;
ctxt->exception.vector = -1;
ctxt->exception.error_code_valid = false;
ctxt->perm_ok = false;
ctxt->ud = emulation_type & EMULTYPE_TRAP_UD;
r = x86_decode_insn(ctxt, insn, insn_len);
trace_kvm_emulate_insn_start(vcpu);
++vcpu->stat.insn_emulation;
return r;
because for the new caller, on EMULATION_FAILED you can just re-enter
the guest.
> And if so, what is the emulation type to use when calling this function
> from svm.c? EMULTYPE_VMWARE_GP?
Just 0 I think.
Paolo
next prev parent reply other threads:[~2021-01-17 18:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 6:37 [PATCH 1/2] KVM: x86: Add emulation support for #GP triggered by VM instructions Wei Huang
2021-01-12 6:37 ` [PATCH 2/2] KVM: SVM: Add support for VMCB address check change Wei Huang
2021-01-12 19:18 ` Sean Christopherson
2021-01-14 11:39 ` Maxim Levitsky
2021-01-14 12:04 ` Maxim Levitsky
2021-01-12 11:09 ` [PATCH 1/2] KVM: x86: Add emulation support for #GP triggered by VM instructions Maxim Levitsky
2021-01-12 21:05 ` Wei Huang
2021-01-12 12:15 ` Vitaly Kuznetsov
2021-01-12 15:11 ` Andy Lutomirski
2021-01-12 15:17 ` Maxim Levitsky
2021-01-12 15:22 ` Andy Lutomirski
2021-01-12 15:46 ` Bandan Das
2021-01-12 15:51 ` Andy Lutomirski
2021-01-12 17:56 ` Sean Christopherson
2021-01-13 4:55 ` Wei Huang
2021-01-12 21:50 ` Wei Huang
2021-01-12 14:01 ` Paolo Bonzini
2021-01-12 17:42 ` Sean Christopherson
2021-01-13 12:35 ` Paolo Bonzini
2021-01-15 7:00 ` Wei Huang
2021-01-17 18:20 ` Paolo Bonzini [this message]
2021-01-12 17:36 ` Sean Christopherson
2021-01-12 17:59 ` Sean Christopherson
2021-01-12 18:58 ` Andy Lutomirski
2021-01-13 5:15 ` Wei Huang
2021-01-14 11:42 ` Maxim Levitsky
2021-01-13 5:03 ` Wei Huang
2021-01-13 12:40 ` Paolo Bonzini
2021-01-12 19:40 ` Sean Christopherson
2021-01-12 20:00 ` Bandan Das
2021-01-14 11:47 ` Maxim Levitsky
2021-01-14 17:19 ` Sean Christopherson
2021-01-14 11:55 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ea9f2d8-6688-612c-21a8-f3f3517da122@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=bsd@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=wei.huang2@amd.com \
--cc=whuang2@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).