From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECCFBC43381 for ; Wed, 13 Feb 2019 21:29:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BDBA3206C0 for ; Wed, 13 Feb 2019 21:29:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="lU62r32D" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394789AbfBMV3H (ORCPT ); Wed, 13 Feb 2019 16:29:07 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:46536 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728044AbfBMV3H (ORCPT ); Wed, 13 Feb 2019 16:29:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=I/o3tPMzpkPplOb6zqNmrMpQV7vp1Z+HMPCPtEF4XWc=; b=lU62r32DpcDkeXGsLEaedxWIG jOx7Ofq90uGNFghK21JUfuYwHNtmqzONpIVDu8i3nnc5GLCi5EvUBKoyfw2jGW7YHTrxEN0cS6MIE i38+ppfIUd8066U6Ky0ALT/whcWaPkjo5PH8xstwq5P7yUze7IKL1tdZK9xmCm+mVEd3jYJ6agioK 721EHpMof1Uq+ndoQayiJkrpUqV7BO8eDxp7zwvv1wMhda9s1xi8nyQ/Sa1humWG1Kcm2Brl3swvC hjvStpV9/QrDI0bTAc8GpDATQk85kKyX36UKn3A5WLlYSsMYQ1uoDe2nLzfVetkuC2841pBLQqa9P LBrEmKZMw==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=midway.dunlab) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gu25a-0008AU-K1; Wed, 13 Feb 2019 21:29:06 +0000 Subject: Re: linux-next: Tree for Feb 12 (chrome/wilco_ec/) To: Nick Crews Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , Duncan Laurie References: <20190212175059.1ea4c16c@canb.auug.org.au> <94edf49b-6b37-2dac-a2db-ad454b105fd1@infradead.org> <6913db72-85b3-0b7d-5e38-9cbb6ec4c8c2@infradead.org> From: Randy Dunlap Message-ID: <7ec90d13-844d-5fe7-3ae3-d65152ebf37e@infradead.org> Date: Wed, 13 Feb 2019 13:29:06 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/13/19 9:26 AM, Nick Crews wrote: > Randy, > > No, I didn't test it, I'm sorry, of course I should done that. > Sorry for the formatting too, I'm new to this and wasn't sure what > tool to use. The following version of the patch was made with > "git format-patch" and now I'm replying in plaintext, it hopefully is better. > Hi Nick, A few small comments: > From 0cfb3db970636983c1570827b7793e31e352716e Mon Sep 17 00:00:00 2001 > From: Nick Crews > Date: Tue, 12 Feb 2019 16:46:15 -0700 > Subject: [PATCH] FROMLIST: wilco_ec: Fix Kconfig dependencies delete FROMLIST: The Subject should include a subsystem reference, e.g.: [PATCH] chrome: fix wilco_ex Kconfig dependencies > > In the initial version of the Wilco EC Driver, the > dependency order was wrong. It before was possible to > select CONFIG_WILCO_EC and CONFIG_CROS_EC_LPC without > having CONFIG_CROS_EC_LPC_MEC. This was wrong, since > WILCO_EC depends upon CONFIG CROS_EC_LPC_MEC, not the > other way around. > More importantly, the patch is still whitespace-damaged. The Kconfig file lines that begin with "bool", "depends", "help", etc. should contain a tab. Maybe your email client mangled the whitespace. You might need to take a look at Documentation/process/email-clients.rst for some hints. Or if you email the patch with "git send-email", it might be fine. Aside from that, after I fixed the whitespace, the kernel build does work without errors. Thanks. > --- > drivers/platform/chrome/Kconfig | 2 +- > drivers/platform/chrome/wilco_ec/Kconfig | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig > index 462eb9dfa4f2..b69561050868 100644 > --- a/drivers/platform/chrome/Kconfig > +++ b/drivers/platform/chrome/Kconfig > @@ -95,7 +95,7 @@ config CROS_EC_LPC > > config CROS_EC_LPC_MEC > bool "ChromeOS Embedded Controller LPC Microchip EC (MEC) variant" > - depends on CROS_EC_LPC || WILCO_EC > + depends on CROS_EC_LPC > default n > help > If you say Y here, a variant LPC protocol for the Microchip EC > diff --git a/drivers/platform/chrome/wilco_ec/Kconfig > b/drivers/platform/chrome/wilco_ec/Kconfig > index d8e2cddb4712..de097690fce3 100644 > --- a/drivers/platform/chrome/wilco_ec/Kconfig > +++ b/drivers/platform/chrome/wilco_ec/Kconfig > @@ -1,7 +1,6 @@ > config WILCO_EC > tristate "ChromeOS Wilco Embedded Controller" > - depends on ACPI && X86 > - select CROS_EC_LPC_MEC > + depends on ACPI && X86 && CROS_EC_LPC_MEC > help > If you say Y here, you get support for talking to the ChromeOS > Wilco EC over an eSPI bus. This uses a simple byte-level protocol > -- > 2.20.1 > > > On Tue, Feb 12, 2019 at 5:13 PM Randy Dunlap wrote: >> >> On 2/12/19 3:49 PM, Nick Crews wrote: >>> OK, here is the patch to fix this problem. We had the dependency backwards. >>> >>> Should I re-send out the entire patch series to the LKML with this fix in it? >>> >>> >>> diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig >>> index 462eb9dfa4f2..b69561050868 100644 >>> --- a/drivers/platform/chrome/Kconfig >>> +++ b/drivers/platform/chrome/Kconfig >>> @@ -95,7 +95,7 @@ config CROS_EC_LPC >>> >>> config CROS_EC_LPC_MEC >>> bool "ChromeOS Embedded Controller LPC Microchip EC (MEC) variant" >>> - depends on CROS_EC_LPC || WILCO_EC >>> + depends on CROS_EC_LPC >>> default n >>> help >>> If you say Y here, a variant LPC protocol for the Microchip EC >>> diff --git a/drivers/platform/chrome/wilco_ec/Kconfig b/drivers/platform/chrome/wilco_ec/Kconfig >>> index d8e2cddb4712..6ea2d3f64ce5 100644 >>> --- a/drivers/platform/chrome/wilco_ec/Kconfig >>> +++ b/drivers/platform/chrome/wilco_ec/Kconfig >>> @@ -1,6 +1,6 @@ >>> config WILCO_EC >>> tristate "ChromeOS Wilco Embedded Controller" >>> - depends on ACPI && X86 >>> + depends on ACPI && X86 && CROS_EC_LPC_MEC >>> select CROS_EC_LPC_MEC >>> help >>> If you say Y here, you get support for talking to the ChromeOS >>> >>> >> >> Nick, >> >> Did you test this? >> >> When I apply the patch (by hand, since it was whitespace-mangled/damaged), >> I get this: >> >> rdunlap@midway:linux-next-20190212> make ARCH=x86_64 O=X64 oldconfig >> make[1]: Entering directory '/home/rdunlap/lnx/next/linux-next-20190212/X64' >> GEN Makefile >> scripts/kconfig/conf --oldconfig Kconfig >> drivers/platform/chrome/Kconfig:84:error: recursive dependency detected! >> drivers/platform/chrome/Kconfig:84: symbol CROS_EC_LPC_MEC is selected by WILCO_EC >> drivers/platform/chrome/wilco_ec/Kconfig:1: symbol WILCO_EC depends on CROS_EC_LPC_MEC >> For a resolution refer to Documentation/kbuild/kconfig-language.txt >> subsection "Kconfig recursive dependency limitations" >> >> >> >> >> -- >> ~Randy -- ~Randy