From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756233AbcIRQva (ORCPT ); Sun, 18 Sep 2016 12:51:30 -0400 Received: from mout.web.de ([217.72.192.78]:56517 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932354AbcIRQvX (ORCPT ); Sun, 18 Sep 2016 12:51:23 -0400 Subject: [PATCH 2/5] drm/amdgpu: Improve determination of sizes in two functions To: dri-devel@lists.freedesktop.org, Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , Chunming Zhou , David Airlie , Monk Liu , Tom St Denis References: <566ABCD9.1060404@users.sourceforge.net> <8d614254-1cba-0379-cf84-52ad9bd9f3a7@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <7ed4253b-6945-ddc4-aa06-56f2efa35cf1@users.sourceforge.net> Date: Sun, 18 Sep 2016 18:51:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <8d614254-1cba-0379-cf84-52ad9bd9f3a7@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:eGgZZdSPs4anNCG4mL7KBF5WcF0CzLUb6s0QqUtvIES1XQRk7Pq PL/DxCVALpSN+s9OvTB+efz37fjutCiHhwXQ9rUwQ/KlZeNmiW6bvM1MpLH5QpwzeHSj8B/ 3474JJNruoBlduwN5FDl1OPN32sIZR78HZ/cGQzMZbac6zycr7ZDg9Sc9LF9p2Y3oMp7dCg KSTdzIsKP8VvSX/6V7GjQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:DQwyduoSrXM=:y3g2t70idhsKNa9p7omZiy XZhcqq9JYm8GEEaOVccGAOkcTlmZ55kG3vizTPnD5pReacfrofEO5N9Ucvils5tIzQ4e+ZZwD RKFm42SG8pabNDC78iBnTKfNdX6qzX6WloZSOixmXSV0XTMN3Rw8xXi0T1i/Enr/sFwsftTjj wfbbLdHpbtAryBM0x7Up/6xiuG78m4x0VVqV25F+SYUDQm5LP+JZcoHFVFOqSaR93AqCVrmy8 yPWW6wt5X0noKzZJfc1mWgmUiAHvtaasLjbbU4gmR+Xar4gE+zGRD0ZtAyde42ZDW0UNQHBdT SR4x5wFaoHJv5TxAhCyaSAFPu7ULtCoYuGhhWyraFTvrrn/g++GCSSxjcVvWiqYmITyFSpOEQ W3ckZdZA7cIdptSBZ/hA3nE0zbf5LUd7JTmX4qqDBT9PxBUQi4gEOgKJC7fSp8Fen02RPxlQM TKUUNONUfZT42ZFCauMZj+cHcEnt/m4YbZ4XIfNT5irO+TP+hjTLd4fTh7n9eBoKWNp48FbqN r5/TB1Wkot+n8WD5TT5km63khJ2SEJHZPKpvFF/YWgV5BYkv75g8oDjaJrYXmqTsbZLJbPuEL fI2wMbl7F13cHYLqiF461eHNV/pxGSPKvAzTxtoaMeXaJ+cEFQU5TzQWBgB4W1GI4R66LfVuM Ga+zButH5iKYse1HlN5XsztYkk/LaVawfiLTxAOw29tvME9jM70NQtSQEn7+9QaWOF+IycLed DHYmiR9O3RtS8XlH9QVXVllyL2HZmugoxflFgLb0M8g+7MpWRzNw7SMG3e3bD2SRrCdaS31OJ ocVnY4M Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 18 Sep 2016 17:24:47 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 2709ebd..96a2457 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -855,7 +855,7 @@ static void amdgpu_atombios_fini(struct amdgpu_device *adev) static int amdgpu_atombios_init(struct amdgpu_device *adev) { struct card_info *atom_card_info = - kzalloc(sizeof(struct card_info), GFP_KERNEL); + kzalloc(sizeof(*atom_card_info), GFP_KERNEL); if (!atom_card_info) return -ENOMEM; @@ -1224,7 +1224,8 @@ static int amdgpu_early_init(struct amdgpu_device *adev) } adev->ip_block_status = kcalloc(adev->num_ip_blocks, - sizeof(struct amdgpu_ip_block_status), GFP_KERNEL); + sizeof(*adev->ip_block_status), + GFP_KERNEL); if (adev->ip_block_status == NULL) return -ENOMEM; -- 2.10.0