From: Guenter Roeck <linux@roeck-us.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] watchdog: retu: restore MFD dependency
Date: Wed, 1 Mar 2017 06:13:55 -0800 [thread overview]
Message-ID: <7ed56c44-eac1-b830-a21a-43b097f2cb5d@roeck-us.net> (raw)
In-Reply-To: <20170301091531.522161-4-arnd@arndb.de>
On 03/01/2017 01:15 AM, Arnd Bergmann wrote:
> The retu watchdog calls into the respective mfd driver, but fails to
> link if that is diabled:
>
> drivers/watchdog/built-in.o: In function `retu_wdt_set_timeout':
> ziirave_wdt.c:(.text+0x8c88): undefined reference to `retu_write'
> ziirave_wdt.c:(.text+0x8c88): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `retu_write'
> drivers/watchdog/built-in.o: In function `retu_wdt_start':
> ziirave_wdt.c:(.text+0x8cc8): undefined reference to `retu_write'
> ziirave_wdt.c:(.text+0x8cc8): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `retu_write'
>
> This restores the dependency as it was before
>
> Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index a199e8536ce4..52a70ee6014f 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -586,7 +586,7 @@ config UX500_WATCHDOG
>
> config RETU_WATCHDOG
> tristate "Retu watchdog"
> - depends on MFD_RETU || COMPILE_TEST
> + depends on MFD_RETU
> select WATCHDOG_CORE
> help
> Retu watchdog driver for Nokia Internet Tablets (770, N800,
>
prev parent reply other threads:[~2017-03-01 14:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 9:15 [PATCH 0/3] remaining watchdog dependency fixes Arnd Bergmann
2017-03-01 9:15 ` [PATCH 1/3] watchdog: kempld: fix gcc-4.3 build Arnd Bergmann
2017-03-01 14:13 ` Guenter Roeck
2017-03-01 9:15 ` [PATCH 2/3] watchdog: db8500: add back prmcu dependency Arnd Bergmann
2017-03-01 14:13 ` Guenter Roeck
2017-03-01 9:15 ` [PATCH 3/3] watchdog: retu: restore MFD dependency Arnd Bergmann
2017-03-01 14:13 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ed56c44-eac1-b830-a21a-43b097f2cb5d@roeck-us.net \
--to=linux@roeck-us.net \
--cc=arnd@arndb.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).