linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/2] dt-bindings: arm: qcom: Document additional sa8540p device
@ 2022-07-21 15:44 Parikshit Pareek
  2022-07-21 16:27 ` Krzysztof Kozlowski
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Parikshit Pareek @ 2022-07-21 15:44 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski
  Cc: linux-arm-msm, devicetree, linux-kernel, Parikshit Pareek

Add the ADP ride device to the valid device compatibles found on the
sa8540p platform.

Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index c566276856ad..5729ce19eb16 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -650,6 +650,7 @@ properties:
       - items:
           - enum:
               - qcom,sa8295p-adp
+              - qcom,sa8540p-adp-ride
           - const: qcom,sa8540p
 
       - items:
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] dt-bindings: arm: qcom: Document additional sa8540p device
  2022-07-21 15:44 [PATCH 2/2] dt-bindings: arm: qcom: Document additional sa8540p device Parikshit Pareek
@ 2022-07-21 16:27 ` Krzysztof Kozlowski
  2022-07-21 16:31 ` Krzysztof Kozlowski
  2022-07-21 18:42 ` Konrad Dybcio
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-21 16:27 UTC (permalink / raw)
  To: Parikshit Pareek, Andy Gross, Bjorn Andersson, Konrad Dybcio,
	Rob Herring, Krzysztof Kozlowski
  Cc: linux-arm-msm, devicetree, linux-kernel

On 21/07/2022 17:44, Parikshit Pareek wrote:
> Add the ADP ride device to the valid device compatibles found on the
> sa8540p platform.
> 
> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] dt-bindings: arm: qcom: Document additional sa8540p device
  2022-07-21 15:44 [PATCH 2/2] dt-bindings: arm: qcom: Document additional sa8540p device Parikshit Pareek
  2022-07-21 16:27 ` Krzysztof Kozlowski
@ 2022-07-21 16:31 ` Krzysztof Kozlowski
  2022-07-21 18:42 ` Konrad Dybcio
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-21 16:31 UTC (permalink / raw)
  To: Parikshit Pareek, Andy Gross, Bjorn Andersson, Konrad Dybcio,
	Rob Herring, Krzysztof Kozlowski
  Cc: linux-arm-msm, devicetree, linux-kernel

On 21/07/2022 17:44, Parikshit Pareek wrote:
> Add the ADP ride device to the valid device compatibles found on the
> sa8540p platform.
> 
> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>

Bindings are always first commit, otherwise your patchset is not bisectable.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] dt-bindings: arm: qcom: Document additional sa8540p device
  2022-07-21 15:44 [PATCH 2/2] dt-bindings: arm: qcom: Document additional sa8540p device Parikshit Pareek
  2022-07-21 16:27 ` Krzysztof Kozlowski
  2022-07-21 16:31 ` Krzysztof Kozlowski
@ 2022-07-21 18:42 ` Konrad Dybcio
  2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2022-07-21 18:42 UTC (permalink / raw)
  To: Parikshit Pareek, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski
  Cc: linux-arm-msm, devicetree, linux-kernel



On 21.07.2022 17:44, Parikshit Pareek wrote:
> Add the ADP ride device to the valid device compatibles found on the
> sa8540p platform.
> 
> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
> ---
The bindings patch should come before the one that introduces code
that's being documented.

Konrad
>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index c566276856ad..5729ce19eb16 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -650,6 +650,7 @@ properties:
>        - items:
>            - enum:
>                - qcom,sa8295p-adp
> +              - qcom,sa8540p-adp-ride
>            - const: qcom,sa8540p
>  
>        - items:

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-07-21 18:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-21 15:44 [PATCH 2/2] dt-bindings: arm: qcom: Document additional sa8540p device Parikshit Pareek
2022-07-21 16:27 ` Krzysztof Kozlowski
2022-07-21 16:31 ` Krzysztof Kozlowski
2022-07-21 18:42 ` Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).