From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751517AbeCOG6i (ORCPT ); Thu, 15 Mar 2018 02:58:38 -0400 Received: from mailproxy01.manitu.net ([217.11.48.65]:51014 "EHLO mailproxy01.manitu.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731AbeCOG6h (ORCPT ); Thu, 15 Mar 2018 02:58:37 -0400 Subject: Re: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices To: Jakob Unterwurzacher Cc: Martin Elshuber , Philipp Tomsich , Marc Kleine-Budde , linux-can@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180313173520.21257-1-jakob.unterwurzacher@theobroma-systems.com> <20180313173520.21257-2-jakob.unterwurzacher@theobroma-systems.com> <03024ab7-5386-3bcf-76f2-ef2e0e9e7a78@theobroma-systems.com> <68564c40-396b-9081-8534-67fe96a6fb3f@grandegger.com> <92e559b1-d392-015e-1aa1-0497cbd4c071@grandegger.com> <5b3df9d5-3e65-1114-4b51-9dcc329cbc31@theobroma-systems.com> <1bd41545-facb-9314-005b-4e742c4c61da@theobroma-systems.com> From: Wolfgang Grandegger Message-ID: <7f0bd797-64d4-ae96-00ae-5e11cf74d28e@grandegger.com> Date: Thu, 15 Mar 2018 07:58:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1bd41545-facb-9314-005b-4e742c4c61da@theobroma-systems.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 14.03.2018 um 20:07 schrieb Jakob Unterwurzacher: > On 14.03.18 11:04, Wolfgang Grandegger wrote: >>>>  (000.000443)  can0  20000034   [8]  00 0C 00 00 00 00 78 00 >>>> ERRORFRAME >>>>     controller-problem{rx-error-warning,tx-error-warning} >>>>     transceiver-status >>>>     no-acknowledgement-on-tx >>>>     error-counter-tx-rx{{120}{0}} >>>>  (000.000444)  can0  20000034   [8]  00 3C 00 00 00 00 80 00 >>>> ERRORFRAME >>>> >>>> controller-problem{rx-error-warning,tx-error-warning,rx-error-passive,tx-error-passive} >> >> >> Just, >> >>        controller-problem{rx-error-passive,tx-error-passive} [...] >> >> Back to error active is missing!? > > That was indeed missing. We have fixed the missing back-to-error-active > in our firmware. > > Also, we no longer send the controller status in every error frame, but > only on state changes (see below) which seems to be how other drivers > are handling things. Good, it would also be useful, if berr-reporting could be enabled by the firmware. This avoids a lot of traffic and load, especially if no cable is connected. Wolfgang.