From: Randy Dunlap <rdunlap@infradead.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] mfd: sl28cpld: Depend on I2C
Date: Fri, 2 Oct 2020 09:18:29 -0700 [thread overview]
Message-ID: <7f31606f-c2fa-6c49-4f8f-197010f6a759@infradead.org> (raw)
In-Reply-To: <20201002083500.796843-1-lee.jones@linaro.org>
On 10/2/20 1:35 AM, Lee Jones wrote:
> Fixes the following randconfig build error:
>
> ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe':
> simple-mfd-i2c.c:(.text+0x48): undefined reference to `__devm_regmap_init_i2c'
> ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_driver_init':
> simple-mfd-i2c.c:(.init.text+0x14): undefined reference to `i2c_register_driver'
> ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_driver_exit':
> simple-mfd-i2c.c:(.exit.text+0xd): undefined reference to `i2c_del_driver'
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index bdf8cb962027b..8b99a13669bfc 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1188,6 +1188,7 @@ config MFD_SIMPLE_MFD_I2C
>
> config MFD_SL28CPLD
> tristate "Kontron sl28cpld Board Management Controller"
> + depends on I2C
> select MFD_SIMPLE_MFD_I2C
> help
> Say yes here to enable support for the Kontron sl28cpld board
>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
thanks.
--
~Randy
prev parent reply other threads:[~2020-10-02 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 8:35 [PATCH 1/1] mfd: sl28cpld: Depend on I2C Lee Jones
2020-10-02 16:18 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f31606f-c2fa-6c49-4f8f-197010f6a759@infradead.org \
--to=rdunlap@infradead.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).