* [PATCH 1/3] hv_ballon: Avoid calling dummy function __online_page_set_limits()
2019-09-07 21:47 [PATCH 0/3] Remove __online_page_set_limits() Souptick Joarder
@ 2019-09-07 21:47 ` Souptick Joarder
2019-09-09 7:54 ` David Hildenbrand
2019-09-07 21:47 ` [PATCH 2/3] xen/ballon: " Souptick Joarder
` (3 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: Souptick Joarder @ 2019-09-07 21:47 UTC (permalink / raw)
To: kys, haiyangz, sthemmin, sashal, boris.ostrovsky, jgross,
sstabellini, akpm, david, osalvador, mhocko, pasha.tatashin,
dan.j.williams, richard.weiyang, cai
Cc: linux-hyperv, xen-devel, linux-mm, linux-kernel, Souptick Joarder
__online_page_set_limits() is a dummy function and an extra call
to this function can be avoided.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
drivers/hv/hv_balloon.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
index 6fb4ea5..9bab443 100644
--- a/drivers/hv/hv_balloon.c
+++ b/drivers/hv/hv_balloon.c
@@ -680,7 +680,6 @@ static void hv_page_online_one(struct hv_hotadd_state *has, struct page *pg)
__ClearPageOffline(pg);
/* This frame is currently backed; online the page. */
- __online_page_set_limits(pg);
__online_page_increment_counters(pg);
__online_page_free(pg);
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 1/3] hv_ballon: Avoid calling dummy function __online_page_set_limits()
2019-09-07 21:47 ` [PATCH 1/3] hv_ballon: Avoid calling dummy function __online_page_set_limits() Souptick Joarder
@ 2019-09-09 7:54 ` David Hildenbrand
0 siblings, 0 replies; 12+ messages in thread
From: David Hildenbrand @ 2019-09-09 7:54 UTC (permalink / raw)
To: Souptick Joarder, kys, haiyangz, sthemmin, sashal,
boris.ostrovsky, jgross, sstabellini, akpm, osalvador, mhocko,
pasha.tatashin, dan.j.williams, richard.weiyang, cai
Cc: linux-hyperv, xen-devel, linux-mm, linux-kernel
On 07.09.19 23:47, Souptick Joarder wrote:
> __online_page_set_limits() is a dummy function and an extra call
> to this function can be avoided.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> drivers/hv/hv_balloon.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
> index 6fb4ea5..9bab443 100644
> --- a/drivers/hv/hv_balloon.c
> +++ b/drivers/hv/hv_balloon.c
> @@ -680,7 +680,6 @@ static void hv_page_online_one(struct hv_hotadd_state *has, struct page *pg)
> __ClearPageOffline(pg);
>
> /* This frame is currently backed; online the page. */
> - __online_page_set_limits(pg);
> __online_page_increment_counters(pg);
> __online_page_free(pg);
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/3] xen/ballon: Avoid calling dummy function __online_page_set_limits()
2019-09-07 21:47 [PATCH 0/3] Remove __online_page_set_limits() Souptick Joarder
2019-09-07 21:47 ` [PATCH 1/3] hv_ballon: Avoid calling dummy function __online_page_set_limits() Souptick Joarder
@ 2019-09-07 21:47 ` Souptick Joarder
2019-09-08 5:09 ` Juergen Gross
2019-09-09 7:54 ` David Hildenbrand
2019-09-07 21:47 ` [PATCH 3/3] mm/memory_hotplug.c: Remove __online_page_set_limits() Souptick Joarder
` (2 subsequent siblings)
4 siblings, 2 replies; 12+ messages in thread
From: Souptick Joarder @ 2019-09-07 21:47 UTC (permalink / raw)
To: kys, haiyangz, sthemmin, sashal, boris.ostrovsky, jgross,
sstabellini, akpm, david, osalvador, mhocko, pasha.tatashin,
dan.j.williams, richard.weiyang, cai
Cc: linux-hyperv, xen-devel, linux-mm, linux-kernel, Souptick Joarder
__online_page_set_limits() is a dummy function and an extra call
to this function can be avoided.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
drivers/xen/balloon.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 4e11de6..05b1f7e 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -376,7 +376,6 @@ static void xen_online_page(struct page *page, unsigned int order)
mutex_lock(&balloon_mutex);
for (i = 0; i < size; i++) {
p = pfn_to_page(start_pfn + i);
- __online_page_set_limits(p);
__SetPageOffline(p);
__balloon_append(p);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 2/3] xen/ballon: Avoid calling dummy function __online_page_set_limits()
2019-09-07 21:47 ` [PATCH 2/3] xen/ballon: " Souptick Joarder
@ 2019-09-08 5:09 ` Juergen Gross
2019-09-09 7:54 ` David Hildenbrand
1 sibling, 0 replies; 12+ messages in thread
From: Juergen Gross @ 2019-09-08 5:09 UTC (permalink / raw)
To: Souptick Joarder, richard.weiyang, dan.j.williams, sashal,
sstabellini, cai, akpm, haiyangz, kys, sthemmin, boris.ostrovsky,
david, pasha.tatashin, Michal Hocko, Oscar Salvador
Cc: linux-mm, xen-devel, linux-hyperv, linux-kernel
On 07.09.19 23:47, Souptick Joarder wrote:
> __online_page_set_limits() is a dummy function and an extra call
> to this function can be avoided.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/3] xen/ballon: Avoid calling dummy function __online_page_set_limits()
2019-09-07 21:47 ` [PATCH 2/3] xen/ballon: " Souptick Joarder
2019-09-08 5:09 ` Juergen Gross
@ 2019-09-09 7:54 ` David Hildenbrand
1 sibling, 0 replies; 12+ messages in thread
From: David Hildenbrand @ 2019-09-09 7:54 UTC (permalink / raw)
To: Souptick Joarder, kys, haiyangz, sthemmin, sashal,
boris.ostrovsky, jgross, sstabellini, akpm, osalvador, mhocko,
pasha.tatashin, dan.j.williams, richard.weiyang, cai
Cc: linux-hyperv, xen-devel, linux-mm, linux-kernel
On 07.09.19 23:47, Souptick Joarder wrote:
> __online_page_set_limits() is a dummy function and an extra call
> to this function can be avoided.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> drivers/xen/balloon.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
> index 4e11de6..05b1f7e 100644
> --- a/drivers/xen/balloon.c
> +++ b/drivers/xen/balloon.c
> @@ -376,7 +376,6 @@ static void xen_online_page(struct page *page, unsigned int order)
> mutex_lock(&balloon_mutex);
> for (i = 0; i < size; i++) {
> p = pfn_to_page(start_pfn + i);
> - __online_page_set_limits(p);
> __SetPageOffline(p);
> __balloon_append(p);
> }
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 3/3] mm/memory_hotplug.c: Remove __online_page_set_limits()
2019-09-07 21:47 [PATCH 0/3] Remove __online_page_set_limits() Souptick Joarder
2019-09-07 21:47 ` [PATCH 1/3] hv_ballon: Avoid calling dummy function __online_page_set_limits() Souptick Joarder
2019-09-07 21:47 ` [PATCH 2/3] xen/ballon: " Souptick Joarder
@ 2019-09-07 21:47 ` Souptick Joarder
2019-09-09 7:54 ` David Hildenbrand
2019-09-09 8:12 ` [PATCH 0/3] " Michal Hocko
2019-09-09 15:42 ` Kirill A. Shutemov
4 siblings, 1 reply; 12+ messages in thread
From: Souptick Joarder @ 2019-09-07 21:47 UTC (permalink / raw)
To: kys, haiyangz, sthemmin, sashal, boris.ostrovsky, jgross,
sstabellini, akpm, david, osalvador, mhocko, pasha.tatashin,
dan.j.williams, richard.weiyang, cai
Cc: linux-hyperv, xen-devel, linux-mm, linux-kernel, Souptick Joarder
As both the callers of this dummy __online_page_set_limits()
is removed, this can be removed permanently.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
include/linux/memory_hotplug.h | 1 -
mm/memory_hotplug.c | 5 -----
2 files changed, 6 deletions(-)
diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h
index f46ea71..8ee3a2a 100644
--- a/include/linux/memory_hotplug.h
+++ b/include/linux/memory_hotplug.h
@@ -105,7 +105,6 @@ extern unsigned long __offline_isolated_pages(unsigned long start_pfn,
extern int set_online_page_callback(online_page_callback_t callback);
extern int restore_online_page_callback(online_page_callback_t callback);
-extern void __online_page_set_limits(struct page *page);
extern void __online_page_increment_counters(struct page *page);
extern void __online_page_free(struct page *page);
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index c73f099..dc0118f 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -604,11 +604,6 @@ int restore_online_page_callback(online_page_callback_t callback)
}
EXPORT_SYMBOL_GPL(restore_online_page_callback);
-void __online_page_set_limits(struct page *page)
-{
-}
-EXPORT_SYMBOL_GPL(__online_page_set_limits);
-
void __online_page_increment_counters(struct page *page)
{
adjust_managed_page_count(page, 1);
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 3/3] mm/memory_hotplug.c: Remove __online_page_set_limits()
2019-09-07 21:47 ` [PATCH 3/3] mm/memory_hotplug.c: Remove __online_page_set_limits() Souptick Joarder
@ 2019-09-09 7:54 ` David Hildenbrand
0 siblings, 0 replies; 12+ messages in thread
From: David Hildenbrand @ 2019-09-09 7:54 UTC (permalink / raw)
To: Souptick Joarder, kys, haiyangz, sthemmin, sashal,
boris.ostrovsky, jgross, sstabellini, akpm, osalvador, mhocko,
pasha.tatashin, dan.j.williams, richard.weiyang, cai
Cc: linux-hyperv, xen-devel, linux-mm, linux-kernel
On 07.09.19 23:47, Souptick Joarder wrote:
> As both the callers of this dummy __online_page_set_limits()
> is removed, this can be removed permanently.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> include/linux/memory_hotplug.h | 1 -
> mm/memory_hotplug.c | 5 -----
> 2 files changed, 6 deletions(-)
>
> diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h
> index f46ea71..8ee3a2a 100644
> --- a/include/linux/memory_hotplug.h
> +++ b/include/linux/memory_hotplug.h
> @@ -105,7 +105,6 @@ extern unsigned long __offline_isolated_pages(unsigned long start_pfn,
> extern int set_online_page_callback(online_page_callback_t callback);
> extern int restore_online_page_callback(online_page_callback_t callback);
>
> -extern void __online_page_set_limits(struct page *page);
> extern void __online_page_increment_counters(struct page *page);
> extern void __online_page_free(struct page *page);
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index c73f099..dc0118f 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -604,11 +604,6 @@ int restore_online_page_callback(online_page_callback_t callback)
> }
> EXPORT_SYMBOL_GPL(restore_online_page_callback);
>
> -void __online_page_set_limits(struct page *page)
> -{
> -}
> -EXPORT_SYMBOL_GPL(__online_page_set_limits);
> -
> void __online_page_increment_counters(struct page *page)
> {
> adjust_managed_page_count(page, 1);
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/3] Remove __online_page_set_limits()
2019-09-07 21:47 [PATCH 0/3] Remove __online_page_set_limits() Souptick Joarder
` (2 preceding siblings ...)
2019-09-07 21:47 ` [PATCH 3/3] mm/memory_hotplug.c: Remove __online_page_set_limits() Souptick Joarder
@ 2019-09-09 8:12 ` Michal Hocko
2019-09-09 15:42 ` Kirill A. Shutemov
4 siblings, 0 replies; 12+ messages in thread
From: Michal Hocko @ 2019-09-09 8:12 UTC (permalink / raw)
To: Souptick Joarder
Cc: kys, haiyangz, sthemmin, sashal, boris.ostrovsky, jgross,
sstabellini, akpm, david, osalvador, pasha.tatashin,
dan.j.williams, richard.weiyang, cai, linux-hyperv, xen-devel,
linux-mm, linux-kernel
On Sun 08-09-19 03:17:01, Souptick Joarder wrote:
> __online_page_set_limits() is a dummy function and an extra call
> to this can be avoided.
>
> As both of the callers are now removed, __online_page_set_limits()
> can be removed permanently.
>
> Souptick Joarder (3):
> hv_ballon: Avoid calling dummy function __online_page_set_limits()
> xen/ballon: Avoid calling dummy function __online_page_set_limits()
> mm/memory_hotplug.c: Remove __online_page_set_limits()
>
> drivers/hv/hv_balloon.c | 1 -
> drivers/xen/balloon.c | 1 -
> include/linux/memory_hotplug.h | 1 -
> mm/memory_hotplug.c | 5 -----
> 4 files changed, 8 deletions(-)
To the whole series
Acked-by: Michal Hocko <mhocko@suse.com>
Thanks!
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/3] Remove __online_page_set_limits()
2019-09-07 21:47 [PATCH 0/3] Remove __online_page_set_limits() Souptick Joarder
` (3 preceding siblings ...)
2019-09-09 8:12 ` [PATCH 0/3] " Michal Hocko
@ 2019-09-09 15:42 ` Kirill A. Shutemov
2019-09-10 12:56 ` Souptick Joarder
4 siblings, 1 reply; 12+ messages in thread
From: Kirill A. Shutemov @ 2019-09-09 15:42 UTC (permalink / raw)
To: Souptick Joarder
Cc: kys, haiyangz, sthemmin, sashal, boris.ostrovsky, jgross,
sstabellini, akpm, david, osalvador, mhocko, pasha.tatashin,
dan.j.williams, richard.weiyang, cai, linux-hyperv, xen-devel,
linux-mm, linux-kernel
On Sun, Sep 08, 2019 at 03:17:01AM +0530, Souptick Joarder wrote:
> __online_page_set_limits() is a dummy function and an extra call
> to this can be avoided.
>
> As both of the callers are now removed, __online_page_set_limits()
> can be removed permanently.
>
> Souptick Joarder (3):
> hv_ballon: Avoid calling dummy function __online_page_set_limits()
> xen/ballon: Avoid calling dummy function __online_page_set_limits()
> mm/memory_hotplug.c: Remove __online_page_set_limits()
>
> drivers/hv/hv_balloon.c | 1 -
> drivers/xen/balloon.c | 1 -
> include/linux/memory_hotplug.h | 1 -
> mm/memory_hotplug.c | 5 -----
> 4 files changed, 8 deletions(-)
Do we really need 3 separate patches to remove 8 lines of code?
--
Kirill A. Shutemov
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/3] Remove __online_page_set_limits()
2019-09-09 15:42 ` Kirill A. Shutemov
@ 2019-09-10 12:56 ` Souptick Joarder
2019-09-10 12:58 ` David Hildenbrand
0 siblings, 1 reply; 12+ messages in thread
From: Souptick Joarder @ 2019-09-10 12:56 UTC (permalink / raw)
To: Kirill A. Shutemov
Cc: kys, haiyangz, sthemmin, sashal, Boris Ostrovsky, Juergen Gross,
sstabellini, Andrew Morton, david, osalvador, Michal Hocko,
pasha.tatashin, Dan Williams, richard.weiyang, Qian Cai,
linux-hyperv, xen-devel, Linux-MM, linux-kernel
On Mon, Sep 9, 2019 at 9:12 PM Kirill A. Shutemov <kirill@shutemov.name> wrote:
>
> On Sun, Sep 08, 2019 at 03:17:01AM +0530, Souptick Joarder wrote:
> > __online_page_set_limits() is a dummy function and an extra call
> > to this can be avoided.
> >
> > As both of the callers are now removed, __online_page_set_limits()
> > can be removed permanently.
> >
> > Souptick Joarder (3):
> > hv_ballon: Avoid calling dummy function __online_page_set_limits()
> > xen/ballon: Avoid calling dummy function __online_page_set_limits()
> > mm/memory_hotplug.c: Remove __online_page_set_limits()
> >
> > drivers/hv/hv_balloon.c | 1 -
> > drivers/xen/balloon.c | 1 -
> > include/linux/memory_hotplug.h | 1 -
> > mm/memory_hotplug.c | 5 -----
> > 4 files changed, 8 deletions(-)
>
> Do we really need 3 separate patches to remove 8 lines of code?
I prefer to split into series of 3 which looks more clean. But I am ok
with other option.
Would you like to merge into single one ?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/3] Remove __online_page_set_limits()
2019-09-10 12:56 ` Souptick Joarder
@ 2019-09-10 12:58 ` David Hildenbrand
0 siblings, 0 replies; 12+ messages in thread
From: David Hildenbrand @ 2019-09-10 12:58 UTC (permalink / raw)
To: Souptick Joarder, Kirill A. Shutemov
Cc: kys, haiyangz, sthemmin, sashal, Boris Ostrovsky, Juergen Gross,
sstabellini, Andrew Morton, osalvador, Michal Hocko,
pasha.tatashin, Dan Williams, richard.weiyang, Qian Cai,
linux-hyperv, xen-devel, Linux-MM, linux-kernel
On 10.09.19 14:56, Souptick Joarder wrote:
> On Mon, Sep 9, 2019 at 9:12 PM Kirill A. Shutemov <kirill@shutemov.name> wrote:
>>
>> On Sun, Sep 08, 2019 at 03:17:01AM +0530, Souptick Joarder wrote:
>>> __online_page_set_limits() is a dummy function and an extra call
>>> to this can be avoided.
>>>
>>> As both of the callers are now removed, __online_page_set_limits()
>>> can be removed permanently.
>>>
>>> Souptick Joarder (3):
>>> hv_ballon: Avoid calling dummy function __online_page_set_limits()
>>> xen/ballon: Avoid calling dummy function __online_page_set_limits()
>>> mm/memory_hotplug.c: Remove __online_page_set_limits()
>>>
>>> drivers/hv/hv_balloon.c | 1 -
>>> drivers/xen/balloon.c | 1 -
>>> include/linux/memory_hotplug.h | 1 -
>>> mm/memory_hotplug.c | 5 -----
>>> 4 files changed, 8 deletions(-)
>>
>> Do we really need 3 separate patches to remove 8 lines of code?
>
> I prefer to split into series of 3 which looks more clean. But I am ok
> with other option.
> Would you like to merge into single one ?
>
If you have to resend, you could squash them into one. If not, I think
this is okay ...
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 12+ messages in thread