From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Jason Yan <yanaijie@huawei.com>,
martin.petersen@oracle.com, jejb@linux.ibm.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
hare@suse.com, hch@lst.de, bvanassche@acm.org,
john.garry@huawei.com, jinpu.wang@cloud.ionos.com,
Jack Wang <jinpu.wang@ionos.com>
Subject: Re: [PATCH v3 4/8] scsi: mvsas: use sas_find_attached_phy() instead of open coded
Date: Tue, 27 Sep 2022 11:27:31 +0900 [thread overview]
Message-ID: <7f557035-0f9d-d93d-ce19-a73116076497@opensource.wdc.com> (raw)
In-Reply-To: <20220927022941.4029476-5-yanaijie@huawei.com>
On 9/27/22 11:29, Jason Yan wrote:
> The attached phy finding is open coded. Now we can replace it with
> sas_find_attached_phy().
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> Reviewed-by: Jack Wang <jinpu.wang@ionos.com>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/scsi/mvsas/mv_sas.c | 15 ++++-----------
> 1 file changed, 4 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
> index a6867dae0e7c..f6576ffabe9f 100644
> --- a/drivers/scsi/mvsas/mv_sas.c
> +++ b/drivers/scsi/mvsas/mv_sas.c
> @@ -1190,23 +1190,16 @@ static int mvs_dev_found_notify(struct domain_device *dev, int lock)
> mvi_device->sas_device = dev;
> if (parent_dev && dev_is_expander(parent_dev->dev_type)) {
> int phy_id;
> - u8 phy_num = parent_dev->ex_dev.num_phys;
> - struct ex_phy *phy;
> - for (phy_id = 0; phy_id < phy_num; phy_id++) {
> - phy = &parent_dev->ex_dev.ex_phy[phy_id];
> - if (SAS_ADDR(phy->attached_sas_addr) ==
> - SAS_ADDR(dev->sas_addr)) {
> - mvi_device->attached_phy = phy_id;
> - break;
> - }
> - }
>
> - if (phy_id == phy_num) {
> + phy_id = sas_find_attached_phy(&parent_dev->ex_dev, dev);
> + if (phy_id == -ENODEV) {
> mv_printk("Error: no attached dev:%016llx"
> "at ex:%016llx.\n",
> SAS_ADDR(dev->sas_addr),
> SAS_ADDR(parent_dev->sas_addr));
> res = -1;
Would be nice to keep the -ENODEV error here instead of this generic, and
meaningless, "-1" code. Same for the previous patch too.
> + } else {
> + mvi_device->attached_phy = phy_id;
> }
> }
>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2022-09-27 2:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 2:29 [PATCH v3 0/8] scsi: libsas: sas address comparation refactor Jason Yan
2022-09-27 2:29 ` [PATCH v3 1/8] scsi: libsas: introduce sas address comparation helpers Jason Yan
2022-09-27 2:23 ` Damien Le Moal
2022-09-27 2:44 ` Jason Yan
2022-09-27 2:29 ` [PATCH v3 2/8] scsi: libsas: introduce sas_find_attached_phy() helper Jason Yan
2022-09-27 2:24 ` Damien Le Moal
2022-09-27 2:29 ` [PATCH v3 3/8] scsi: pm8001: use sas_find_attached_phy() instead of open coded Jason Yan
2022-09-27 2:25 ` Damien Le Moal
2022-09-27 2:29 ` [PATCH v3 4/8] scsi: mvsas: " Jason Yan
2022-09-27 2:27 ` Damien Le Moal [this message]
2022-09-27 2:29 ` [PATCH v3 5/8] scsi: hisi_sas: use sas_find_attathed_phy() " Jason Yan
2022-09-27 2:28 ` Damien Le Moal
2022-09-27 2:29 ` [PATCH v3 6/8] scsi: libsas: use sas_phy_match_dev_addr() " Jason Yan
2022-09-27 2:30 ` Damien Le Moal
2022-09-27 2:35 ` Jason Yan
2022-09-27 2:29 ` [PATCH v3 7/8] scsi: libsas: use sas_phy_addr_match() " Jason Yan
2022-09-27 2:31 ` Damien Le Moal
2022-09-27 2:29 ` [PATCH v3 8/8] scsi: libsas: use sas_phy_match_port_addr() " Jason Yan
2022-09-27 2:32 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f557035-0f9d-d93d-ce19-a73116076497@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=jinpu.wang@ionos.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).