From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752557AbdLDRfZ (ORCPT ); Mon, 4 Dec 2017 12:35:25 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:58644 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752065AbdLDRfW (ORCPT ); Mon, 4 Dec 2017 12:35:22 -0500 Subject: Re: [PATCH v6 0/2] memory: Introduce ti-emif-sram driver To: Tony Lindgren Cc: Dave Gerlach , Santosh Shilimkar , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Russell King , Keerthy J , Johan Hovold References: <1512082568-5012-1-git-send-email-d-gerlach@ti.com> <179c7668-05eb-09cf-9857-7b6fd2308c3a@oracle.com> <20171203163632.GU28152@atomide.com> From: Santosh Shilimkar Organization: Oracle Corporation Message-ID: <7f5fa64a-9c4e-cad6-df46-70cc02cba319@oracle.com> Date: Mon, 4 Dec 2017 09:35:21 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171203163632.GU28152@atomide.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8735 signatures=668637 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712040253 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/3/2017 8:36 AM, Tony Lindgren wrote: > * santosh.shilimkar@oracle.com [171203 04:03]: >> >> >> On 11/30/17 2:56 PM, Dave Gerlach wrote: >>> This is a resend of v5 of this series found here [1]. It introduces >>> relocatable PM handlers for the emif that are copied to sram and >>> run from there during low power mode entry. >>> >>> The patches still have the previous ACKs but have a small change to >>> accomodate a change made by Tony in commit cd57dc5a2099 ("ARM: dts: >>> Add missing hwmod related nodes for am33xx"). If there are objections >>> to this let me know ASAP. >>> >>> Now that a hwmod is present for the am335x EMIF, on probe fail the call to >>> pm_runtime_put_sync causes the board to hang. In fact, this emif driver should >>> never alter the PM state of the hardware at all through normal kernel calls, it >>> is the job of the suspend handlers that are added, that is the whole point of >>> this driver. Because of this, I have dropped all runtime pm calls, as any >>> change to the PM state while the kernel is running is dangerous as we may shut >>> of the memory controller. It makes the most sense just to drop runtime PM from >>> the driver entirely. Besides that patch is unchanged. >>> >>> This code is required for low-power modes to work on AM335x and AM437x and a >>> forthcoming PM series for those platforms will depend on this series. After >>> both this and the PM series are reviewed I will send the necessary device tree >>> changes for both, but in the meantime all remaining patches for am335x and >>> am437x PM can be found here [2]. >>> >> Applied > > OK, do you have some immutable commit for these I can pull in too for > the related SoC changes? > Hopefully I don't have do any changes to below branch. git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux-keystone.git for_4.16/drivers-soc