From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E298BC43217 for ; Sun, 20 Nov 2022 10:51:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229707AbiKTKvG (ORCPT ); Sun, 20 Nov 2022 05:51:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbiKTKvE (ORCPT ); Sun, 20 Nov 2022 05:51:04 -0500 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E1386D971 for ; Sun, 20 Nov 2022 02:51:03 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id t10so11757388ljj.0 for ; Sun, 20 Nov 2022 02:51:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MD/aDEMiTsY3yltE9lY/nF7UISvnsQa9yhMUv8ugeGo=; b=aPviQmrOAW3eIY8m7OB92kUFi22k3BdcvMicsL9ZMqPs+nWdu0V3U2ZRnOkVh5PT6m W/Z6pVeOQPA6t1floLF+z7X3K8I2QQW80CEsOWf3GYfrDyUh7hSiOGtGpu8TEAymfHRZ LKDljkvElo62d2NGGx2u/rrOVCV2+uaycjDn8PLxa2o+R4NUMU8jNRn0yw4Br4K4MC8S p4c4U3eFwXpFMHYBbbtwoQ8mvJL9CrDRFE9jNNL7Teb24cJHuwU1BfmM/lwlz2hqoDTX OujMFKETAFLZQXlP/L60ACV9zHRiaToVqwnQqu+9aZN0IaUyOoWRgRlVEVFMAJPTkkwS hZnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MD/aDEMiTsY3yltE9lY/nF7UISvnsQa9yhMUv8ugeGo=; b=duwJaUeeTc9Uotbm+rcP3318MAWHjzSQokpsFVl39tbVA6gx/6WrcmeH1jyI8slIM8 ER193VNR/o2oF/tj72+pqCF/ek6NYhYPEp5fThmTCj+DKRqdyZhj9d+gd/7rwtplkVzj 7NOxvTycgN9F4SuLtgS1NWIjHCrosYlh1FTOfDQscSsdCS6ZU0ntL87VZ+cJcmKdE24I z4iqQacuhXN53zEihEtTymC5lKqzjzZBn7cG1+UZDkLRNjE/sgsz53TyTLz662+Z6ibl Or5q2sqPEb3z0y0lqtOvEWZYSHaaYGN3TFly2E4rwGUaUhTwNb/wEQyDrQeOD1Lvl2mS sY+Q== X-Gm-Message-State: ANoB5pknEYa22OoYUStMWHs/In5Qa5ojHdbBeJEZHwBjdmiywUL/HTpt pI3gwCi2F3oZDFsgiEmZ4olQ0A== X-Google-Smtp-Source: AA0mqf4S0gZL/5jiqZOE1CraCz/s3w5qTX4gS0hM54SY+oE7urs7KfvUlrBWUVS0Ry0vVjoz//gITg== X-Received: by 2002:a05:651c:1079:b0:277:3592:c2c0 with SMTP id y25-20020a05651c107900b002773592c2c0mr4779585ljm.81.1668941461690; Sun, 20 Nov 2022 02:51:01 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id m14-20020a056512358e00b004b01305732bsm1493997lfr.216.2022.11.20.02.51.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Nov 2022 02:51:01 -0800 (PST) Message-ID: <7f7a2966-62d1-c1e9-63c9-201881c9a3a6@linaro.org> Date: Sun, 20 Nov 2022 11:51:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: msm8916-acer-a1-724: Add initial device tree Content-Language: en-US To: "Lin, Meng-Bo" , linux-kernel@vger.kernel.org Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Stephan Gerhold , Nikita Travkin , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <20221119204209.94125-1-linmengbo0689@protonmail.com> <20221119204414.94287-1-linmengbo0689@protonmail.com> From: Krzysztof Kozlowski In-Reply-To: <20221119204414.94287-1-linmengbo0689@protonmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/11/2022 21:46, Lin, Meng-Bo wrote: > Acer Iconia Talk S A1-724 is a tablet using the MSM8916 SoC released > in 2014. > > Note: The original firmware from Acer can only boot 32-bit kernels. > To boot arm64 kernels it is necessary to flash 64-bit TZ/HYP firmware > with EDL, e.g. taken from the DragonBoard 410c. This works because Acer > didn't set up (firmware) secure boot. > > Add a device tree for with initial support for: Thank you for your patch. There is something to discuss/improve. > + > +/ { > + model = "Acer Iconia Talk S A1-724"; > + compatible = "acer,a1-724", "qcom,msm8916"; > + chassis-type = "tablet"; > + > + aliases { > + serial0 = &blsp1_uart2; > + }; > + > + chosen { > + stdout-path = "serial0"; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio_keys_default>; > + > + label = "GPIO Buttons"; > + > + button-volume-up { > + label = "Volume Up"; > + gpios = <&msmgpio 107 GPIO_ACTIVE_LOW>; > + linux,code = ; > + }; > + }; > + > + usb_id: usb-id { > + compatible = "linux,extcon-usb-gpio"; > + id-gpio = <&msmgpio 110 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&usb_id_default>; > + }; > +}; > + > +&blsp1_uart2 { > + status = "okay"; > +}; > + > +&pm8916_resin { > + status = "okay"; status is the last property > + linux,code = ; > +}; > + > +&pm8916_vib { > + status = "okay"; > +}; > + > +&pronto { > + status = "okay"; > +}; > + > +&sdhc_1 { > + status = "okay"; Here as well and in all other places. Best regards, Krzysztof