linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiada Wang <jiada_wang@mentor.com>
To: Stephen Boyd <sboyd@kernel.org>, <geert+renesas@glider.be>,
	<horms@verge.net.au>, <magnus.damm@gmail.com>,
	<mark.rutland@arm.com>, <mturquette@baylibre.com>,
	<robh+dt@kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
	<linux-renesas-soc@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH linux-next v1 2/4] clk: renesas: Add binding document for AVB Counter Clock
Date: Thu, 22 Nov 2018 16:06:10 +0900	[thread overview]
Message-ID: <7f8827a5-c65d-0e1e-a0f9-23b31305d26a@mentor.com> (raw)
In-Reply-To: <154130125117.88331.5969014008610987799@swboyd.mtv.corp.google.com>

Hi Stephen


On 2018/11/04 12:14, Stephen Boyd wrote:
> Quoting Jiada Wang (2018-10-31 05:00:49)
>> On 2018/10/30 3:29, Stephen Boyd wrote:
>>> Quoting jiada_wang@mentor.com (2018-10-25 00:23:47)
>>>> +Required Properties:
>>>> +  - compatible: Must be "renesas,clk-avb"
>>>> +  - reg: Base address and length of the memory resource used by the AVB
>>>> +  - #clock-cells: Must be 1
>>>> +
>>>> +Example
>>>> +-------
>>>> +
>>>> +       clk_avb: avb-clock@ec5a011c {
>>>> +               compatible = "renesas,clk-avb";
>>>> +               reg = <0 0xec5a011c 0 0x24>;
>>> This is an odd register offset. Is this just one clk inside of a larger
>>> clk controller?
>>>
>> Yes, avb_counter clock is part of Audio Clock Generator reg: <0
>> 0xec5a0000 0 0x140>,
>> but "adg" has already been declared in R-Car GEN2/GEN3 SoC .dtsi file,
>> with reg: <0 0xec5a0000 0 0x100>,
>> which leaves <0 0xec5a0100 0 0x140> currently not used by any module.
>>
> So why can't we expand the register size in the dts file and update the
> audio clock generator driver to register this avb clock too? Presumably
> the mapping is large enough to cover the clk registers already so it is
> more of a formality to expand the register size than a requirement.
I am working on ver2 to expend register size to cover <0 0xec5a0100 0 0x140>
in audio clock generator (ADG) driver, but as provider of newly added 
"AVB_COUNTER" clock,
ADG driver also uses these clocks if necessary, so it keeps itself BUSY,
and cause ADG driver can't be unloaded.
my question is, is such use case allowed? (clock provider is also client 
of clocks).


Thanks,
Jiada


  reply	other threads:[~2018-11-22  7:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25  7:23 [PATCH linux-next v1 0/4] Add " jiada_wang
2018-10-25  7:23 ` [PATCH linux-next v1 1/4] clk: renesas: clk-avb: add AVB Clock driver jiada_wang
2018-10-29 18:34   ` Stephen Boyd
2018-10-25  7:23 ` [PATCH linux-next v1 2/4] clk: renesas: Add binding document for AVB Counter Clock jiada_wang
2018-10-25 21:49   ` Rob Herring
2018-10-26  2:32     ` Jiada Wang
2018-10-29 13:14       ` Rob Herring
2018-10-29 18:29   ` Stephen Boyd
2018-10-31 12:00     ` Jiada Wang
2018-11-04  3:14       ` Stephen Boyd
2018-11-22  7:06         ` Jiada Wang [this message]
2018-11-27 21:59           ` Stephen Boyd
2018-10-25  7:23 ` [PATCH linux-next v1 3/4] arm64: ulcb: Add avb counter clock jiada_wang
2018-10-25 20:22   ` Geert Uytterhoeven
2018-10-26  2:19     ` Jiada Wang
2018-10-25  7:23 ` [PATCH linux-next v1 4/4] arm64: salvator-common: " jiada_wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f8827a5-c65d-0e1e-a0f9-23b31305d26a@mentor.com \
    --to=jiada_wang@mentor.com \
    --cc=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --subject='Re: [PATCH linux-next v1 2/4] clk: renesas: Add binding document for AVB Counter Clock' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).