From: Juergen Gross <jgross@suse.com>
To: Elliot Berman <quic_eberman@quicinc.com>,
"Srivatsa S. Bhat (VMware)" <srivatsa@csail.mit.edu>,
Alexey Makhalov <amakhalov@vmware.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: Prakruthi Deepak Heragu <quic_pheragu@quicinc.com>,
virtualization@lists.linux-foundation.org, x86@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Murali Nalajala <quic_mnalajal@quicinc.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] arm64: paravirt: Use RCU read locks to guard stolen_time
Date: Wed, 4 May 2022 15:40:09 +0200 [thread overview]
Message-ID: <7fa956e0-98dd-4bce-033b-8566f1b7cfc6@suse.com> (raw)
In-Reply-To: <20220428183536.2866667-1-quic_eberman@quicinc.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 2459 bytes --]
On 28.04.22 20:35, Elliot Berman wrote:
> From: Prakruthi Deepak Heragu <quic_pheragu@quicinc.com>
>
> During hotplug, the stolen time data structure is unmapped and memset.
> There is a possibility of the timer IRQ being triggered before memset
> and stolen time is getting updated as part of this timer IRQ handler. This
> causes the below crash in timer handler -
>
> [ 3457.473139][ C5] Unable to handle kernel paging request at virtual address ffffffc03df05148
> ...
> [ 3458.154398][ C5] Call trace:
> [ 3458.157648][ C5] para_steal_clock+0x30/0x50
> [ 3458.162319][ C5] irqtime_account_process_tick+0x30/0x194
> [ 3458.168148][ C5] account_process_tick+0x3c/0x280
> [ 3458.173274][ C5] update_process_times+0x5c/0xf4
> [ 3458.178311][ C5] tick_sched_timer+0x180/0x384
> [ 3458.183164][ C5] __run_hrtimer+0x160/0x57c
> [ 3458.187744][ C5] hrtimer_interrupt+0x258/0x684
> [ 3458.192698][ C5] arch_timer_handler_virt+0x5c/0xa0
> [ 3458.198002][ C5] handle_percpu_devid_irq+0xdc/0x414
> [ 3458.203385][ C5] handle_domain_irq+0xa8/0x168
> [ 3458.208241][ C5] gic_handle_irq.34493+0x54/0x244
> [ 3458.213359][ C5] call_on_irq_stack+0x40/0x70
> [ 3458.218125][ C5] do_interrupt_handler+0x60/0x9c
> [ 3458.223156][ C5] el1_interrupt+0x34/0x64
> [ 3458.227560][ C5] el1h_64_irq_handler+0x1c/0x2c
> [ 3458.232503][ C5] el1h_64_irq+0x7c/0x80
> [ 3458.236736][ C5] free_vmap_area_noflush+0x108/0x39c
> [ 3458.242126][ C5] remove_vm_area+0xbc/0x118
> [ 3458.246714][ C5] vm_remove_mappings+0x48/0x2a4
> [ 3458.251656][ C5] __vunmap+0x154/0x278
> [ 3458.255796][ C5] stolen_time_cpu_down_prepare+0xc0/0xd8
> [ 3458.261542][ C5] cpuhp_invoke_callback+0x248/0xc34
> [ 3458.266842][ C5] cpuhp_thread_fun+0x1c4/0x248
> [ 3458.271696][ C5] smpboot_thread_fn+0x1b0/0x400
> [ 3458.276638][ C5] kthread+0x17c/0x1e0
> [ 3458.280691][ C5] ret_from_fork+0x10/0x20
>
> As a fix, introduce rcu lock to update stolen time structure.
>
> Fixes: 75df529bec91 ("arm64: paravirt: Initialize steal time when cpu is online")
> Cc: stable@vger.kernel.org
> Signed-off-by: Prakruthi Deepak Heragu <quic_pheragu@quicinc.com>
> Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2022-05-04 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 18:35 [PATCH v2] arm64: paravirt: Use RCU read locks to guard stolen_time Elliot Berman
2022-05-04 9:45 ` Will Deacon
2022-05-04 13:38 ` Juergen Gross
2022-05-04 13:50 ` Will Deacon
2022-05-04 13:40 ` Juergen Gross [this message]
2022-05-05 10:49 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fa956e0-98dd-4bce-033b-8566f1b7cfc6@suse.com \
--to=jgross@suse.com \
--cc=amakhalov@vmware.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_eberman@quicinc.com \
--cc=quic_mnalajal@quicinc.com \
--cc=quic_pheragu@quicinc.com \
--cc=srivatsa@csail.mit.edu \
--cc=stable@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).