linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module
@ 2021-05-14 13:17 Krzysztof Kozlowski
  2021-05-14 13:48 ` Guenter Roeck
  0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-14 13:17 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck, Thomas Bogendoerfer,
	Philipp Zabel, linux-watchdog, linux-kernel, linux-mips,
	John Crispin
  Cc: Lee Jones, Krzysztof Kozlowski, kernel test robot

When rt2880_wdt watchdog driver is built as a module, the
rt_sysc_membase needs to be exported (it is being used via inlined
rt_sysc_r32):

  ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 arch/mips/ralink/of.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/mips/ralink/of.c b/arch/mips/ralink/of.c
index 0c5de07da097..b3ce706426c4 100644
--- a/arch/mips/ralink/of.c
+++ b/arch/mips/ralink/of.c
@@ -24,6 +24,8 @@
 #include "common.h"
 
 __iomem void *rt_sysc_membase;
+EXPORT_SYMBOL_GPL(rt_sysc_membase);
+
 __iomem void *rt_memc_membase;
 
 __iomem void *plat_of_remap_node(const char *node)
-- 
2.27.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module
  2021-05-14 13:17 [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module Krzysztof Kozlowski
@ 2021-05-14 13:48 ` Guenter Roeck
  2021-05-14 14:04   ` Krzysztof Kozlowski
  2021-05-14 18:31   ` John Crispin
  0 siblings, 2 replies; 8+ messages in thread
From: Guenter Roeck @ 2021-05-14 13:48 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Wim Van Sebroeck, Thomas Bogendoerfer,
	Philipp Zabel, linux-watchdog, linux-kernel, linux-mips,
	John Crispin
  Cc: Lee Jones, kernel test robot

On 5/14/21 6:17 AM, Krzysztof Kozlowski wrote:
> When rt2880_wdt watchdog driver is built as a module, the
> rt_sysc_membase needs to be exported (it is being used via inlined
> rt_sysc_r32):
> 
>    ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Acked-by: Guenter Roeck <linux@roeck-us.net>

I don't see a recent change in the code. Has that problem been there
all along ?

Thanks,
Guenter

> ---
>   arch/mips/ralink/of.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/mips/ralink/of.c b/arch/mips/ralink/of.c
> index 0c5de07da097..b3ce706426c4 100644
> --- a/arch/mips/ralink/of.c
> +++ b/arch/mips/ralink/of.c
> @@ -24,6 +24,8 @@
>   #include "common.h"
>   
>   __iomem void *rt_sysc_membase;
> +EXPORT_SYMBOL_GPL(rt_sysc_membase);
> +
>   __iomem void *rt_memc_membase;
>   
>   __iomem void *plat_of_remap_node(const char *node)
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module
  2021-05-14 13:48 ` Guenter Roeck
@ 2021-05-14 14:04   ` Krzysztof Kozlowski
  2021-07-05 15:15     ` Krzysztof Kozlowski
  2021-05-14 18:31   ` John Crispin
  1 sibling, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-14 14:04 UTC (permalink / raw)
  To: Guenter Roeck, Wim Van Sebroeck, Thomas Bogendoerfer,
	Philipp Zabel, linux-watchdog, linux-kernel, linux-mips,
	John Crispin
  Cc: Lee Jones, kernel test robot

On 14/05/2021 09:48, Guenter Roeck wrote:
> On 5/14/21 6:17 AM, Krzysztof Kozlowski wrote:
>> When rt2880_wdt watchdog driver is built as a module, the
>> rt_sysc_membase needs to be exported (it is being used via inlined
>> rt_sysc_r32):
>>
>>    ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> 
> Acked-by: Guenter Roeck <linux@roeck-us.net>
> 
> I don't see a recent change in the code. Has that problem been there
> all along ?

I think the problem was there always but 0-day builder did not hit it
until recently:
https://lore.kernel.org/lkml/202105082122.yrF7ploN-lkp@intel.com/


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module
  2021-05-14 13:48 ` Guenter Roeck
  2021-05-14 14:04   ` Krzysztof Kozlowski
@ 2021-05-14 18:31   ` John Crispin
  1 sibling, 0 replies; 8+ messages in thread
From: John Crispin @ 2021-05-14 18:31 UTC (permalink / raw)
  To: Guenter Roeck, Krzysztof Kozlowski, Wim Van Sebroeck,
	Thomas Bogendoerfer, Philipp Zabel, linux-watchdog, linux-kernel,
	linux-mips
  Cc: Lee Jones, kernel test robot


On 14.05.21 15:48, Guenter Roeck wrote:
> On 5/14/21 6:17 AM, Krzysztof Kozlowski wrote:
>> When rt2880_wdt watchdog driver is built as a module, the
>> rt_sysc_membase needs to be exported (it is being used via inlined
>> rt_sysc_r32):
>>
>>    ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] 
>> undefined!
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> Acked-by: Guenter Roeck <linux@roeck-us.net>
>
> I don't see a recent change in the code. Has that problem been there
> all along ?
>
>
yes it has ...

Acked-by: John Crispin <john@phrozen.org>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module
  2021-05-14 14:04   ` Krzysztof Kozlowski
@ 2021-07-05 15:15     ` Krzysztof Kozlowski
  2021-07-05 16:08       ` Guenter Roeck
  0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2021-07-05 15:15 UTC (permalink / raw)
  To: Guenter Roeck, Wim Van Sebroeck, Thomas Bogendoerfer,
	Philipp Zabel, linux-watchdog, linux-kernel, linux-mips,
	John Crispin
  Cc: Lee Jones, kernel test robot

On 14/05/2021 16:04, Krzysztof Kozlowski wrote:
> On 14/05/2021 09:48, Guenter Roeck wrote:
>> On 5/14/21 6:17 AM, Krzysztof Kozlowski wrote:
>>> When rt2880_wdt watchdog driver is built as a module, the
>>> rt_sysc_membase needs to be exported (it is being used via inlined
>>> rt_sysc_r32):
>>>
>>>    ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>
>> Acked-by: Guenter Roeck <linux@roeck-us.net>
>>
>> I don't see a recent change in the code. Has that problem been there
>> all along ?
> 
> I think the problem was there always but 0-day builder did not hit it
> until recently:
> https://lore.kernel.org/lkml/202105082122.yrF7ploN-lkp@intel.com/

Hi Guenter,

It seems that patch was not applied. Anything to fix here?


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module
  2021-07-05 15:15     ` Krzysztof Kozlowski
@ 2021-07-05 16:08       ` Guenter Roeck
  2021-07-05 16:21         ` Krzysztof Kozlowski
  0 siblings, 1 reply; 8+ messages in thread
From: Guenter Roeck @ 2021-07-05 16:08 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Wim Van Sebroeck, Thomas Bogendoerfer,
	Philipp Zabel, linux-watchdog, linux-kernel, linux-mips,
	John Crispin
  Cc: Lee Jones, kernel test robot

On 7/5/21 8:15 AM, Krzysztof Kozlowski wrote:
> On 14/05/2021 16:04, Krzysztof Kozlowski wrote:
>> On 14/05/2021 09:48, Guenter Roeck wrote:
>>> On 5/14/21 6:17 AM, Krzysztof Kozlowski wrote:
>>>> When rt2880_wdt watchdog driver is built as a module, the
>>>> rt_sysc_membase needs to be exported (it is being used via inlined
>>>> rt_sysc_r32):
>>>>
>>>>     ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!
>>>>
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>>
>>> Acked-by: Guenter Roeck <linux@roeck-us.net>
>>>
>>> I don't see a recent change in the code. Has that problem been there
>>> all along ?
>>
>> I think the problem was there always but 0-day builder did not hit it
>> until recently:
>> https://lore.kernel.org/lkml/202105082122.yrF7ploN-lkp@intel.com/
> 
> Hi Guenter,
> 
> It seems that patch was not applied. Anything to fix here?
> 
I see commit fef532ea0cd8 ("MIPS: ralink: export rt_sysc_membase for
rt2880_wdt.c"). Does that not solve the problem ?

Guenter

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module
  2021-07-05 16:08       ` Guenter Roeck
@ 2021-07-05 16:21         ` Krzysztof Kozlowski
  2021-07-05 16:32           ` Guenter Roeck
  0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2021-07-05 16:21 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Wim Van Sebroeck, Thomas Bogendoerfer, Philipp Zabel,
	linux-watchdog, linux-kernel, linux-mips, John Crispin,
	Lee Jones, kernel test robot

On Mon, 5 Jul 2021 at 18:08, Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 7/5/21 8:15 AM, Krzysztof Kozlowski wrote:
> > On 14/05/2021 16:04, Krzysztof Kozlowski wrote:
> >> On 14/05/2021 09:48, Guenter Roeck wrote:
> >>> On 5/14/21 6:17 AM, Krzysztof Kozlowski wrote:
> >>>> When rt2880_wdt watchdog driver is built as a module, the
> >>>> rt_sysc_membase needs to be exported (it is being used via inlined
> >>>> rt_sysc_r32):
> >>>>
> >>>>     ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!
> >>>>
> >>>> Reported-by: kernel test robot <lkp@intel.com>
> >>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> >>>
> >>> Acked-by: Guenter Roeck <linux@roeck-us.net>
> >>>
> >>> I don't see a recent change in the code. Has that problem been there
> >>> all along ?
> >>
> >> I think the problem was there always but 0-day builder did not hit it
> >> until recently:
> >> https://lore.kernel.org/lkml/202105082122.yrF7ploN-lkp@intel.com/
> >
> > Hi Guenter,
> >
> > It seems that patch was not applied. Anything to fix here?
> >
> I see commit fef532ea0cd8 ("MIPS: ralink: export rt_sysc_membase for
> rt2880_wdt.c"). Does that not solve the problem ?

Yes, that fixes it. It was sent later, though. :(

Anyway, thanks!

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module
  2021-07-05 16:21         ` Krzysztof Kozlowski
@ 2021-07-05 16:32           ` Guenter Roeck
  0 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2021-07-05 16:32 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Wim Van Sebroeck, Thomas Bogendoerfer, Philipp Zabel,
	linux-watchdog, linux-kernel, linux-mips, John Crispin,
	Lee Jones, kernel test robot

On 7/5/21 9:21 AM, Krzysztof Kozlowski wrote:
> On Mon, 5 Jul 2021 at 18:08, Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> On 7/5/21 8:15 AM, Krzysztof Kozlowski wrote:
>>> On 14/05/2021 16:04, Krzysztof Kozlowski wrote:
>>>> On 14/05/2021 09:48, Guenter Roeck wrote:
>>>>> On 5/14/21 6:17 AM, Krzysztof Kozlowski wrote:
>>>>>> When rt2880_wdt watchdog driver is built as a module, the
>>>>>> rt_sysc_membase needs to be exported (it is being used via inlined
>>>>>> rt_sysc_r32):
>>>>>>
>>>>>>      ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!
>>>>>>
>>>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>>>>
>>>>> Acked-by: Guenter Roeck <linux@roeck-us.net>
>>>>>
>>>>> I don't see a recent change in the code. Has that problem been there
>>>>> all along ?
>>>>
>>>> I think the problem was there always but 0-day builder did not hit it
>>>> until recently:
>>>> https://lore.kernel.org/lkml/202105082122.yrF7ploN-lkp@intel.com/
>>>
>>> Hi Guenter,
>>>
>>> It seems that patch was not applied. Anything to fix here?
>>>
>> I see commit fef532ea0cd8 ("MIPS: ralink: export rt_sysc_membase for
>> rt2880_wdt.c"). Does that not solve the problem ?
> 
> Yes, that fixes it. It was sent later, though. :(
> 

Happens to me all the time. What is important is that things are getting
fixed. Personally I don't care that much for the credit.

Note though that your patch subject was a bit misleading, and it may well
be possible that the mips maintainers didn't realize that the fix needed
to be applied to the mips tree. The subject line in the applied patch
describes the change much better as it focuses on the change (what is done),
while the subject line in your patch focuses on the impact (what it fixes).

Guenter

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-07-05 16:32 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-14 13:17 [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module Krzysztof Kozlowski
2021-05-14 13:48 ` Guenter Roeck
2021-05-14 14:04   ` Krzysztof Kozlowski
2021-07-05 15:15     ` Krzysztof Kozlowski
2021-07-05 16:08       ` Guenter Roeck
2021-07-05 16:21         ` Krzysztof Kozlowski
2021-07-05 16:32           ` Guenter Roeck
2021-05-14 18:31   ` John Crispin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).