From: Alex Elder <elder@ieee.org>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
elder@kernel.org
Cc: bjorn.andersson@linaro.org, agross@kernel.org,
davem@davemloft.net, kuba@kernel.org,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
konrad.dybcio@somainline.org, marijn.suijten@somainline.org,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v1 1/7] net: ipa: Add support for IPA v3.1 with GSI v1.0
Date: Mon, 1 Mar 2021 20:05:02 -0600 [thread overview]
Message-ID: <7fdac2c4-b599-6db5-21e2-676c850edcf8@ieee.org> (raw)
In-Reply-To: <20210211175015.200772-2-angelogioacchino.delregno@somainline.org>
On 2/11/21 11:50 AM, AngeloGioacchino Del Regno wrote:
> In preparation for adding support for the MSM8998 SoC's IPA,
> add the necessary bits for IPA version 3.1 featuring GSI 1.0,
> found on at least MSM8998.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Overall, this looks good. As I mentioned, I've
implemented a very similar set of changes in my
private development tree. It's part of a much
larger set of changes intended to allow many
IPA versions to be supported.
A few minor comments, below.
-Alex
> ---
> drivers/net/ipa/gsi.c | 8 ++++----
> drivers/net/ipa/ipa_endpoint.c | 17 +++++++++--------
> drivers/net/ipa/ipa_main.c | 8 ++++++--
> drivers/net/ipa/ipa_reg.h | 3 +++
> drivers/net/ipa/ipa_version.h | 1 +
> 5 files changed, 23 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
> index 14d9a791924b..6315336b3ca8 100644
> --- a/drivers/net/ipa/gsi.c
> +++ b/drivers/net/ipa/gsi.c
> @@ -794,14 +794,14 @@ static void gsi_channel_program(struct gsi_channel *channel, bool doorbell)
>
> /* Max prefetch is 1 segment (do not set MAX_PREFETCH_FMASK) */
>
> - /* We enable the doorbell engine for IPA v3.5.1 */
> - if (gsi->version == IPA_VERSION_3_5_1 && doorbell)
> + /* We enable the doorbell engine for IPA v3.x */
> + if (gsi->version < IPA_VERSION_4_0 && doorbell)
My version:
if (gsi->version < IPA_VERSION_4_0 && doorbell)
So... You're doing the right thing. Almost all changes I made
like this were identical to yours; others were (I think all)
equivalent.
> val |= USE_DB_ENG_FMASK;
>
> /* v4.0 introduces an escape buffer for prefetch. We use it
> * on all but the AP command channel.
> */
> - if (gsi->version != IPA_VERSION_3_5_1 && !channel->command) {
> + if (gsi->version >= IPA_VERSION_4_0 && !channel->command) {
> /* If not otherwise set, prefetch buffers are used */
> if (gsi->version < IPA_VERSION_4_5)
> val |= USE_ESCAPE_BUF_ONLY_FMASK;
. . .
> diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c
> index 84bb8ae92725..be191993fbec 100644
> --- a/drivers/net/ipa/ipa_main.c
> +++ b/drivers/net/ipa/ipa_main.c
. . .
> @@ -276,6 +276,7 @@ static void ipa_hardware_config_qsb(struct ipa *ipa)
>
> max1 = 12;
> switch (version) {
> + case IPA_VERSION_3_1:
I do this a little differently now. These values will be
found in the "ipa_data" file for the platform.
Also I think you'd need different values for IPA v3.1 than
for IPA v3.5.1.
> case IPA_VERSION_3_5_1:
> max0 = 8;
> break;
> @@ -404,6 +405,9 @@ static void ipa_hardware_config(struct ipa *ipa)
> /* Enable open global clocks (not needed for IPA v4.5) */
> val = GLOBAL_FMASK;
> val |= GLOBAL_2X_CLK_FMASK;
> + if (version == IPA_VERSION_3_1)
> + val |= MISC_FMASK;
I see this being set for a workaround or IPA v3.1 in the
msm-4.4 tree, but the other two flags aren't set in that
case. So this might not be quite right.
> +
> iowrite32(val, ipa->reg_virt + IPA_REG_CLKON_CFG_OFFSET);
>
> /* Disable PA mask to allow HOLB drop */
. . .
next prev parent reply other threads:[~2021-03-02 7:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 17:50 [PATCH v1 0/7] Add support for IPA v3.1, GSI v1.0, MSM8998 IPA AngeloGioacchino Del Regno
2021-02-11 17:50 ` [PATCH v1 1/7] net: ipa: Add support for IPA v3.1 with GSI v1.0 AngeloGioacchino Del Regno
2021-02-12 18:49 ` Jakub Kicinski
2021-03-02 2:05 ` Alex Elder [this message]
2021-05-05 22:42 ` Alex Elder
2021-02-11 17:50 ` [PATCH v1 2/7] net: ipa: endpoint: Don't read unexistant register on IPAv3.1 AngeloGioacchino Del Regno
2021-03-02 2:05 ` Alex Elder
2021-05-05 22:42 ` Alex Elder
2021-02-11 17:50 ` [PATCH v1 3/7] net: ipa: gsi: Avoid some writes during irq setup for older IPA AngeloGioacchino Del Regno
2021-03-02 2:05 ` Alex Elder
2021-05-05 22:42 ` Alex Elder
2021-02-11 17:50 ` [PATCH v1 4/7] net: ipa: gsi: Use right masks for GSI v1.0 channels hw param AngeloGioacchino Del Regno
2021-03-02 2:05 ` Alex Elder
2021-05-05 22:42 ` Alex Elder
2021-02-11 17:50 ` [PATCH v1 5/7] net: ipa: Add support for IPA on MSM8998 AngeloGioacchino Del Regno
2021-02-12 18:50 ` Jakub Kicinski
2021-03-02 2:05 ` Alex Elder
2021-05-05 22:42 ` Alex Elder
2021-02-11 17:50 ` [PATCH v1 6/7] dt-bindings: net: qcom-ipa: Document qcom,sc7180-ipa compatible AngeloGioacchino Del Regno
2021-03-02 2:05 ` Alex Elder
2021-03-05 19:32 ` Rob Herring
2021-05-05 22:43 ` Alex Elder
2021-02-11 17:50 ` [PATCH v1 7/7] dt-bindings: net: qcom-ipa: Document qcom,msm8998-ipa compatible AngeloGioacchino Del Regno
2021-03-02 2:05 ` Alex Elder
2021-03-05 19:33 ` Rob Herring
2021-05-05 22:43 ` Alex Elder
2021-02-11 20:27 ` [PATCH v1 0/7] Add support for IPA v3.1, GSI v1.0, MSM8998 IPA Alex Elder
2021-02-11 21:51 ` AngeloGioacchino Del Regno
2021-03-02 2:04 ` Alex Elder
2021-05-05 22:42 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fdac2c4-b599-6db5-21e2-676c850edcf8@ieee.org \
--to=elder@ieee.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=elder@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=netdev@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).