From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F116C433F5 for ; Mon, 10 Sep 2018 02:47:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C13202075A for ; Mon, 10 Sep 2018 02:47:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="BBKMg6Tr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C13202075A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726402AbeIJHjX (ORCPT ); Mon, 10 Sep 2018 03:39:23 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:39860 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725957AbeIJHjX (ORCPT ); Mon, 10 Sep 2018 03:39:23 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id w8A2la7Z055280; Sun, 9 Sep 2018 21:47:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1536547656; bh=C3tmGvPxiVk4SsDF0siTwrBFh5bcFYJRNFcBE2sPGMM=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=BBKMg6TreakIN+U95pWZs0h0bEXTskmcSMLff8/55XXPRExX8GKmkwK/DpYIMYZy1 zAb1DBCxrLMUxk60zAqP9E08ZBrNTTexMcQM7M6AQAoxQnRRfjdQ3F84pq8FWTBeQZ 2z6citqdfsc5t5yDhtM48ssZZ21quu/Vl5G8TSoE= Received: from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w8A2lagB020590; Sun, 9 Sep 2018 21:47:36 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Sun, 9 Sep 2018 21:47:37 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Sun, 9 Sep 2018 21:47:36 -0500 Received: from [172.24.191.45] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w8A2lXa4013944; Sun, 9 Sep 2018 21:47:34 -0500 Subject: Re: [PATCH 2/5] gpio: davinci: Use dev name for label and automatic base selection To: Grygorii Strashko , Linus Walleij CC: "Andrew F. Davis" , "Nori, Sekhar" , Kevin Hilman , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" References: <20180831191326.25106-1-afd@ti.com> <20180831191326.25106-2-afd@ti.com> <2a02c241-ac91-1bac-380d-122858bb03c3@ti.com> <040ce524-f6e2-81a2-68db-57a645de22ea@ti.com> <0e199aa3-2d9d-4e7d-af23-8523722f017a@ti.com> From: Keerthy Message-ID: <7ffe6694-0bb1-d1ae-3d93-51f11a358cc0@ti.com> Date: Mon, 10 Sep 2018 08:17:32 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <0e199aa3-2d9d-4e7d-af23-8523722f017a@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 09 September 2018 01:11 AM, Grygorii Strashko wrote: > > > On 09/06/2018 09:16 AM, Keerthy wrote: >> >> >> On Wednesday 05 September 2018 04:07 PM, Linus Walleij wrote: >>> On Mon, Sep 3, 2018 at 7:40 AM Keerthy wrote: >>>> On Saturday 01 September 2018 12:43 AM, Andrew F. Davis wrote: >>>>> Use dev_name to get a unique label and use -1 for a base to get our >>>>> selection automatically. We pull in all GPIOs per chip now so this >>>>> does not have the effect of out of order labels like before. >>>>> >>>>> We do these both together so we can drop all the static data in one >>>>> patch. This also lets us normalize the return paths as we don't need >>>>> any cleanup after this change. >>>> >>>> echo 28 > /sys/class/gpio/export >>>> / # echo 28 > /sys/class/gpi[ 12.839205] export_store: invalid GPIO 28 >>>> o/export >>>> echo 2 > /sys/class/gp[ 22.165728] export_store: invalid GPIO 2 >>>> io/export >>>> / # echo 1 > /sys/class/gp[ 25.961392] export_store: invalid GPIO 1 >>>> io/export >>>> / # echo 3 > /sys/class/gp[ 29.981918] export_store: invalid GPIO 3 >>>> io/export >>>> >>>> Export fails with this patch. I am testing this on keystone-k2g-evm. >>> >>> I think the GPIO got a new number didn't it? >>> >>> Did you check the gpio file in debugfs to see which number >>> it got. >> >> Okay now its numbered differently: >> >> cat /sys/class/gpio/gpiochip340/ngpio >> 144 >> >> cat /sys/class/gpio/gpiochip272/ngpio >> 68 > > could you or Andrew provide content of /debug/gpio before/after? > And ls /sys/class/gpio/? Output on K2G: Before ====== cat /debug/gpio gpiochip1: GPIOs 0-143, parent: platform/2603000.gpio, davinci_gpio.0: gpiochip2: GPIOs 144-211, parent: platform/260a000.gpio, davinci_gpio.1: gpio-156 ( |cd ) in lo gpiochip0: GPIOs 484-511, parent: platform/2620240.keystone_dsp_gpio, 2620240.keystone_dsp_gpio: ls /sys/class/gpio/ export gpiochip0 gpiochip144 gpiochip484 unexport cat /sys/class/gpio/gpiochip0/label davinci_gpio.0 cat /sys/class/gpio/gpiochip144/label davinci_gpio.1 cat /sys/class/gpio/gpiochip144/ngpio 68 / # cat /sys/class/gpio/gpiochip0/ngpio 144 After ===== cat /debug/gpio gpiochip2: GPIOs 272-339, parent: platform/260a000.gpio, 260a000.gpio: gpio-284 ( |cd ) in lo gpiochip1: GPIOs 340-483, parent: platform/2603000.gpio, 2603000.gpio: gpiochip0: GPIOs 484-511, parent: platform/2620240.keystone_dsp_gpio, 2620240.keystone_dsp_gpio: ls /sys/class/gpio/ export gpiochip272 gpiochip340 gpiochip484 unexport cat /sys/class/gpio/gpiochip340/label 2603000.gpio / # cat /sys/class/gpio/gpiochip272/label 260a000.gpio / # cat /sys/class/gpio/gpiochip272/label cat /sys/class/gpio/gpiochip272/ngpio 68 / # cat /sys/class/gpio/gpiochip340/ngpio 144 In the case of SoCs that support multiple instances of Davinci GPIO IPs it is harder to figure out the right gpio number to export. >> >> So gpio bank2 and bank1 have different gpio numbers. Is that acceptable? >> >>> >>> This is sadly the global numberspace that we are tying to >>> get rid of (new apps/scripts should use the chardev). >>> >>> Are there applications that rely on the sysfs ABI on DaVinci? >>> >>> In that case base needs to be prerseved. > > Not only base, but label also - /sys/class/gpio/gpiochip0/label, as this is > the way to find proper GPIO chip in sysfs using legacy GPIO ABI. > > Linus, this platform is old and most of the users do not use new ABI (chardev), > so we could try change this, but need to be prepared for regressions reports. > Totally agree with this.