From: Kevin Hilman <khilman@kernel.org>
To: Hsin-Yi Wang <hsinyi@google.com>, Tim Chang <jia-wei.chang@mediatek.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
fan.chen@mediatek.com, louis.yu@mediatek.com,
roger.lu@mediatek.com, Allen-yy.Lin@mediatek.com,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Jia-Wei Chang <jia-wei.chang@mediatek.corp-partner.google.com>
Subject: Re: [PATCH 2/3] devfreq: mediatek: add mt8183 cci devfreq driver
Date: Thu, 07 Apr 2022 14:52:25 -0700 [thread overview]
Message-ID: <7h7d808sti.fsf@baylibre.com> (raw)
In-Reply-To: <CACb=7PUSAF6ui2a7iMYrrXo=v0OaXhCfiF=dPzq4cfUXM3JbDg@mail.gmail.com>
Hsin-Yi Wang <hsinyi@google.com> writes:
> On Mon, Mar 7, 2022 at 8:32 PM Tim Chang <jia-wei.chang@mediatek.com> wrote:
>>
>> This adds a devfreq driver for the Cache Coherent Interconnect (CCI) of
>> the Mediatek MT8183.
>>
>> On mt8183 the cci is supplied by the same regulator as the little cores.
>> The driver is notified when the regulator voltage changes (driven by
>> cpufreq) and adjusts the cci frequency to the maximum possible value.
>>
>> Add need_voltage_tracking variable to platforma data. if true, it
>> indicates soc is required to realize the voltage tracking between
>> voltage of sram and voltage of cci by software approach. otherwise, the
>> voltage tracking is realized by hardware appraoch.
>>
>> Add the notifier to cci so that it could react after svs driver changes
>> opp table of cci.
>>
>> Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.corp-partner.google.com>
[...]
>> +
>> + passive_data = devm_kzalloc(cci_dev, sizeof(struct devfreq_passive_data), GFP_KERNEL);
>> + if (!passive_data) {
>> + ret = -ENOMEM;
>> + goto out_remove_opp_table;
>> + }
>> +
>> + passive_data->parent_type = CPUFREQ_PARENT_DEV;
>
> It's better to add a note below commit message to state that this
> series depends on
> https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/log/?h=devfreq-testing
Not only is this series dependent the previous series from Chanwoo, in
also fails to compile if CONFIG_DEVFREQ_GOV_PASSIVE is not enabled,
because CPUFREQ_PARENT_DEV defined inside of an #ifdef.
Please compile test this with and without CONFIG_DEVFREQ_GOV_PASSIVE
enabled.
Kevin
next prev parent reply other threads:[~2022-04-07 21:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 12:25 [PATCH 0/3] devfreq: mediatek: introduce MTK cci devfreq Tim Chang
2022-03-07 12:25 ` [PATCH 1/3] dt-bindings: devfreq: mediatek: add mtk cci devfreq dt-bindings Tim Chang
2022-03-07 21:42 ` Krzysztof Kozlowski
2022-03-24 12:11 ` Jia-Wei Chang
2022-03-24 12:44 ` Krzysztof Kozlowski
2022-04-01 13:39 ` Jia-Wei Chang
2022-04-02 11:31 ` Krzysztof Kozlowski
2022-04-06 3:32 ` Jia-Wei Chang
2022-03-07 12:25 ` [PATCH 2/3] devfreq: mediatek: add mt8183 cci devfreq driver Tim Chang
2022-03-07 16:44 ` Hsin-Yi Wang
2022-04-07 21:52 ` Kevin Hilman [this message]
2022-04-08 2:53 ` Johnson Wang
2022-03-07 21:51 ` Krzysztof Kozlowski
2022-03-24 12:17 ` Jia-Wei Chang
2022-04-07 3:20 ` Chanwoo Choi
2022-04-07 11:45 ` Jia-Wei Chang
2022-03-07 12:25 ` [PATCH 3/3] devfreq: mediatek: add platform data to support mt8186 Tim Chang
2022-03-07 21:52 ` Krzysztof Kozlowski
2022-03-24 12:19 ` Jia-Wei Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h7d808sti.fsf@baylibre.com \
--to=khilman@kernel.org \
--cc=Allen-yy.Lin@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=fan.chen@mediatek.com \
--cc=hsinyi@google.com \
--cc=jia-wei.chang@mediatek.com \
--cc=jia-wei.chang@mediatek.corp-partner.google.com \
--cc=kyungmin.park@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=louis.yu@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
--cc=roger.lu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).