From: Kevin Hilman <khilman@baylibre.com>
To: Rob Herring <robh@kernel.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
"moderated list\:ARM\/FREESCALE IMX \/ MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christian Hewitt <christianshewitt@gmail.com>
Subject: Re: [PATCH 2/6] dt-bindings: arm: amlogic: add bindings for G12B based S922X SoC
Date: Wed, 07 Aug 2019 20:02:33 -0700 [thread overview]
Message-ID: <7h7e7ofjg6.fsf@baylibre.com> (raw)
In-Reply-To: <CAL_JsqL_L2qHe334sB57hR_coRhawKiqXYjKAQDJt_DHfBamBQ@mail.gmail.com>
Rob Herring <robh@kernel.org> writes:
> On Mon, Aug 5, 2019 at 3:46 PM Kevin Hilman <khilman@baylibre.com> wrote:
>>
>> Neil Armstrong <narmstrong@baylibre.com> writes:
>>
>> > Add a specific compatible for the Amlogic G12B family based S922X SoC
>> > to differentiate with the A311D SoC from the same family.
>> >
>> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> > ---
>> > Documentation/devicetree/bindings/arm/amlogic.yaml | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
>> > index 325c6fd3566d..3c3bc806cd23 100644
>> > --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
>> > +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
>> > @@ -139,6 +139,7 @@ properties:
>> > items:
>> > - enum:
>> > - hardkernel,odroid-n2
>> > + - const: amlogic,s922x
>> > - const: amlogic,g12b
>>
>> nit: in previous binding docs, we were trying to keep these sorted
>> alphabetically. I'll reorder the new "s922x" after "g12b" when
>> applying.
>
> No, this is not documentation ordering. It's the order compatible
> strings must be in.
Ah, thanks for clarifying,
Kevin
next prev parent reply other threads:[~2019-08-08 3:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 12:39 [PATCH 0/6] arm64: add support for the Khadas VIM3 Neil Armstrong
2019-07-31 12:39 ` [PATCH 1/6] soc: amlogic: meson-gx-socinfo: add A311D id Neil Armstrong
2019-08-05 21:47 ` Kevin Hilman
2019-07-31 12:39 ` [PATCH 2/6] dt-bindings: arm: amlogic: add bindings for G12B based S922X SoC Neil Armstrong
2019-07-31 16:54 ` Rob Herring
2019-08-05 21:46 ` Kevin Hilman
2019-08-05 22:21 ` Rob Herring
2019-08-05 22:26 ` Rob Herring
2019-08-08 3:02 ` Kevin Hilman [this message]
2019-07-31 12:39 ` [PATCH 3/6] dt-bindings: arm: amlogic: add bindings for the Amlogic G12B based A311D SoC Neil Armstrong
2019-07-31 16:55 ` Rob Herring
2019-07-31 12:39 ` [PATCH 4/6] dt-bindings: arm: amlogic: add support for the Khadas VIM3 Neil Armstrong
2019-07-31 16:55 ` Rob Herring
2019-07-31 12:39 ` [PATCH 5/6] arm64: dts: meson-g12b: support a311d and s922x cpu operating points Neil Armstrong
2019-07-31 12:40 ` [PATCH 6/6] arm64: dts: meson-g12b-khadas-vim3: add initial device-tree Neil Armstrong
2019-08-03 18:50 ` Martin Blumenstingl
2019-08-06 15:48 ` Neil Armstrong
2019-08-08 17:57 ` [PATCH 0/6] arm64: add support for the Khadas VIM3 Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h7e7ofjg6.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=christianshewitt@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).