From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E39FEC433FF for ; Sat, 10 Aug 2019 00:11:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BAE1820C01 for ; Sat, 10 Aug 2019 00:11:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="KECCdmkn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727678AbfHJALk (ORCPT ); Fri, 9 Aug 2019 20:11:40 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:37619 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726125AbfHJALk (ORCPT ); Fri, 9 Aug 2019 20:11:40 -0400 Received: by mail-pg1-f196.google.com with SMTP id d1so13794777pgp.4 for ; Fri, 09 Aug 2019 17:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=EuQ/R3CppOBh2T1D6FSE6/gAUMLd+emlPXZ8P0KlK4E=; b=KECCdmknzaH0Ve1akzRhLGqPfYzLSqiQZzqIGqUTh+SAcO6Q19ScBeUTVGmT9Kn2fi wuc/H+9Zvt1RiYlS2YMjELwda9ElQG3tetwgpwSLKyc3GMze7p3oJ/iAFf+mlr04fS3p 4SoG8g9Vg49LMc+XN9CN2yjxwMYkHbcBup94eMKinNVLCmVJIOstAPR1bTlg+BvjkpIY cd36ZXrgFEWiqQp6BRzMLy0rpNVl0ji479pxHPF2OWsm4aIthkJshQrCEUBBzGGR6KqN xCB5+OxoXjeEhzq/eUA6LgN2F98/tP71hoMrI7Rz306vlRZd504t0Hj1N10xjJOIG5GQ EZNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=EuQ/R3CppOBh2T1D6FSE6/gAUMLd+emlPXZ8P0KlK4E=; b=QczVjmMDoAVAgk2/S2eOVMFpKFLtb6M+PwLlkZqvWUU3MKNnf/syoE9GrgVC2hUrJX 6MRJPirA/ZCUDKat93qltspiVfh1VkqrY3M7UH88liM6621n0tD+j2CNuT77Id+yauPm lf5eo/Eye5qTxspKRxgV2hOJX2Dj5FJKA6ONeWsG8nUCib/kwQ+WMPSrJ1rQ3UoQ2iKo LgeRhv4VYdpjF00zTprd6SVI+85F01rUZzYRBN4H4pGAXIct5rSRmYOQ5qFMa0LmcV/f biWUvu4D/bO+CPuOKZKJt8RRZU+YicXRmj8hEDelw+gLY4dj5Yre6giPpdToLlYAmSVm RklA== X-Gm-Message-State: APjAAAXYRvcQORbvMMjG4XRU918xCN9gEY8m4sghZmXWJFtPA6wHlUgS hy2qcoVPyt/Jq79RWabeQgWKRw== X-Google-Smtp-Source: APXvYqwfo3bJUKvTH7g4ZfJhFp6Q9sQXhh6NsNs21MEaB/aVJYLW2l4lX40Zlrs3JJt56T2EbsbNBA== X-Received: by 2002:a62:82c1:: with SMTP id w184mr24770723pfd.8.1565395899475; Fri, 09 Aug 2019 17:11:39 -0700 (PDT) Received: from localhost ([2601:602:9200:a1a5:b873:707a:e893:cdb3]) by smtp.gmail.com with ESMTPSA id k14sm25201452pgb.78.2019.08.09.17.11.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Aug 2019 17:11:38 -0700 (PDT) From: Kevin Hilman To: Guillaume La Roque , daniel.lezcano@linaro.org Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 0/6] Add support of New Amlogic temperature sensor for G12 SoCs In-Reply-To: <20190806130506.8753-1-glaroque@baylibre.com> References: <20190806130506.8753-1-glaroque@baylibre.com> Date: Fri, 09 Aug 2019 17:11:37 -0700 Message-ID: <7hd0hd3mme.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Guillaume La Roque writes: > This patchs series add support of New Amlogic temperature sensor and minimal > thermal zone for SEI510 and ODROID-N2 boards. > > First implementation was doing on IIO[1] but after comments i move on thermal framework. > Formulas and calibration values come from amlogic. > > Changes since v2: > - fix yaml documention > - remove unneeded status variable for temperature-sensor node > - rework driver after Martin review > - add some information in commit message > > Changes since v1: > - fix enum vs const in documentation > - fix error with thermal-sensor-cells value set to 1 instead of 0 > - add some dependencies needed to add cooling-maps > > Dependencies : > - patch 3,4 & 5: depends on Neil's patch and series : > - missing dwc2 phy-names[2] > - patchsets to add DVFS on G12a[3] which have deps on [4] and [5] > > [1] https://lore.kernel.org/linux-amlogic/20190604144714.2009-1-glaroque@baylibre.com/ > [2] https://lore.kernel.org/linux-amlogic/20190625123647.26117-1-narmstrong@baylibre.com/ > [3] https://lore.kernel.org/linux-amlogic/20190729132622.7566-1-narmstrong@baylibre.com/ > [4] https://lore.kernel.org/linux-amlogic/20190731084019.8451-5-narmstrong@baylibre.com/ > [5] https://lore.kernel.org/linux-amlogic/20190729132622.7566-3-narmstrong@baylibre.com/ Thank you for the detailed list of dependencies! Much appreciated. With all the deps, I tested this on sei510 and odroid-n2, and basic functionality seems to work. As discussed off-list: it would be nice to have an example of how cpufreq could be used as a cooling device for hot temperatures. The vendor kernel has some trip points that could be included as examples, or even included as extra patches. Also the driver patch is missing the two main thermal maintainers, so please resend at least the driver and bindings including them. Kevin