From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A15AC432BE for ; Thu, 5 Aug 2021 18:36:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49969601FF for ; Thu, 5 Aug 2021 18:36:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241347AbhHESgy (ORCPT ); Thu, 5 Aug 2021 14:36:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241044AbhHESgx (ORCPT ); Thu, 5 Aug 2021 14:36:53 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 071F3C061765 for ; Thu, 5 Aug 2021 11:36:38 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id u13-20020a17090abb0db0290177e1d9b3f7so17030835pjr.1 for ; Thu, 05 Aug 2021 11:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=YIMav/La51ZrKR78GNIBd1q2L1Ytr3GQcPivgQa/OyI=; b=nJrzi2yhP0UKQHFJPFbWT6UwK++Pt+d6epKul13YdgjEVwmlkL5fCx4q6njbmNWIz5 AfzVBw4yvjW5BOcMIhziOXIkRIGsWxNMR0K7HKO+pu7dXYK2fr8QMJOGAuWMFXNK0wL1 F1zbgph7VHHteaZmaj1W2j6QQfrgXD+adUN466Rk33cuaWPCZyMUBD7qHpsS5kKSs0uz iJBakUSBS2v1opXIZb9e1CpZzrKF6pw3vXnxO/D+swMW+nJ2abjBCQGmpNo5nm7rDwF6 ggGB4cihjU6egXnslG3O8TVCu/qNQgMIvU9MUQ1aKGGwOWfDfY5Qov4v6hg/yZa90S0S B//g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=YIMav/La51ZrKR78GNIBd1q2L1Ytr3GQcPivgQa/OyI=; b=tgOsCCv+YkhPilgid9ygZ0FpTIIuQOHqK990N47AKvtcJGnTQDxBq6TDEQ8ilZbgry dPJWVgbVTX6BeThNNnJXEV+K/lcYMpChMtP4P8eQJZ+D4mRdouLG0EIaKngfOp2ooCx2 OsDDlhNfVe9qWlNXO9rMKrlnY+RFUQLRFfvJmTdmioC1WzEsViF10QJIlhI/ZEZi7K6i YA9afDKIWVgTvq+MD1QNivE+IzSOxCAKnJopYTudPKDT2LK0TsT0vSdFEEFGAdotQMej EL1rl51WLZJu8/B+nKGAeVPXZ9jz7hWbJuJKgqnJt3QVPwKpyJrHVTCV8mgHCmhYdLFh Ewyg== X-Gm-Message-State: AOAM5313N7J1bso7RWJJhF2kZDLmsrKHJxzt9xAMLVjUIWt9w80SMbva BNmkeu2xbUOG6hGlwoUDIDuWYQ== X-Google-Smtp-Source: ABdhPJytjIE85GWEjPS6HThNxgBSb9Rqc6SliBd1gG3FpFAZBO3H8U69cXYn3pME9qOhQqDnJ48FEQ== X-Received: by 2002:a17:902:da89:b029:12c:d398:64e8 with SMTP id j9-20020a170902da89b029012cd39864e8mr5146132plx.56.1628188597527; Thu, 05 Aug 2021 11:36:37 -0700 (PDT) Received: from localhost ([2601:602:9200:1465:3cf3:58bc:1858:688c]) by smtp.gmail.com with ESMTPSA id o22sm7354195pfu.87.2021.08.05.11.36.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 11:36:37 -0700 (PDT) From: Kevin Hilman To: Marc Zyngier , Saravana Kannan Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Neil Armstrong , kernel-team@android.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 0/3] Clean up and fix error handling in mdio_mux_init() In-Reply-To: <87v94kb6xa.wl-maz@kernel.org> References: <20210804214333.927985-1-saravanak@google.com> <87v94kb6xa.wl-maz@kernel.org> Date: Thu, 05 Aug 2021 11:36:36 -0700 Message-ID: <7hfsvng2mj.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Marc Zyngier writes: > Hi Saravana, > > On Wed, 04 Aug 2021 22:43:29 +0100, > Saravana Kannan wrote: >> >> This patch series was started due to -EPROBE_DEFER not being handled >> correctly in mdio_mux_init() and causing issues [1]. While at it, I also >> did some more error handling fixes and clean ups. The -EPROBE_DEFER fix is >> the last patch. >> >> Ideally, in the last patch we'd treat any error similar to -EPROBE_DEFER >> but I'm not sure if it'll break any board/platforms where some child >> mdiobus never successfully registers. If we treated all errors similar to >> -EPROBE_DEFER, then none of the child mdiobus will work and that might be a >> regression. If people are sure this is not a real case, then I can fix up >> the last patch to always fail the entire mdio-mux init if any of the child >> mdiobus registration fails. >> >> Cc: Marc Zyngier >> Cc: Neil Armstrong >> Cc: Kevin Hilman >> [1] - https://lore.kernel.org/lkml/CAGETcx95kHrv8wA-O+-JtfH7H9biJEGJtijuPVN0V5dUKUAB3A@mail.gmail.com/#t >> >> Saravana Kannan (3): >> net: mdio-mux: Delete unnecessary devm_kfree >> net: mdio-mux: Don't ignore memory allocation errors >> net: mdio-mux: Handle -EPROBE_DEFER correctly >> >> drivers/net/mdio/mdio-mux.c | 37 ++++++++++++++++++++++++------------- >> 1 file changed, 24 insertions(+), 13 deletions(-) > > Thanks for this. I've just gave it a go on my test platform, and this > indeed addresses the issues I was seeing [1]. > > Acked-by: Marc Zyngier > Tested-by: Marc Zyngier I wasn't seeing the same issues as Marc, but am heavily using everything as modules on a few platforms using this code, and I'm not seeing any regressions. Thanks Saravana for finding the root cause here. Acked-by: Kevin Hilman Signed-off-by: Kevin Hilman Kevin