From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09C4BC433B4 for ; Mon, 19 Apr 2021 18:22:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C30D761246 for ; Mon, 19 Apr 2021 18:22:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240891AbhDSSW3 (ORCPT ); Mon, 19 Apr 2021 14:22:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240833AbhDSSWY (ORCPT ); Mon, 19 Apr 2021 14:22:24 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A97EFC06174A for ; Mon, 19 Apr 2021 11:21:54 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id u15so9655167plf.10 for ; Mon, 19 Apr 2021 11:21:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=DKBt0bp0TTUgQvWPxoeal8fGy3PXdZiGA8cPBtHBn2U=; b=IDPh+v7Nlj5LhsRlTw3r13uDJHgp7ZoeNXF689zP+Jx/mhY0EMgT6B4RFBPpENQBs1 pvFpZ3FT4+m74+Zna3vdjvvi44xLqs9JqR6Ob3blEJOlFXF5luVSq1IwRmGVayZG9hoP H8Wc+TCBmdTru7S/n9qTN0hR2XRUjzvw2zKsyq4jLySVNQXDZDQUXiNdBhw7e8iUKsr0 Kx3a9CEqgL68OnwzDa1D6gNK0YEnSW2OK0P7ALk9yxRDITzaB80REEMOfHrgfJa2bNP8 gdwKuxEtlxj4xnNYrpIsJvkdFAyYMN/9zBbqQEsFN7pUvIwShRRs3SE/WohQ5GdSNeU6 xBew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=DKBt0bp0TTUgQvWPxoeal8fGy3PXdZiGA8cPBtHBn2U=; b=e8e4XekSzmauWCJitw9rhZKMIIcOgOM0yvc0A4EzBwCqOKvHKApiExiqEc/nzvtUrn L4LT/9K/v2yvnLoeiHzuG+UnxxsftMLv9Nw9wf4MOpQrW5RxI5246N271v+q/Uxtn1s4 NVm0PKFi5aXp2NrLUbAlYjIbPvBbyrxsFFOkCRTMY8vfT7lgRD+HaHTsslZHchAFbJcr eKTkmTD4uIQHDy7GDIdyIkuSh7nO4k7rP1AxuaHnRQu90909ChvzwINFpNjOztn77bNk nHCZigvIVDTWYozfu+0n5av/DdWSpDzwJg4DYUYifHRqUx1E73fUeX1D3tYigAyg8dRE mvfA== X-Gm-Message-State: AOAM533h1NCENEFzIsW1kpc3pumGwkCY+lPQ6EAwbWZlEP6aNVF+1UgP R1dwjq+IQgRxFZrSCTnKlVymHQ== X-Google-Smtp-Source: ABdhPJySTiB62+fr1hP716taw9mSevM+JdM2Cz6AlKimXZ/yP3GxW7LcSVLAYU9+u/SZ9eGusKkFTg== X-Received: by 2002:a17:90a:bb94:: with SMTP id v20mr419834pjr.144.1618856514155; Mon, 19 Apr 2021 11:21:54 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id b7sm12900585pfi.42.2021.04.19.11.21.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 11:21:53 -0700 (PDT) From: Kevin Hilman To: Neil Armstrong , hverkuil-cisco@xs4all.nl Cc: linux-media@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Neil Armstrong Subject: Re: [PATCH] media: meson-ge2d: fix rotation parameters In-Reply-To: <20210412134833.3467694-1-narmstrong@baylibre.com> References: <20210412134833.3467694-1-narmstrong@baylibre.com> Date: Mon, 19 Apr 2021 11:21:53 -0700 Message-ID: <7hh7k2xhha.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Neil Armstrong writes: > With these settings, 90deg and 270deg rotation leads to inverted > vertical, fix them to have correct rotation. > > Fixes: 59a635327ca7 ("media: meson: Add M2M driver for the Amlogic GE2D Accelerator Unit") > Signed-off-by: Neil Armstrong Reviewed-by: Kevin Hilman > --- > drivers/media/platform/meson/ge2d/ge2d.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/meson/ge2d/ge2d.c b/drivers/media/platform/meson/ge2d/ge2d.c > index 153612ca96fc..a1393fefa8ae 100644 > --- a/drivers/media/platform/meson/ge2d/ge2d.c > +++ b/drivers/media/platform/meson/ge2d/ge2d.c > @@ -757,7 +757,7 @@ static int ge2d_s_ctrl(struct v4l2_ctrl *ctrl) > > if (ctrl->val == 90) { > ctx->hflip = 0; > - ctx->vflip = 0; > + ctx->vflip = 1; > ctx->xy_swap = 1; > } else if (ctrl->val == 180) { > ctx->hflip = 1; > @@ -765,7 +765,7 @@ static int ge2d_s_ctrl(struct v4l2_ctrl *ctrl) > ctx->xy_swap = 0; > } else if (ctrl->val == 270) { > ctx->hflip = 1; > - ctx->vflip = 1; > + ctx->vflip = 0; > ctx->xy_swap = 1; > } else { > ctx->hflip = 0; > -- > 2.25.1