From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752030AbdHGVoE (ORCPT ); Mon, 7 Aug 2017 17:44:04 -0400 Received: from mail-pg0-f42.google.com ([74.125.83.42]:36468 "EHLO mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751743AbdHGVoC (ORCPT ); Mon, 7 Aug 2017 17:44:02 -0400 From: Kevin Hilman To: Jerome Brunet Cc: Ulf Hansson , Carlo Caione , linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/14] mmc: meson-gx: driver fixups and upgrade Organization: BayLibre References: <20170804174353.16486-1-jbrunet@baylibre.com> <1502124502.2759.32.camel@baylibre.com> Date: Mon, 07 Aug 2017 14:44:00 -0700 In-Reply-To: <1502124502.2759.32.camel@baylibre.com> (Jerome Brunet's message of "Mon, 07 Aug 2017 18:48:22 +0200") Message-ID: <7hshh3njdr.fsf@baylibre.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jerome Brunet writes: > On Fri, 2017-08-04 at 19:43 +0200, Jerome Brunet wrote: >> The patchset features several bugfixes, rework and upgrade for the >> meson-gx MMC driver. >> >> The main goal is to improve readability and enable new high speed >> modes, such as eMMC DDR52 and sdcard UHS modes up to SDR50 (100Mhz) >> >> While full speed SDR104 is stable with most cards, a few seems to >> require an even more precise tuning. For this, we'll probably have >> to implement per-line delay calibration. >> >> This series has been tested on gxbb-p200, gxbb-nanopi-k2 and >> gxl-s905x-libretech >> > > Ulf, Kevin, > > Please ignore this series. I'll resend it soon > > I've discovered new things around the tuning capabilities of the SoC. > I'll probably rework the tuning function again. > > Sorry for the noise No worries, I had a couple very minor comments on some individual patches. Other than that, LGTM. Feel free to add: Reviewed-by: Kevin Hilman to anything that doesn't need major rework. Also, You might want to separate out the fixups/cleanups from the voltage/clock changes stuff. Kevin