From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A18DC43603 for ; Fri, 6 Dec 2019 00:58:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C32652075C for ; Fri, 6 Dec 2019 00:58:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="XKCWfMb4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726175AbfLFA6g (ORCPT ); Thu, 5 Dec 2019 19:58:36 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:40878 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726034AbfLFA6f (ORCPT ); Thu, 5 Dec 2019 19:58:35 -0500 Received: by mail-pf1-f195.google.com with SMTP id q8so2426450pfh.7 for ; Thu, 05 Dec 2019 16:58:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=7Hnuh/lhbaWi78zw47f4T7dSKS95Ee02qVxYEAo3AJs=; b=XKCWfMb4QVNiufc2OLqSEvsCeB+7bLRHN20uFBfrt59dBJT/SgzoA6qehPcrONCMWv qYLqZqHgkEjBtbRaeNMdK0TkNzNNq36de60MThmXWCSLKuBbgMM/ctmNkfWCq1xOMrzw YOP2KjaFZ41eDvZ17cDg27xpENCOq4fg6UJZBpNri7lNrSXYCIJ5ETnSO42yELksrhPD Rex8eS7cHn46wU7whzIAXg2Xj82jorofAiQKypMqsp2/hzBu89J4beD9lmQolbq9K4/2 CEYZ1ZlIj+QEgAgiV0sDR/IqfObtRKHLemeMfnBcApAD/N8cgg3ryxIGb1nHxo4SGqGC kwgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=7Hnuh/lhbaWi78zw47f4T7dSKS95Ee02qVxYEAo3AJs=; b=LkVY/HYr6WDi/69k8a6S5cMzadZkOKYrA6N/12u3Rjh0RY2BURN9FGEsN/jSp6bWWw F7j4W3D/Gx98T9SB6sHm589197s+6K1SKdXKYM5o201PFwebuDSEMJgUhdbtaN0uIC3x bsUfq10/FRD4skAGiuPUoEaIOFmU9g92ceSFpztqEjp0KMuZAjm5NTVvl9XpVmH37tLI T2XgHKYh1K6AePrYeTQxSALnS+Ic1ToKd1M5ddwllGjTMjMNlKt2l1Q80BvoknMYscem O6OdW8/j2f9rllJm7b0xFDpXmWGBZyTXfiCzKNnB0TmaWeaoJC3bh7ei24KjXU6Y2UQq Nokg== X-Gm-Message-State: APjAAAVKpnc73uN2vgg9vz50A2wc097dVVvGagDO9a7DDM4bo4clrlV5 Kl9HZsXTKRD/RQ/d6BCgd2PnDA== X-Google-Smtp-Source: APXvYqxr+lwRkxpfc0ZURjTqY+KCamdHypKJniTnQq5FbwwNIkUC38xRGVONLHE4KLCVnUBmRLoPlg== X-Received: by 2002:a62:87c5:: with SMTP id i188mr11903453pfe.52.1575593915169; Thu, 05 Dec 2019 16:58:35 -0800 (PST) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id d6sm875807pju.8.2019.12.05.16.58.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Dec 2019 16:58:34 -0800 (PST) From: Kevin Hilman To: Guillaume La Roque , marcel@holtmann.org, johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] bluetooth: hci_bcm: enable IRQ capability from node In-Reply-To: <20191204161239.16653-1-glaroque@baylibre.com> References: <20191204161239.16653-1-glaroque@baylibre.com> Date: Thu, 05 Dec 2019 16:58:34 -0800 Message-ID: <7hv9qu2rt1.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Guillaume La Roque writes: > Actually IRQ can be found from GPIO but all platorms don't support nit: s/platorms/platforms/ > gpiod_to_irq, it's the case on amlogic chip. > so to have possibility to use interrupt mode we need to add interrupts > field in node and support it in driver. > > Signed-off-by: Guillaume La Roque > --- > sorry for noise, > > v2 is for rebasing on master branch > > guillaume > > drivers/bluetooth/hci_bcm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c > index f8f5c593a05c..9f52d57c56de 100644 > --- a/drivers/bluetooth/hci_bcm.c > +++ b/drivers/bluetooth/hci_bcm.c > @@ -1409,6 +1409,7 @@ static int bcm_serdev_probe(struct serdev_device *serdev) > { > struct bcm_device *bcmdev; > const struct bcm_device_data *data; > + struct platform_device *pdev; > int err; > > bcmdev = devm_kzalloc(&serdev->dev, sizeof(*bcmdev), GFP_KERNEL); > @@ -1421,6 +1422,8 @@ static int bcm_serdev_probe(struct serdev_device *serdev) > #endif > bcmdev->serdev_hu.serdev = serdev; > serdev_device_set_drvdata(serdev, bcmdev); > + pdev = to_platform_device(bcmdev->dev); > + bcmdev->irq = platform_get_irq(pdev, 0); I don't know this driver well enough to be sure, but don't you need some error checking here? If this fails (on platforms with no IRQ defined), is an error code in bcmdev->irq going to affect later code that tries to setup IRQs? Kevin