From: Kevin Hilman <khilman@kernel.org>
To: Simon Horman <horms@verge.net.au>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
Magnus Damm <magnus.damm@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
LAK <linux-arm-kernel@lists.infradead.org>
Subject: Re: Possible regression due to "hrtimer: Get rid of hrtimer softirq"
Date: Fri, 08 May 2015 10:14:52 -0700 [thread overview]
Message-ID: <7hvbg3gfeb.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20150507132543.GA14889@verge.net.au> (Simon Horman's message of "Thu, 7 May 2015 22:25:43 +0900")
Simon Horman <horms@verge.net.au> writes:
> Hi Thomas,
>
> On Thu, May 07, 2015 at 02:35:59PM +0200, Thomas Gleixner wrote:
>> On Thu, 7 May 2015, Simon Horman wrote:
>> > ------------[ cut here ]------------
>> > kernel BUG at kernel/irq_work.c:135!
>>
>> BUG_ON(!irqs_disabled());
>>
>> So something enables interrupts in the periodic tick handling
>> machinery. Seems you have high resolution timers disabled, but nohz
>> enabled. And that code path has a local_irq_disable/enable pair which
>> causes havoc. Patch below.
>
> Thanks for your quick response. I have been able to confirm that
> when applied on top of next-20150507 the problem I observed no longer
> manifests. I have successfully tested it on all the boards
> where I previously observed a problem.
>
> If you are planning to formally submit the patch below feel free to add:
>
> Tested-by: Simon Horman <horms+renesas@verge.net.au>
FWIW, I confirmed this fixed a boot hang on my kzm9d in next-20150507
also.
Tested-by: Kevin Hilman <khilman@linaro.org>
next prev parent reply other threads:[~2015-05-08 17:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 11:17 Possible regression due to "hrtimer: Get rid of hrtimer softirq" Simon Horman
2015-05-07 12:35 ` Thomas Gleixner
2015-05-07 13:25 ` Simon Horman
2015-05-08 17:14 ` Kevin Hilman [this message]
2015-05-08 9:25 ` [tip:timers/core] nohz: Fix !HIGH_RES_TIMERS hang tip-bot for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hvbg3gfeb.fsf@deeprootsystems.com \
--to=khilman@kernel.org \
--cc=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).