From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D865FC3F2C6 for ; Sat, 29 Feb 2020 16:55:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB6BD2073D for ; Sat, 29 Feb 2020 16:55:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="ZDfEfSIb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727393AbgB2Qzo (ORCPT ); Sat, 29 Feb 2020 11:55:44 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:32857 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727220AbgB2Qzo (ORCPT ); Sat, 29 Feb 2020 11:55:44 -0500 Received: by mail-wr1-f66.google.com with SMTP id x7so7197678wrr.0 for ; Sat, 29 Feb 2020 08:55:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=d/eDOfaq0VJ/SLOUD8o7N9AIT3f4AtWAyVbS0HbmA+Y=; b=ZDfEfSIbwFOP6KOSjbayNzj2YbEZkQX6Z41YrmSJXwXfIh4gcrTrC0ucxSb/UYemLq 9j5cCBJkMzkTvxX433AP/ieV1mdL1BQJEccbZjHRV5QkQrVpE500qmNZgFUHIJ/wRWJO X6SQfLREWXeMkvz104rKMdxzDeIup0/o0ASv3tTmCBoWnqWrqyT5vrf9a21vuMGfldQt Ge9ByOggpCLLbHQ5ykfL+5aivVBTM0k8ro5eOMSpz7qA9F5MiWXKn5MY6N5W8crsCrDn pQDEBa+Fto/kFy+CaM2qOroDjpISsdzWG3vtB9T5Igz5ZbFx/lG5P6a66rKemJ0IFjd7 gJ3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=d/eDOfaq0VJ/SLOUD8o7N9AIT3f4AtWAyVbS0HbmA+Y=; b=Dy0rh52KiFWNff30IXzt4KwQXMFxKZbmPOCbiM158+Ab0bNlwHvsWFW9SXCpQJtI4x CFVL2IaAB11nZGlk/W0LkNCcOhNuqiqnFJPMTHyh+L+iexitUBtrQTmAqA7NTXCyOAbe NbwaJ2DTiqdyptS0UhW51ePJfzt8rlyMkN5cKeUvLWCtE14R9nUxfQ7OPkWsR1iLR9XO RAnG2sSNJWdxP5hBrpjepYUJ32vPvfFkPyN+AD/Wp5llNxRuNG1v6buidE01oz1cQ/0Q aJWGEAuDrUSi4NgGnRaYkLxmD1B7+zxAC1N2F5kCpiXVEQ21iGAT/O15b8oWrEqqoX/L ilRQ== X-Gm-Message-State: APjAAAXb6LkHeRIk948REWggjMcbYsac1+tA7taC6OjQOHiSPm3gBrJu KU1BBAk7dfZUq6waIpO3f9CDh0LS4zOM7w== X-Google-Smtp-Source: APXvYqwKHZ29xYaYamtjaiSWnMeUqe2YZDrHRDyBGKpmsUJX9UY0hoeQvKhbYqqayRN0+5Hv35ysoQ== X-Received: by 2002:adf:f58c:: with SMTP id f12mr10964595wro.22.1582995334791; Sat, 29 Feb 2020 08:55:34 -0800 (PST) Received: from localhost (229.3.136.88.rev.sfr.net. [88.136.3.229]) by smtp.gmail.com with ESMTPSA id d63sm6703261wmd.44.2020.02.29.08.55.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 29 Feb 2020 08:55:34 -0800 (PST) From: Kevin Hilman To: Stephen Rothwell , Carlo Caione Cc: Jianxin Pan , linux-amlogic@lists.infradead.org, Rob Herring , "Neil Armstrong" , Jerome Brunet , Martin Blumenstingl , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, "Jian Hu" , Hanjie Lin , Victor Wan , Xingyu Chen Subject: Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM In-Reply-To: <20200224101654.530f1837@canb.auug.org.au> References: <1581955933-69832-1-git-send-email-jianxin.pan@amlogic.com> <20200218080743.07e58c6e@canb.auug.org.au> <20200218092229.0448d266@canb.auug.org.au> <20200224101654.530f1837@canb.auug.org.au> Date: Sat, 29 Feb 2020 17:55:32 +0100 Message-ID: <7hzhd19vuj.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stephen Rothwell writes: > Hi all, > > On Tue, 18 Feb 2020 09:22:29 +1100 Stephen Rothwell wrote: >> >> On Tue, 18 Feb 2020 08:07:43 +1100 Stephen Rothwell wrote: >> > >> > On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan wrote: >> > > >> > > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure: >> > > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on': >> > > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call' >> > > >> > > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS. >> > > >> > > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller") >> > > >> > > Reported-by: kbuild test robot >> > > Reported-by: patchwork-bot+linux-amlogic >> > > Reported-by: Stephen Rothwell >> > > Signed-off-by: Jianxin Pan >> > > --- >> > > drivers/soc/amlogic/Kconfig | 2 +- >> > > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > I will apply that patch to linux-next today. >> >> This fixes the build for me. >> >> Tested-by: Stephen Rothwell >> >> Also, please keep the commit message tags together at the end of the >> commit message i.e. remove the blank line after the Fixes: tag above. >> (see "git interpret-trailers ") > > I am still applying this patch ... I've fixed up the trailer whitespace an queued this up now, so should show up in linux next shortly. Kevin