From: Junio C Hamano <junio@pobox.com>
To: Mathieu Segaud <mathieu.segaud@regala.cx>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, sct@redhat.com,
Mathieu Segaud <mathieu.segaud@regala.cx>
Subject: Re: [PATCH] Convert ext4_ioctl to an unlocked_ioctl
Date: Thu, 24 Jan 2008 22:35:16 -0800 [thread overview]
Message-ID: <7vir1i76qj.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1201007375-27914-2-git-send-email-mathieu.segaud@regala.cx> (Mathieu Segaud's message of "Tue, 22 Jan 2008 14:09:34 +0100")
Mathieu Segaud <mathieu.segaud@regala.cx> writes:
> Signed-off-by: Mathieu Segaud <mathieu.segaud@regala.cx>
> ---
> fs/ext4/dir.c | 2 +-
> fs/ext4/file.c | 2 +-
> fs/ext4/ioctl.c | 161 ++++++++++++++++++++++++++++++++---------------
> include/linux/ext4_fs.h | 3 +-
> 4 files changed, 112 insertions(+), 56 deletions(-)
>
> diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c
> index f612bef..8f6677a 100644
> --- a/fs/ext4/dir.c
> +++ b/fs/ext4/dir.c
> @@ -42,7 +42,7 @@ const struct file_operations ext4_dir_operations = {
> .llseek = generic_file_llseek,
> .read = generic_read_dir,
> .readdir = ext4_readdir, /* we take BKL. needed?*/
> - .ioctl = ext4_ioctl, /* BKL held */
> + .unlocked_ioctl = ext4_ioctl, /* BKL held */
Wasn't the purpose of this whole exercise to eventually allow
them to be outside BKL? IOW, don't you want to drop this
comment for the .unlocked_ioctl member of this struct?
next prev parent reply other threads:[~2008-01-25 6:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 13:09 [RESENT] Fix previously extX_ioctl() patches Mathieu Segaud
2008-01-22 13:09 ` [PATCH] Convert ext4_ioctl to an unlocked_ioctl Mathieu Segaud
2008-01-22 13:09 ` [PATCH] Convert ext3_ioctl() " Mathieu Segaud
2008-01-25 6:35 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-01-17 12:37 [PATCH] Convert EXT2 to use unlocked_ioctl Mathieu Segaud
2008-01-17 12:37 ` [PATCH] Convert ext3_ioctl() to an unlocked_ioctl Mathieu Segaud
2008-01-17 12:37 ` [PATCH] Convert ext4_ioctl " Mathieu Segaud
2008-01-17 23:50 ` Mathieu SEGAUD
2008-01-17 10:30 [PATCH] Convert EXT2 to use unlocked_ioctl Mathieu Segaud
2008-01-17 10:30 ` [PATCH] Convert ext3_ioctl() to an unlocked_ioctl Mathieu Segaud
2008-01-17 10:30 ` [PATCH] Convert ext4_ioctl " Mathieu Segaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vir1i76qj.fsf@gitster.siamese.dyndns.org \
--to=junio@pobox.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.segaud@regala.cx \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).