From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, Olof Johansson <olof@lixom.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [GIT PULL 05/11] SoC-level changes for tegra and omap
Date: Tue, 10 Jan 2012 16:15:42 -0800 [thread overview]
Message-ID: <7vty438575.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CA+55aFw15sw0PWtom88vJx1M45CLuvpZABQAxMOQ+xowz8Xq2A@mail.gmail.com> (Linus Torvalds's message of "Tue, 10 Jan 2012 08:08:56 -0800")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Tue, Jan 10, 2012 at 12:39 AM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
>>
>> What about using -C instead (which implies -M, but also detects copies) ?
>
> I don't mind -C. It sometimes causes differences to what I see by
> default, but those differences are often interesting.
>
> But while it's interesting and relevant (unlike the non-rename patch
> that is just noisy), it also can hide lots of lines. With -C, you can
> get a diffstat that is actually fairly small, but that adds a lot of
> lines to the kernel (because somebody just copied large files with
> small changes), and if that happens I do want to see it as a "big
> change". So for me, the plain "just show renames" is a good default.
>
> So there is absolutely nothing wrong with -C. It's not what I use, but
> when I see that the diffstats don't match, it's easy to notice why,
> and that information is often fairly interesting, so I don't mind.
How about encouraging people to use stock "git request-pull" instead?
Then best/better practices can be captured as improvement patches to it,
instead of being spread as updates to many people's homebrew scripts, no?
next prev parent reply other threads:[~2012-01-11 0:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 22:12 [GIT PULL 00/11] arm-soc changes Arnd Bergmann
2012-01-09 22:12 ` [GIT PULL 01/11] Non-critical bug fixes Arnd Bergmann
2012-01-09 22:12 ` [GIT PULL 02/11] Cleanups on various subarchitectures Arnd Bergmann
2012-01-09 22:12 ` [GIT PULL 03/11] Device tree conversions for samsung and tegra Arnd Bergmann
2012-01-09 22:12 ` [GIT PULL 04/11] Cleanups for the Samsung platforms Arnd Bergmann
2012-01-09 22:12 ` [GIT PULL 05/11] SoC-level changes for tegra and omap Arnd Bergmann
2012-01-09 22:37 ` Linus Torvalds
2012-01-10 8:39 ` Russell King - ARM Linux
2012-01-10 16:08 ` Linus Torvalds
2012-01-11 0:15 ` Junio C Hamano [this message]
2012-01-11 18:12 ` Arnd Bergmann
2012-01-11 20:29 ` Geert Uytterhoeven
2012-01-11 21:53 ` Nicolas Pitre
2012-01-11 23:21 ` Linus Torvalds
2012-01-12 6:32 ` Geert Uytterhoeven
2012-01-12 6:41 ` Linus Torvalds
2012-01-09 22:12 ` [GIT PULL 06/11] Board-level changes Arnd Bergmann
2012-01-09 22:12 ` [GIT PULL 07/11] New feature development Arnd Bergmann
2012-01-09 22:12 ` [GIT PULL 08/11] Driver specific changes Arnd Bergmann
2012-01-09 22:12 ` [GIT PULL 09/11] power management changes for omap and imx Arnd Bergmann
2012-01-09 22:12 ` [GIT PULL 10/11] timer changes for msm Arnd Bergmann
2012-01-09 22:12 ` [GIT PULL 11/11] clock management changes for i.MX Arnd Bergmann
2012-01-09 22:55 ` [GIT PULL 00/11] arm-soc changes Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vty438575.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).