From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF943C77B61 for ; Thu, 27 Apr 2023 13:14:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243717AbjD0NOz (ORCPT ); Thu, 27 Apr 2023 09:14:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243673AbjD0NOx (ORCPT ); Thu, 27 Apr 2023 09:14:53 -0400 Received: from wnew1-smtp.messagingengine.com (wnew1-smtp.messagingengine.com [64.147.123.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7331930C5; Thu, 27 Apr 2023 06:14:50 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 466552B06760; Thu, 27 Apr 2023 09:14:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 27 Apr 2023 09:14:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1682601283; x=1682608483; bh=kD 00qCtOfk3PbNYqRHdOJ0AiVNKigJdl3uCFID5G/aY=; b=Mz6hYz2W5BfmPu0zkL xk9jUjefighREaUKRO/5rGPPwflA6bc14vnmu2w5I+rcNZAHGWEVDqykFsIqHQbd Y6dlHxwr5DBu4JGctPJJ3yVqCT+ESy1W3y5UNrRgw56OA3mCA1JYkEks4PTIbY8T U/YJ64/CgophUX+xL2RAldvo8HChwgod0K9ZgX1L6IAD+jJBe7IYH33+tDDiHViw nupD7tTSSI6q1AvEEOlW28S9DttGzwNkgI9G2YWcBeTS/mnhO/2TnPVeaWIkE2IG HubawSdaIVjw66Yf0sWKOu4TJy9ss11qLB+hNwV/kaT1jRxYaLm9bcXi32seMZz0 sofQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1682601283; x=1682608483; bh=kD00qCtOfk3Pb NYqRHdOJ0AiVNKigJdl3uCFID5G/aY=; b=ErA++GpS9heKXOKVvv80Y78uKPjIu NH8qTo+6WynzCiUwajbKBO6uT9626bnmomP4hokwjvVAIPCGQrX2Czs6acG64HTi dSFyWbYP+flNExxc/EwlVWXm6wzJPIH0V1YsRlpl6N2eb0haCUEBne6GgzhSms/U 2ZhPb3PwsLBEDVQ4L71bfXC8G659q4BGZqTYaaBDQjW1ObZbyPsco28ct/jTMfa8 FHB5fGn8Zy6ie2FHtT5ycwxh2HofnKxJmjevjbmxK50bsyCV9WzW3P3fXtAn1IgO KnWiHfZjCyqSrnICDEgLjtDdV1mvQ9Ru8l8+6+vW0rAQMSrtGlZ5AlFtQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeduiedgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtsfertddtudenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeefjeeiueeiheevtddvgfeluedufeeigeeijefhveelfeevueefieehuefg ffetteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 27 Apr 2023 09:14:41 -0400 (EDT) Date: Thu, 27 Apr 2023 15:14:39 +0200 From: Maxime Ripard To: =?utf-8?B?TWHDrXJh?= Canal , David Gow , Daniel Latypov , brendanhiggins@google.com Cc: Isabella Basso , magalilemes00@gmail.com, tales.aparecida@gmail.com, mwen@igalia.com, andrealmeid@riseup.net, siqueirajordao@riseup.net, Trevor Woerner , leandro.ribeiro@collabora.com, n@nfraprado.net, Daniel Vetter , Shuah Khan , David Airlie , Thomas Zimmermann , michal.winiarski@intel.com, Javier Martinez Canillas , =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Arthur Grillo Subject: Re: [PATCH v5 9/9] drm: selftest: convert drm_mm selftest to KUnit Message-ID: <7yc3fkagtlr4i7qnkulwvfzqjs7v64ddugcc3cxt6g5oawvqoa@ax67ukkrr7jt> References: <20220708203052.236290-1-maira.canal@usp.br> <20220708203052.236290-10-maira.canal@usp.br> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uwsquh22deiiaohx" Content-Disposition: inline In-Reply-To: <20220708203052.236290-10-maira.canal@usp.br> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --uwsquh22deiiaohx Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Jul 08, 2022 at 05:30:52PM -0300, Ma=EDra Canal wrote: > From: Arthur Grillo >=20 > Considering the current adoption of the KUnit framework, convert the > DRM mm selftest to the KUnit API. >=20 > Signed-off-by: Arthur Grillo > Tested-by: David Gow > Acked-by: Daniel Latypov > Reviewed-by: Javier Martinez Canillas > Signed-off-by: Ma=EDra Canal I'm very late to the party, but I'd like to discuss that patch some more. Two tests (drm_test_mm_reserve, drm_test_mm_insert) in it take a super long time to run (about 30s each on my machine). If we run all the DRM tests and VC4 tests, each of those two are longer to run than all the ~300 tests combined. About 100 times longer. I don't think that running for so long is reasonable, and for multiple reasons: - While I don't know drm_mm well, it doesn't look like any of those tests do something that really should take this long. I'm especially skeptical about the fact that we test each operation 8192 times by default. - It makes using kunit more tedious than it should be. Like I said, on a very capable machine, running the all the DRM and VC4 tests takes about 50s with those two tests, ~0.4s without. - The corollary is that it will get in the way of people that really want to use kunit will just remove those tests before doing so, defeating the original intent. I understand that it came from selftests initially, but I think we should rewrite the tests entirely to have smaller, faster tests. It's not clear to me why those tests are as complicated as they are though. Also, going forward we should probably put disencourage tests running that long. Could Kunit timeout/warn after a while if a test is taking more than X seconds to run? Maxime --uwsquh22deiiaohx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZEp1PwAKCRDj7w1vZxhR xZb5AQCaxNd1KOuvPksm5yR9miZ4Ahbm8VgMYLVdiUFWcuI6qQEAi3Bnj0sJPHcE KsVuqZ8Ykbx805ymp4NScJYexkW79gU= =CnRS -----END PGP SIGNATURE----- --uwsquh22deiiaohx--