From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, linux-arm-kernel@lists.infradead.org,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Jann Horn <jannh@google.com>, Kees Cook <keescook@chromium.org>,
Jessica Yu <jeyu@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/2] bpf: add __weak hook for allocating executable memory
Date: Thu, 22 Nov 2018 22:08:00 +0100 [thread overview]
Message-ID: <800264DE-658A-46B4-8FA1-CD1CF314AA7A@linaro.org> (raw)
In-Reply-To: <201811230404.yavKPUOn%fengguang.wu@intel.com>
> On 22 Nov 2018, at 21:01, kbuild test robot <lkp@intel.com> wrote:
>
> Hi Ard,
>
> I love your patch! Yet something to improve:
>
Ugh, apologies for this. I’m sure i build tested /something/ but clearly not what i should have tested.
In any case, following up on the discussion I’ll have to respin this in any case. I’ll triple check next time that what i send out was tested properly.
> [auto build test ERROR on bpf-next/master]
> [also build test ERROR on v4.20-rc3 next-20181122]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Ard-Biesheuvel/bpf-permit-JIT-allocations-to-be-served-outside-the-module-region/20181123-033144
> base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
> config: x86_64-randconfig-x002-201846 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All error/warnings (new ones prefixed by >>):
>
> kernel//bpf/core.c: In function 'bpf_jit_free_exec':
>>> kernel//bpf/core.c:632:24: error: 'size' undeclared (first use in this function); did you mean 'ksize'?
> return module_memfree(size);
> ^~~~
> ksize
> kernel//bpf/core.c:632:24: note: each undeclared identifier is reported only once for each function it appears in
>>> kernel//bpf/core.c:632:9: warning: 'return' with a value, in function returning void
> return module_memfree(size);
> ^~~~~~~~~~~~~~
> kernel//bpf/core.c:630:13: note: declared here
> void __weak bpf_jit_free_exec(const void *addr)
> ^~~~~~~~~~~~~~~~~
>
> vim +632 kernel//bpf/core.c
>
> 629
> 630 void __weak bpf_jit_free_exec(const void *addr)
> 631 {
>> 632 return module_memfree(size);
> 633 }
> 634
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
> <.config.gz>
next prev parent reply other threads:[~2018-11-22 21:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 13:17 [PATCH v2 0/2] bpf: permit JIT allocations to be served outside the module region Ard Biesheuvel
2018-11-21 13:17 ` [PATCH v2 1/2] bpf: add __weak hook for allocating executable memory Ard Biesheuvel
2018-11-22 20:01 ` kbuild test robot
2018-11-22 21:08 ` Ard Biesheuvel [this message]
2018-11-21 13:17 ` [PATCH v2 2/2] arm64/bpf: don't allocate BPF JIT programs in module memory Ard Biesheuvel
2018-11-21 23:20 ` Daniel Borkmann
2018-11-22 8:02 ` Ard Biesheuvel
2018-11-22 22:49 ` Daniel Borkmann
2018-11-24 2:57 ` kbuild test robot
2018-11-21 19:48 ` [PATCH v2 0/2] bpf: permit JIT allocations to be served outside the module region Edgecombe, Rick P
2018-11-21 20:36 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=800264DE-658A-46B4-8FA1-CD1CF314AA7A@linaro.org \
--to=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jannh@google.com \
--cc=jeyu@kernel.org \
--cc=kbuild-all@01.org \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).