From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754481AbdDLNb5 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 12 Apr 2017 09:31:57 -0400
Received: from mx08-00178001.pphosted.com ([91.207.212.93]:42758 "EHLO
        mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1754410AbdDLNbo (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 12 Apr 2017 09:31:44 -0400
Subject: Re: [PATCH v2 3/7] includes: dt-bindings: Rename STM32F429 pinctrl DT
 bindings
To: Rob Herring <robh@kernel.org>
References: <1491568984-20169-1-git-send-email-alexandre.torgue@st.com>
 <1491568984-20169-4-git-send-email-alexandre.torgue@st.com>
 <20170410202736.zy7naw74hvrdmfzk@rob-hp-laptop>
CC: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>, Arnd Bergmann <arnd@arndb.de>,
        Russell King <linux@armlinux.org.uk>, Olof Johansson <olof@lixom.net>,
        <lee.jones@linaro.org>, Jonathan Corbet <corbet@lwn.net>,
        <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From: Alexandre Torgue <alexandre.torgue@st.com>
Message-ID: <800a68a4-d6ce-212b-5849-56c9d32f891a@st.com>
Date: Wed, 12 Apr 2017 15:31:01 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170410202736.zy7naw74hvrdmfzk@rob-hp-laptop>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.75.127.44]
X-ClientProxiedBy: SFHDAG3NODE3.st.com (10.75.127.9) To SFHDAG3NODE2.st.com
 (10.75.127.8)
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-12_09:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob,

On 04/10/2017 10:27 PM, Rob Herring wrote:
> On Fri, Apr 07, 2017 at 02:43:00PM +0200, Alexandre TORGUE wrote:
>> STM32F4 MCU series is composed of several SOC (STM32F429, STM32F469, ...).
>> Most of muxing definition are identical. So to avoid to duplicate bindings
>> definition, this patch create common definitions.
>
> This is a lot of churn. Some confirmation that the resultant dtb is the
> same before and after would be nice. Perhaps the script you used to
> convert this as well.

I tried to use fdtdump but it seems bugged. So I used directly dtc 
binary to (re)generate dts files (before and after apply the series) and 
I compared "pinmux" field in both case.

Example on stm32f469-disco:

./scripts/dtc/dtc -I dtb -O dts -o stm32f469-disco-after.dts 
stm32f469-disco-after.dtb

./scripts/dtc/dtc -I dtb -O dts -o stm32f469-disco-before.dts 
stm32f469-disco-before.dtb

cat stm32f469-disco-after.dts | grep pinmux
cat stm32f469-disco-before.dts | grep pinmux

regards
alex

>
> Rob
>