From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Dang Huynh <danct12@riseup.net>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Alexey Min <alexey.min@gmail.com>,
Caleb Connolly <caleb@connolly.tech>,
Martin Botka <martin.botka@somainline.org>
Subject: Re: [PATCH v3 8/8] arm64: dts: qcom: sdm660-xiaomi-lavender: Add USB
Date: Thu, 11 Nov 2021 22:40:29 +0100 [thread overview]
Message-ID: <80190e08-0303-be47-9df1-b4367843623f@somainline.org> (raw)
In-Reply-To: <20211111031635.3839947-9-danct12@riseup.net>
On 11.11.2021 04:16, Dang Huynh wrote:
> From: Alexey Min <alexey.min@gmail.com>
>
> Enable and configure DWC3 and QUSB2 PHY to enable USB
> functionality on the Redmi Note 7.
>
> Signed-off-by: Alexey Min <alexey.min@gmail.com>
> Co-developed-by: Dang Huynh <danct12@riseup.net>
> Signed-off-by: Dang Huynh <danct12@riseup.net>
> ---
> .../boot/dts/qcom/sdm660-xiaomi-lavender.dts | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts b/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
> index 712392545c2e..bf7f334b0b5c 100644
> --- a/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
> @@ -80,6 +80,15 @@ framebuffer_mem: memory@9d400000 {
> no-map;
> };
> };
> +
> + /*
> + * Until we hook up type-c detection, we
> + * have to stick with this. But it works.
> + */
> + extcon_usb: extcon-usb {
> + compatible = "linux,extcon-usb-gpio";
> + id-gpio = <&tlmm 58 GPIO_ACTIVE_HIGH>;
> + };
> };
>
> &blsp1_uart2 {
> @@ -96,6 +105,13 @@ &pon_resin {
> linux,code = <KEY_VOLUMEDOWN>;
> };
>
> +&qusb2phy {
> + status = "okay";
> +
> + vdd-supply = <&vreg_l1b_0p925>;
> + vdda-phy-dpdm-supply = <&vreg_l7b_3p125>;
> +};
> +
> &rpm_requests {
> pm660l-regulators {
> compatible = "qcom,rpm-pm660l-regulators";
> @@ -401,3 +417,12 @@ &sdhc_2 {
> &tlmm {
> gpio-reserved-ranges = <8 4>;
> };
> +
> +&usb3 {
> + status = "okay";
> +};
> +
> +&usb3_dwc3 {
> + dr_mode = "peripheral";
> + extcon = <&extcon_usb>;
> +};
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
On a side note, I wonder if any of the more interesting USB-C lanes (say DP out or USB3 [at least for host mode])
are connected on this device..
Konrad
next prev parent reply other threads:[~2021-11-11 21:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 3:16 [PATCH v3 0/8] Improve support for Xiaomi Redmi Note 7 Dang Huynh
2021-11-11 3:16 ` [PATCH v3 1/8] arm64: dts: qcom: sdm630: Assign numbers to eMMC and SD Dang Huynh
2021-11-11 3:16 ` [PATCH v3 2/8] arm64: dts: qcom: sdm630-pm660: Move RESIN to pm660 dtsi Dang Huynh
2021-11-11 21:16 ` Konrad Dybcio
2021-11-11 3:16 ` [PATCH v3 3/8] arm64: dts: qcom: sdm660-xiaomi-lavender: Add RPM and fixed regulators Dang Huynh
2021-11-11 21:33 ` Konrad Dybcio
2021-11-11 3:16 ` [PATCH v3 4/8] arm64: dts: qcom: sdm660-xiaomi-lavender: Add PWRKEY and RESIN Dang Huynh
2021-11-11 21:34 ` Konrad Dybcio
2021-11-11 3:16 ` [PATCH v3 5/8] arm64: dts: qcom: sdm660-xiaomi-lavender: Add volume up button Dang Huynh
2021-11-11 21:36 ` Konrad Dybcio
2021-11-11 3:16 ` [PATCH v3 6/8] arm64: dts: qcom: sdm660-xiaomi-lavender: Add eMMC and SD Dang Huynh
2021-11-11 3:16 ` [PATCH v3 7/8] arm64: dts: qcom: sdm660-xiaomi-lavender: Enable Simple Framebuffer Dang Huynh
2021-11-11 21:38 ` Konrad Dybcio
2021-11-11 3:16 ` [PATCH v3 8/8] arm64: dts: qcom: sdm660-xiaomi-lavender: Add USB Dang Huynh
2021-11-11 21:40 ` Konrad Dybcio [this message]
2021-11-11 9:42 ` [PATCH v3 0/8] Improve support for Xiaomi Redmi Note 7 Marijn Suijten
2021-11-18 20:30 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80190e08-0303-be47-9df1-b4367843623f@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=agross@kernel.org \
--cc=alexey.min@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=caleb@connolly.tech \
--cc=danct12@riseup.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.botka@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).