From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755283AbcEaRAR (ORCPT <rfc822;w@1wt.eu>);
	Tue, 31 May 2016 13:00:17 -0400
Received: from smtprelay.synopsys.com ([198.182.47.9]:36668 "EHLO
	smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751616AbcEaRAN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 31 May 2016 13:00:13 -0400
Subject: Re: [PATCH 3/3] tda998x: add HPD delay to avoid disabling sound when
 EDID checksum fails.
To: Russell King - ARM Linux <linux@armlinux.org.uk>,
        Joao Pinto <Joao.Pinto@synopsys.com>
References: <cover.1464619185.git.jpinto@synopsys.com>
 <2f242f545c99fc604fb70eeffcfd5d7703ace18d.1464619185.git.jpinto@synopsys.com>
 <20160530191044.GR19428@n2100.arm.linux.org.uk>
CC: <linux-kernel@vger.kernel.org>, <ijc+devicetree@hellion.org.uk>,
        <liviu.dudau@arm.com>, <ryan.harkin@linaro.org>
From: Joao Pinto <Joao.Pinto@synopsys.com>
Message-ID: <801ce163-b8ac-3375-56f2-9a8d7cd70ded@synopsys.com>
Date: Tue, 31 May 2016 17:58:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <20160530191044.GR19428@n2100.arm.linux.org.uk>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.13.184.19]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Russell,

On 5/30/2016 8:10 PM, Russell King - ARM Linux wrote:
> On Mon, May 30, 2016 at 04:15:54PM +0100, Joao Pinto wrote:
>> When using ffplay to reproduce video+sound it was noticed that sometimes the
>> sound was disabled. The cause was an initial EDID checksum error that disabled

(...)

>> @@ -1313,6 +1324,7 @@ static int tda998x_create(struct i2c_client *client, struct tda998x_priv *priv)
>>  
>>  		/* init read EDID waitqueue and HDP work */
>>  		init_waitqueue_head(&priv->wq_edid);
>> +		INIT_DELAYED_WORK(&priv->dwork, tda998x_hpd);
>>  
>>  		/* clear pending interrupts */
>>  		reg_read(priv, REG_INT_FLAGS_0);
> 
> Clearly, this patch is incomplete.  There's nothing that schedules this
> work to be run.

You are right, forgot to include the schedule in the patch!

> 
> In any case, this is reintroducing the code which I deleted when I fixed
> the (rather crappy) previous implemention of delaying the EDID read after
> a hotplug event.  You should not need this patch.
> 

If a checksum validation fails the video reproduction is done muted if you use a
simple app like ffplay. This does not happen if using mplayer.

Could you please check the sound support patch?

Thanks,
Joao