From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70EC8C433DB for ; Tue, 2 Feb 2021 18:30:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 401C564F5E for ; Tue, 2 Feb 2021 18:30:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238582AbhBBSaP (ORCPT ); Tue, 2 Feb 2021 13:30:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238573AbhBBSZR (ORCPT ); Tue, 2 Feb 2021 13:25:17 -0500 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4FE9C061788; Tue, 2 Feb 2021 10:24:35 -0800 (PST) Received: by mail-lj1-x233.google.com with SMTP id f19so25115709ljn.5; Tue, 02 Feb 2021 10:24:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Q0T5IJwaSHOziIxSRhbmo9/NktrkYw4HnAHaQWP4KHQ=; b=btzlH3Vxt+/koq/pSPXEBf4bkrneg6wWxrTbVGxN1JyckKHRZZi9ax6r8i/bl6Ir1s IbmB+P0Zd8ho4CqrpMNkanmVY5FxKnQW6K1SN2D2tDtoT+XN5ihVWeOhdrRIoKSLUos/ VWI8LvV5oqS+2GdcBAyxW8i1dSqHHpQCGijGWw3lFWeHmiYW+gR5+/zYzD4T/bzbT7RF TXddshv1tZ3k7C26ZQ2GjagnlW47lhBZ89LWTRkVX0Wko3oCH/j+w3oPkv3buMGeYmAF OeSJisuIoobveQfD6+2xaQmDlKqtiFCm11drAtW4GuFCRIbdZph2ushLX3hx9ws0oCzw ygeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Q0T5IJwaSHOziIxSRhbmo9/NktrkYw4HnAHaQWP4KHQ=; b=O2w8VXbbsNn6/7SZbG9DTrQFrEgBnu1WAyK60V8cxuES30DGNvySgrRAsJZZd3OjFT tcAh0ptGAZdmkqWBSNA3ZMGgp8TRU6+L7SeSQqkm/gjzv2PRYOkah6XhljxjowiSXlrl mgMOn9c+V96eMTNewy0dKFQor4WCnUVuAHlcny52YR1BmOxh4KXY6dGLCCUoQNiLCpUo bIYkzFtSAhH38yZ+lAtgWKIpX5kWngjKqJFehX5olso/hMmXWGwb1dtYX76e/UZGhMGj 6iyayLAvx2fb9Fsp9DXFvuoSwwsI1T6o+IcvUP/YP8RdLmTZ4Car66vc7iUkFNLscntg XrtQ== X-Gm-Message-State: AOAM532nVclP/LRJAGLGl2FhHHW5NweH8zrwjhcMKdmcNosSDSG3C1pn 2WOamOkeg4dyBmVQfPBgXAQd4qegMGK8uA== X-Google-Smtp-Source: ABdhPJxXOkVdvYP3ZgEOCJO6jAENS8rLkK5ge4Pewg6qilVVcGWtdonj61DXmSgCFQE8f1Yhya2/tg== X-Received: by 2002:a2e:9a52:: with SMTP id k18mr13748061ljj.249.1612290273551; Tue, 02 Feb 2021 10:24:33 -0800 (PST) Received: from [192.168.0.131] ([194.183.54.57]) by smtp.gmail.com with ESMTPSA id 19sm4414607ljw.19.2021.02.02.10.24.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Feb 2021 10:24:32 -0800 (PST) Subject: Re: [PATCH v1] leds: lp50xx: add setting of default intensity from DT To: Sven Schuchmann Cc: Pavel Machek , Dan Murphy , Rob Herring , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210119105312.2636-1-schuchmann@schleissheimer.de> From: Jacek Anaszewski Message-ID: <8029565b-9b45-8c2c-cb6a-c639af5780fb@gmail.com> Date: Tue, 2 Feb 2021 19:24:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210119105312.2636-1-schuchmann@schleissheimer.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sven, On 1/19/21 11:53 AM, Sven Schuchmann wrote: > In order to use a multicolor-led together with a trigger > from DT the led needs to have an intensity set to see something. > The trigger changes the brightness of the led but if there > is no intensity we actually see nothing. > > This patch adds the ability to set the default intensity > of each led so that it is turned on from DT. > > Signed-off-by: Sven Schuchmann > --- > Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 8 +++++++- > drivers/leds/leds-lp50xx.c | 4 ++++ > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml > index c192b5feadc7..5ad2a0c3c052 100644 > --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml > +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml > @@ -69,7 +69,12 @@ patternProperties: > patternProperties: > "(^led-[0-9a-f]$|led)": > type: object > - $ref: common.yaml# > + allOf: > + - $ref: common.yaml# > + properties: > + default-intensity: > + maxItems: 1 > + description: The intensity the LED gets initialised with. > > required: > - compatible > @@ -102,6 +107,7 @@ examples: > > led-0 { > color = ; > + default-intensity = <100>; > }; > > led-1 { Please split this into a separate patch, preceding this one in the series. > diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c > index f13117eed976..ba760fa33bdc 100644 > --- a/drivers/leds/leds-lp50xx.c > +++ b/drivers/leds/leds-lp50xx.c > @@ -501,6 +501,10 @@ static int lp50xx_probe_dt(struct lp50xx *priv) > } > > mc_led_info[num_colors].color_index = color_id; > + > + fwnode_property_read_u32(led_node, "default-intensity", > + &mc_led_info[num_colors].intensity); > + > num_colors++; > } > > For this part: Acked-by: Jacek Anaszewski -- Best regards, Jacek Anaszewski