From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 581EAC4332F for ; Tue, 28 Sep 2021 09:50:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F39861052 for ; Tue, 28 Sep 2021 09:50:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240030AbhI1JwQ (ORCPT ); Tue, 28 Sep 2021 05:52:16 -0400 Received: from comms.puri.sm ([159.203.221.185]:57794 "EHLO comms.puri.sm" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239989AbhI1JwN (ORCPT ); Tue, 28 Sep 2021 05:52:13 -0400 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id 102D0DFD66; Tue, 28 Sep 2021 02:50:34 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L3BYOu-rMZEZ; Tue, 28 Sep 2021 02:50:33 -0700 (PDT) Message-ID: <802a27f49cbde7d37179a9dfddca837f096a34b4.camel@puri.sm> Subject: Re: [PATCH v9 0/4] Add support for the Hynix Hi-846 camera From: Martin Kepplinger To: pavel@ucw.cz, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, sakari.ailus@iki.fi Cc: devicetree@vger.kernel.org, kernel@puri.sm, krzysztof.kozlowski@canonical.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, paul.kocialkowski@bootlin.com, phone-devel@vger.kernel.org, robh@kernel.org, shawnx.tu@intel.com Date: Tue, 28 Sep 2021 11:50:25 +0200 In-Reply-To: <20210906102837.2190387-1-martin.kepplinger@puri.sm> References: <20210906102837.2190387-1-martin.kepplinger@puri.sm> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, dem 06.09.2021 um 12:28 +0200 schrieb Martin Kepplinger: > hi, > > This series adds support for the SK Hynix Hi-846 CMOS images sensor. > It includes the dt-bindings and the driver. > > best wishes, > >                               martin hi all, are there any objections, doubts or other thoughts about this that would prevent it from being merged? thanks for all the good review, martin > > revision history > ---------------- > v9: (thank you Pavel and Sakari) > * fix the probe() error paths (that I broke in v8) > * cheanups > > v8: (thank you Laurent) > * add fwnode properties support for orientation and rotation on the > board > * remove the arm64 defconfig addition patch. deal with that later. > * > https://lore.kernel.org/linux-media/20210831134344.1673318-1-martin.kepplinger@puri.sm/ > > v7: (thank you Sakari) > * move the check for supported nr_lanes for a mode to set_format() > * change get_selection() according to the Sakaris' review > * check for the mipi link frequencies from DT > * check for the external clock rate and add assigned-clock-rates > requirement > * > https://lore.kernel.org/linux-media/20210712084137.3779628-1-martin.kepplinger@puri.sm/ > > v6: > * better digital gain defaults > * lane config fix found by smatch > * fix regulator usage in power_on() > * > https://lore.kernel.org/linux-media/20210628101054.828579-1-martin.kepplinger@puri.sm/ > > v5: (thank you Laurent and Rob) > * minor dt-bindings fixes > * driver: disable lens shading correcting (no seed values yet used > from "otp" for that) > * add reviewed-tags > * > https://lore.kernel.org/linux-media/20210611101404.2553818-1-martin.kepplinger@puri.sm/ > > v4: (thank you Laurent, Sakari and Rob) many driver changes, see v3 > review for > details. they include: > * add get_selection(), remove open() callback > * use gpiod API > * use regulator_bulk API > * fix power supply timing sequence and bindings > * > https://lore.kernel.org/linux-media/20210607105213.1211722-1-martin.kepplinger@puri.sm/ > > v3: (thank you, Laurent) > * use do_div() for divisions > * reset-gpios DT property name instead of rst-gpios > * improve the dt-bindings > * add the phone-devel list > * > https://lore.kernel.org/linux-media/20210531120737.168496-1-martin.kepplinger@puri.sm/ > > v2: > sent a bit early due to stupid mistakes > * fix build issues > * fix dtschema issues > * add enable for arm64 defconfig > * > https://lore.kernel.org/linux-media/20210530212337.GA15366@duo.ucw.cz/T/#t > > v1: > * > https://lore.kernel.org/linux-media/20210527091221.3335998-1-martin.kepplinger@puri.sm/ > > > Martin Kepplinger (4): >   dt-bindings: vendor-prefixes: Add SK Hynix Inc. >   dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel >     sensor >   media: i2c: add driver for the SK Hynix Hi-846 8M pixel camera >   Documentation: i2c-cardlist: add the Hynix hi846 sensor > >  .../admin-guide/media/i2c-cardlist.rst        |    1 + >  .../bindings/media/i2c/hynix,hi846.yaml       |  120 + >  .../devicetree/bindings/vendor-prefixes.yaml  |    2 + >  MAINTAINERS                                   |    6 + >  drivers/media/i2c/Kconfig                     |   13 + >  drivers/media/i2c/Makefile                    |    1 + >  drivers/media/i2c/hi846.c                     | 2190 > +++++++++++++++++ >  7 files changed, 2333 insertions(+) >  create mode 100644 > Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml >  create mode 100644 drivers/media/i2c/hi846.c >