From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, kernel@pengutronix.de,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding
Date: Mon, 23 May 2022 00:16:18 +0200 [thread overview]
Message-ID: <80306a31-462c-4ce3-5c54-c0f74ad828f8@pengutronix.de> (raw)
In-Reply-To: <CACRpkdbKUHu-T2whY4wgk5xnR7X-hptEg+Jm5Hudq8ieQi3VwA@mail.gmail.com>
On 22.05.22 23:03, Linus Walleij wrote:
> On Sat, May 21, 2022 at 10:07 PM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>
>> The BCM4349B1 chip is a single-chip Bluetooth 5.0 controller and
>> Transceiver. It is contained in the CYW/BCM89359 WiFi+BT package.
>
> So the BT and the package have two different names.
The package also goes by the name BCM4349B1 apparently.
Cypress support had later confirmed BCM4349B1 and BCM89359 to
be the same chipset. I should probably rephrase the commit message.
>> + - brcm,bcm4349-bt
>
> Then why do you have to tag on "-bt" on this compatible?
>
> That is typically used when the wifi and bt has the *same* name, so
> the only way to distinguish between them is a suffix.
I think that's the case here too.
Cheers,
Ahmad
>
> Yours,
> Linus Walleij
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-05-22 22:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-21 20:07 [PATCH 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding Ahmad Fatoum
2022-05-21 20:07 ` [PATCH 2/2] Bluetooth: hci_bcm: Add BCM4349B1 variant Ahmad Fatoum
2022-05-22 7:40 ` [PATCH 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding Krzysztof Kozlowski
2022-05-22 21:03 ` Linus Walleij
2022-05-22 22:16 ` Ahmad Fatoum [this message]
2022-05-23 8:38 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80306a31-462c-4ce3-5c54-c0f74ad828f8@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).