From: Jens Axboe <axboe@kernel.dk>
To: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: ming.lei@redhat.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V14 0/3] blk-mq: refactor and fix the code of issue directly
Date: Thu, 13 Dec 2018 21:26:58 -0700 [thread overview]
Message-ID: <8035ac66-63a1-b03a-95f8-c11a5482e8d7@kernel.dk> (raw)
In-Reply-To: <1544750900-1549-1-git-send-email-jianchao.w.wang@oracle.com>
On 12/13/18 6:28 PM, Jianchao Wang wrote:
> Hi Jens
>
> After commit c616cbee ( blk-mq: punt failed direct issue to dispatch
> list ), we always insert request to hctx dispatch list whenever get a
> BLK_STS_RESOURCE or BLK_STS_DEV_RESOURCE, this is overkill and will
> harm the merging. We just need to do that for the requests that has
> been through .queue_rq.
>
> This patch set fixes the issue above and refactors the code of issue
> request directly to unify the interface and make the code clearer and
> more readable.
>
> Please consider this patchset for 4.21.
I'll throw this through all the testing tomorrow, looks good to me.
If it passes, I'll add it for 4.21.
--
Jens Axboe
next prev parent reply other threads:[~2018-12-14 4:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 1:28 [PATCH V14 0/3] blk-mq: refactor and fix the code of issue directly Jianchao Wang
2018-12-14 1:28 ` [PATCH V14 1/3] blk-mq: refactor the code of issue request directly Jianchao Wang
2018-12-14 1:28 ` [PATCH V14 2/3] blk-mq: issue directly with bypass 'false' in blk_mq_sched_insert_requests Jianchao Wang
2018-12-14 1:28 ` [PATCH V14 3/3] blk-mq: replace and kill blk_mq_request_issue_directly Jianchao Wang
2018-12-14 4:26 ` Jens Axboe [this message]
2018-12-14 19:33 ` [PATCH V14 0/3] blk-mq: refactor and fix the code of issue directly Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8035ac66-63a1-b03a-95f8-c11a5482e8d7@kernel.dk \
--to=axboe@kernel.dk \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).