linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hau <hau@realtek.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	nic_swsd <nic_swsd@realtek.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting.
Date: Thu, 28 Jul 2016 12:58:44 +0000	[thread overview]
Message-ID: <80377ECBC5453840BA8C7155328B53770143B749@RTITMBSV03.realtek.com.tw> (raw)
In-Reply-To: <20160727221001.GA3338@electric-eye.fr.zoreil.com>

[...]
> > @@ -1852,12 +1863,17 @@ static int rtl8169_set_wol(struct net_device
> *dev, struct ethtool_wolinfo *wol)
> >  		tp->features |= RTL_FEATURE_WOL;
> >  	else
> >  		tp->features &= ~RTL_FEATURE_WOL;
> > -	__rtl8169_set_wol(tp, wol->wolopts);
> > +	if (pm_runtime_active(&pdev->dev))
> > +		__rtl8169_set_wol(tp, wol->wolopts);
> > +	else
> > +		tp->saved_wolopts = wol->wolopts;
> >
> >  	rtl_unlock_work(tp);
> >
> >  	device_set_wakeup_enable(&tp->pci_dev->dev, wol->wolopts);
> >
> > +	pm_runtime_put_noidle(&pdev->dev);
> > +
> >  	return 0;
> 
> Either the driver resumes the device so that it can perform requested
> operation or it signals .set_wol failure when the device is suspended.
> 
> If the driver does something else, "spam removal" translates to "silent
> failure".

Because "tp->saved_wolopts" will be used to set hardware wol capability in rtl8169_runtime_resume().  So I prefer to keep "wol->wolopts" to " tp->saved_wolopts " in runtime suspend state and set this to this "wol->wolopts" to hardware in in rtl8169_runtime_resume(). 

Thanks.

------Please consider the environment before printing this e-mail.

  reply	other threads:[~2016-07-28 12:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-27 16:41 [PATCH net 0/3] r8169:fix 3 runtime pm related issues Chunhao Lin
2016-07-27 16:41 ` [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting Chunhao Lin
2016-07-27 22:10   ` Francois Romieu
2016-07-28 12:58     ` Hau [this message]
2016-07-28 22:13       ` Francois Romieu
2016-07-27 22:18   ` Francois Romieu
2016-07-28 12:59     ` Hau
2016-07-27 16:41 ` [PATCH net 2/3] r8169:add checking driver's runtime pm status in rtl8169_get_ethtool_stats() Chunhao Lin
2016-07-27 16:41 ` [PATCH net 3/3] r8169:fix nic may not work after changing the mac address Chunhao Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80377ECBC5453840BA8C7155328B53770143B749@RTITMBSV03.realtek.com.tw \
    --to=hau@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).