From: Leon Romanovsky <leon@kernel.org>
To: Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@nvidia.com>
Cc: Leon Romanovsky <leonro@nvidia.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
Mark Zhang <markz@mellanox.com>
Subject: [PATCH rdma-next 3/7] RDMA/core: Remove protection from wrong in-kernel API usage
Date: Wed, 21 Jul 2021 09:13:02 +0300 [thread overview]
Message-ID: <8084238e374fe487c3f9728c2ee5ec8736c204d5.1626846795.git.leonro@nvidia.com> (raw)
In-Reply-To: <cover.1626846795.git.leonro@nvidia.com>
From: Leon Romanovsky <leonro@nvidia.com>
The ib_create_named_qp() is kernel verb that is not used for user
supplied attributes. In such case, it is ULP responsibility to provide
valid QP attributes.
In-kernel API shouldn't check it, exactly like other functions that
don't check device capabilities.
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
drivers/infiniband/core/verbs.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
index 635642a3ecbc..2090f3c9f689 100644
--- a/drivers/infiniband/core/verbs.c
+++ b/drivers/infiniband/core/verbs.c
@@ -1219,16 +1219,6 @@ struct ib_qp *ib_create_named_qp(struct ib_pd *pd,
struct ib_qp *qp;
int ret;
- if (qp_init_attr->rwq_ind_tbl &&
- (qp_init_attr->recv_cq ||
- qp_init_attr->srq || qp_init_attr->cap.max_recv_wr ||
- qp_init_attr->cap.max_recv_sge))
- return ERR_PTR(-EINVAL);
-
- if ((qp_init_attr->create_flags & IB_QP_CREATE_INTEGRITY_EN) &&
- !(device->attrs.device_cap_flags & IB_DEVICE_INTEGRITY_HANDOVER))
- return ERR_PTR(-EINVAL);
-
/*
* If the callers is using the RDMA API calculate the resources
* needed for the RDMA READ/WRITE operations.
--
2.31.1
next prev parent reply other threads:[~2021-07-21 6:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 6:12 [PATCH rdma-next 0/7] Separate user/kernel QP creation logic Leon Romanovsky
2021-07-21 6:13 ` [PATCH rdma-next 1/7] RDMA/mlx5: Delete not-available udata check Leon Romanovsky
2021-07-21 6:13 ` [PATCH rdma-next 2/7] RDMA/core: Delete duplicated and unreachable code Leon Romanovsky
2021-07-21 6:13 ` Leon Romanovsky [this message]
2021-07-21 6:41 ` [PATCH rdma-next 3/7] RDMA/core: Remove protection from wrong in-kernel API usage Christoph Hellwig
2021-07-21 6:56 ` Leon Romanovsky
2021-07-21 6:13 ` [PATCH rdma-next 4/7] RDMA/core: Reorganize create QP low-level functions Leon Romanovsky
2021-07-21 6:45 ` Christoph Hellwig
2021-07-21 6:58 ` Leon Romanovsky
2021-07-21 7:47 ` Mark Zhang
2021-07-21 7:49 ` Leon Romanovsky
2021-07-21 6:13 ` [PATCH rdma-next 5/7] RDMA/core: Configure selinux QP during creation Leon Romanovsky
2021-07-21 6:13 ` [PATCH rdma-next 6/7] RDMA/core: Properly increment and decrement QP usecnts Leon Romanovsky
2021-07-21 6:13 ` [PATCH rdma-next 7/7] RDMA/core: Create clean QP creations interface for uverbs Leon Romanovsky
2021-07-21 6:48 ` Christoph Hellwig
2021-07-21 7:06 ` Leon Romanovsky
2021-07-21 7:12 ` Christoph Hellwig
2021-07-21 7:20 ` Christoph Hellwig
2021-07-21 7:31 ` Leon Romanovsky
2021-07-21 7:30 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8084238e374fe487c3f9728c2ee5ec8736c204d5.1626846795.git.leonro@nvidia.com \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).