From: Davidlohr Bueso <dbueso@suse.de>
To: Ran Xiaokai <cgel.zte@gmail.com>
Cc: christian.brauner@ubuntu.com, jamorris@linux.microsoft.com,
keescook@chromium.org, ktkhai@virtuozzo.com, legion@kernel.org,
linux-kernel@vger.kernel.org, ran.xiaokai@zte.com.cn,
varad.gautam@suse.com
Subject: Re: [PATCH] tests: add mqueue sysctl tests for user namespace
Date: Mon, 23 Aug 2021 08:26:28 -0700 [thread overview]
Message-ID: <80849d5c6fb87d1404ec8b2a6d9fe78f@suse.de> (raw)
In-Reply-To: <20210823032909.45736-1-ran.xiaokai@zte.com.cn>
On 2021-08-22 20:29, Ran Xiaokai wrote:
> create mode 100644 tools/testing/selftests/mqueue_sysctl/Makefile
> create mode 100644 tools/testing/selftests/mqueue_sysctl/config
> create mode 100644
> tools/testing/selftests/mqueue_sysctl/mq_sysctl_test.c
It would be better to use the already existing mqueue directory, instead
of
creating a new one just for sysctl stuff. Also, while nit, perhaps
mq_sysctl_tests.c (plural) to go with the other naming of the tests...
Thanks,
Davidlohr
next prev parent reply other threads:[~2021-08-23 15:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 3:06 [PATCH] ipc: add set_ownership() and permissions() callbacks for posix mqueue sysctl cgel.zte
2021-07-29 14:53 ` Christian Brauner
2021-08-03 10:31 ` CGEL
2021-08-03 14:01 ` Christian Brauner
2021-08-11 15:51 ` CGEL
2021-08-23 3:29 ` [PATCH] tests: add mqueue sysctl tests for user namespace Ran Xiaokai
2021-08-23 15:26 ` Davidlohr Bueso [this message]
2021-08-24 12:05 ` Christian Brauner
2021-08-27 9:50 ` [PATCH V2] " CGEL
2021-08-27 10:12 ` [PATCH V2] ipc: add set_ownership() and permissions() callbacks for posix mqueue sysctl CGEL
2021-09-13 14:40 ` Christian Brauner
2021-09-13 19:42 ` Davidlohr Bueso
2021-09-16 1:49 ` CGEL
2021-10-04 10:53 ` Christian Brauner
2021-12-01 7:14 ` CGEL
2021-12-01 12:53 ` Christian Brauner
2022-04-06 7:59 ` cgel.zte
2021-07-30 15:09 ` [PATCH] " Davidlohr Bueso
2021-08-03 10:34 ` CGEL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80849d5c6fb87d1404ec8b2a6d9fe78f@suse.de \
--to=dbueso@suse.de \
--cc=cgel.zte@gmail.com \
--cc=christian.brauner@ubuntu.com \
--cc=jamorris@linux.microsoft.com \
--cc=keescook@chromium.org \
--cc=ktkhai@virtuozzo.com \
--cc=legion@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ran.xiaokai@zte.com.cn \
--cc=varad.gautam@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).