linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Simon Horman <horms@verge.net.au>,
	yangxingwu <xingwu.yang@gmail.com>,
	Pablo Neira Ayuso <pablo@netfilter.org>
Cc: wensong@linux-vs.org, ja@ssi.bg, kadlec@blackhole.kfki.hu,
	fw@strlen.de, davem@davemloft.net, netdev@vger.kernel.org,
	lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org,
	coreteam@netfilter.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipvs: remove unnecessary space
Date: Wed, 10 Jul 2019 17:22:16 -0700	[thread overview]
Message-ID: <80a4e132f3be48899904eccdc023f5c53229840b.camel@perches.com> (raw)
In-Reply-To: <20190710080609.smxjqe2d5jyro4hv@verge.net.au>

On Wed, 2019-07-10 at 10:06 +0200, Simon Horman wrote:
> On Wed, Jul 10, 2019 at 03:45:52PM +0800, yangxingwu wrote:
> > this patch removes the extra space.
> > 
> > Signed-off-by: yangxingwu <xingwu.yang@gmail.com>
> 
> Thanks, this looks good to me.
> 
> Acked-by: Simon Horman <horms@verge.net.au>
> 
> Pablo, please consider including this in nf-next.
> 
> 
> > ---
> >  net/netfilter/ipvs/ip_vs_mh.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c
> > index 94d9d34..98e358e 100644
> > --- a/net/netfilter/ipvs/ip_vs_mh.c
> > +++ b/net/netfilter/ipvs/ip_vs_mh.c
> > @@ -174,8 +174,8 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s,
> >  		return 0;
> >  	}
> >  
> > -	table =  kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE),
> > -			 sizeof(unsigned long), GFP_KERNEL);
> > +	table =	kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE),
> > +			sizeof(unsigned long), GFP_KERNEL);

bitmap_alloc?

> >  	if (!table)
> >  		return -ENOMEM;
> >  
> > -- 
> > 1.8.3.1
> > 


  reply	other threads:[~2019-07-11  0:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10  7:45 [PATCH] ipvs: remove unnecessary space yangxingwu
2019-07-10  8:06 ` Simon Horman
2019-07-11  0:22   ` Joe Perches [this message]
2019-07-12 13:07     ` yangxingwu
2019-07-15  7:57       ` Pablo Neira Ayuso
2019-07-15  8:26         ` Pablo Neira Ayuso
2019-07-15  8:27   ` Pablo Neira Ayuso
2019-07-16  1:26     ` yangxingwu
2019-07-16  2:13     ` [PATCH v2] net/netfilter: remove unnecessary spaces yangxingwu
2019-07-18 18:26       ` Pablo Neira Ayuso
2019-07-19  1:49         ` yangxingwu
2019-08-13 10:10       ` Pablo Neira Ayuso
2019-07-16  2:18     ` [PATCH] ipvs: remove unnecessary space yangxingwu
2019-07-11  3:39 yangxingwu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80a4e132f3be48899904eccdc023f5c53229840b.camel@perches.com \
    --to=joe@perches.com \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=horms@verge.net.au \
    --cc=ja@ssi.bg \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvs-devel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=wensong@linux-vs.org \
    --cc=xingwu.yang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).