From: santosh.shilimkar@oracle.com
To: Nishanth Menon <nm@ti.com>, Tero Kristo <t-kristo@ti.com>
Cc: ssantosh@kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc: ti: ti_sci_pm_domains: check for proper args count in xlate
Date: Wed, 28 Oct 2020 16:17:53 -0700 [thread overview]
Message-ID: <80b42f3e-d333-3e01-478d-a46b8660db1e@oracle.com> (raw)
In-Reply-To: <20201028214336.qfwbs46j5x6cpjhr@award>
On 10/28/20 2:43 PM, Nishanth Menon wrote:
> On 16:17-20201028, Tero Kristo wrote:
>> K2G devices still only use single parameter for power-domains property,
>> so check for this properly in the driver. Without this, every peripheral
>> fails to probe resulting in boot failure.
>>
>> Fixes: efa5c01cd7ee ("soc: ti: ti_sci_pm_domains: switch to use multiple genpds instead of one")
>> Reported-by: Nishanth Menon <nm@ti.com>
>> Signed-off-by: Tero Kristo <t-kristo@ti.com>
>> ---
>> drivers/soc/ti/ti_sci_pm_domains.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/ti/ti_sci_pm_domains.c b/drivers/soc/ti/ti_sci_pm_domains.c
>> index af2126d2b2ff..8afb3f45d263 100644
>> --- a/drivers/soc/ti/ti_sci_pm_domains.c
>> +++ b/drivers/soc/ti/ti_sci_pm_domains.c
>> @@ -91,7 +91,7 @@ static struct generic_pm_domain *ti_sci_pd_xlate(
>> struct genpd_onecell_data *genpd_data = data;
>> unsigned int idx = genpdspec->args[0];
>>
>> - if (genpdspec->args_count < 2)
>> + if (genpdspec->args_count != 1 && genpdspec->args_count != 2)
>> return ERR_PTR(-EINVAL);
>>
>> if (idx >= genpd_data->num_domains) {
>
>
> Thanks Tero.
>
> Acked-by: Nishanth Menon <nm@ti.com>
>
> Santosh: can we queue this one for 5.10? - I am trying to track and get
> all platforms booting and functional in 5.10
>
Sure. Can you re-post with my ack to soc@kernel.org and copy me ?
Will try to get this one applied.
Regards,
Santosh
prev parent reply other threads:[~2020-10-28 23:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 14:17 [PATCH] soc: ti: ti_sci_pm_domains: check for proper args count in xlate Tero Kristo
2020-10-28 21:43 ` Nishanth Menon
2020-10-28 23:17 ` santosh.shilimkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80b42f3e-d333-3e01-478d-a46b8660db1e@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).