From: Stefan Agner <stefan@agner.ch>
To: Sean Paul <sean@poorly.run>
Cc: Leonard Crestez <leonard.crestez@nxp.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Philipp Zabel <p.zabel@pengutronix.de>,
Marek Vasut <marex@denx.de>, Shawn Guo <shawnguo@kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
David Airlie <airlied@linux.ie>,
Robert Chiras <robert.chiras@nxp.com>,
Anson Huang <Anson.Huang@nxp.com>,
dri-devel@lists.freedesktop.org, linux-imx@nxp.com,
kernel@pengutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [RESEND 0/5] drm/mxsfb: Fix runtime PM for unpowering lcdif block
Date: Mon, 17 Sep 2018 16:37:25 -0700 [thread overview]
Message-ID: <80da134658da77f0d3f8fda6894ab756@agner.ch> (raw)
In-Reply-To: <20180917191602.GP188300@art_vandelay>
On 17.09.2018 12:16, Sean Paul wrote:
> On Mon, Sep 17, 2018 at 04:42:10PM +0300, Leonard Crestez wrote:
>> Adding lcdif nodes to a power domain currently doesn't work, it results
>> in black/corrupted screens or hangs. While the driver does enable
>> runtime pm it does not deal correctly with the block being unpowered.
>>
>> ---
>>
>> All patches in this series have review tags from a while ago and I
>> tested them again on top of next-20180913. No changes since last
>> version: https://lkml.org/lkml/2018/8/27/299
>>
>> This series stalled so I reached out to Marek on IRC and he was
>> surprised to be listed as maintainer
>
> Hopefully not too surprised since Marek added themself to MAINTAINERS when
> adding the driver :-)
There have been some confusion about the DRM development processes around the mxsfb already in the past.
I guess in general it would be quite clear: Marek as maintainer of mxsfb should pick up the patches and send a pull request to the next level of maintainer, which in DRM case would be David Airlie:
https://01.org/linuxgraphics/gfx-docs/maintainer-tools/repositories.html
>
> I suppose we should probably move this to drm-misc since it qualifies as a
> "small driver" and needs a home. Looking through git history shows the last
> mxsfb-specific change was back in 02/17. Everything else has been drm-wide
> refactors. Thoughts?
>
> Marek/Leonard: Care to sign up to be listed as a reviewers?
>
drm-misc seems to make sense. I volunteer to be listed as reviewer or co-maintainer.
I am actually maintainer for the DCU driver (another display controller IP used in NXP products). I should probably move that to drm-misc too...
--
Stefan
> Sean
>
>> and asked me to resend and add
>> Daniel Vetter.
>>
>> Perhaps it would help to clarify that the pengutronix people should feel
>> free to push patches in this area?
>>
>> Right now drm/imx is mostly for IPUv3 but there are other display output
>> paths on imx, such as the LCDIF supported by this driver. This LCDIF
>> block is included on imx8 so still quite relevant.
>>
>> Leonard Crestez (5):
>> drm/mxsfb: Move axi clk enable/disable to crtc enable/disable
>> drm/mxsfb: Fix initial corrupt frame when activating display
>> drm/mxsfb: Add pm_runtime calls to pipe_enable/disable
>> drm/mxsfb: Add PM_SLEEP support
>> drm/mxsfb: Switch to drm_atomic_helper_commit_tail_rpm
>>
>> drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 53 +++++++++++++++++++-----------
>> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 40 ++++++++++++++++++++++
>> 2 files changed, 74 insertions(+), 19 deletions(-)
>>
>> --
>> 2.17.1
>>
next prev parent reply other threads:[~2018-09-17 23:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 13:42 [RESEND 0/5] drm/mxsfb: Fix runtime PM for unpowering lcdif block Leonard Crestez
2018-09-17 13:42 ` [RESEND 1/5] drm/mxsfb: Move axi clk enable/disable to crtc enable/disable Leonard Crestez
2018-09-17 13:42 ` [RESEND 2/5] drm/mxsfb: Fix initial corrupt frame when activating display Leonard Crestez
2018-09-17 13:42 ` [RESEND 3/5] drm/mxsfb: Add pm_runtime calls to pipe_enable/disable Leonard Crestez
2018-09-17 13:42 ` [RESEND 4/5] drm/mxsfb: Add PM_SLEEP support Leonard Crestez
2018-09-17 13:42 ` [RESEND 5/5] drm/mxsfb: Switch to drm_atomic_helper_commit_tail_rpm Leonard Crestez
2018-09-17 19:16 ` [RESEND 0/5] drm/mxsfb: Fix runtime PM for unpowering lcdif block Sean Paul
2018-09-17 19:34 ` Leonard Crestez
2018-09-17 23:37 ` Stefan Agner [this message]
2018-09-20 15:59 ` Leonard Crestez
2018-09-20 16:39 ` Sean Paul
2018-09-26 20:12 ` Stefan Agner
2018-09-26 8:13 ` Sean Paul
-- strict thread matches above, loose matches on Subject: below --
2018-08-27 11:10 Leonard Crestez
2018-08-27 12:02 ` Philipp Zabel
2018-09-03 13:51 ` Leonard Crestez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80da134658da77f0d3f8fda6894ab756@agner.ch \
--to=stefan@agner.ch \
--cc=Anson.Huang@nxp.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=p.zabel@pengutronix.de \
--cc=robert.chiras@nxp.com \
--cc=sean@poorly.run \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).